mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-03 02:06:18 +00:00
db2effaca4cf82bf806596d16f9797d3692e2da7 scripted-diff: refactor: CWallet::Create() -> CreateNew() (David Gumberg)
27e021ebc0dd3517a71f3ddb38ed265a19693d4c wallet: Correctly log stats for encrypted messages. (David Gumberg)
d8bec61be233b9cb6d5db886e8f1c1f058288fb5 wallet: remove loading logic from CWallet::Create (David Gumberg)
f35acc893fb3378b2ad39608fe254d33af6cce9f refactor: wallet: Factor out `WriteVersion()` from `PopulateWalletFromDB()` (David Gumberg)
e12ff8aca049ec7b054cb3047a167c7ce8dbd421 test: wallet: Split create and load (David Gumberg)
70dbc79b09acf7b1515532ee20c7533c938ffb70 wallet: Use CWallet::LoadExisting() for loading existing wallets. (David Gumberg)
ae66e011646266abb67b31027bc29e0ce1d08ad4 wallet: Create separate function for wallet load (David Gumberg)
bc69070416c62a88d8f4029280ec10d6f9ec8d20 refactor: Wallet stats logging in its own function (David Gumberg)
a9d64cd49c69dafd6496ccb5aef4cd6d8898966b wallet: Remove redundant birth time update (David Gumberg)
b4a49cc7275efc16d4a4179ed34b50de5bb7367e wallet: Move argument parsing to before DB load (David Gumberg)
b15a94a618c53041e97ccfface3045a0642777e1 refactor: Split out wallet argument loading (David Gumberg)
a02c4a82d88a3e9a24ec2aa0b828b8cc533dde58 refactor: Move -walletbroadcast setting init (David Gumberg)
411caf72815bdf2e176e790a4c63f745517c4bb4 wallet: refactor: PopulateWalletFromDB use switch statement. (David Gumberg)
a48e23f566ccaf9b81fe0684885972d9ee34afd3 refactor: wallet: move error handling to PopulateWalletFromDB() (David Gumberg)
0972785fd723b9b3c84844bf999d6e08e163ef9d wallet: Delete unnecessary PopulateWalletFromDB() calls (David Gumberg)
f0a046094e4c4b5f3af0e453492077f4911e0132 scripted-diff: refactor: CWallet::LoadWallet->PopulateWalletFromDB (David Gumberg)
Pull request description:
This PR is mostly a refactor which splits out logic used for creating wallets and for loading wallets, both of which are presently contained in `CWallet::Create()` into `CWallet::CreateNew()` and `CWallet::LoadExisting()`
The real win of this PR is that `CWallet::Create()` uses a very bad heuristic for trying to guess whether or not it is supposed to be creating a new wallet or loading an existing wallet:
370c592612/src/wallet/wallet.cpp (L2882-L2885)
This heuristic assumes that wallets with no `ScriptPubKeyMans` are being created, which sounds reasonable, but as demonstrated in #32112 and #32111, this can happen when the user tries to load a wallet file that is corrupted, both issues are fixed by this PR and any other misbehavior for wallet files which succeeded the broken heuristic's sniff test for new wallets.
It was already the case that every caller of `CWallet::Create()` knows whether it is creating a wallet or loading one, so we can avoid replacing this bad heuristic with another one, and just shift the burden to the caller.
ACKs for top commit:
achow101:
ACK db2effaca4cf82bf806596d16f9797d3692e2da7
polespinasa:
approach ACK db2effaca4cf82bf806596d16f9797d3692e2da7
w0xlt:
reACK db2effaca4cf82bf806596d16f9797d3692e2da7
murchandamus:
ACK db2effaca4cf82bf806596d16f9797d3692e2da7
rkrux:
ACK db2effaca4cf82bf806596d16f9797d3692e2da7
Tree-SHA512: c28d60e0a3001058da3fd2bdbe0726c7ebe742a4b900a1dee2e5132eccc22e49619cb747a99b4032b000eafd4aa2fdd4ec244c32be2012aba809fdc94b5f6ecd
319 lines
11 KiB
C++
319 lines
11 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_WALLET_WALLETDB_H
|
|
#define BITCOIN_WALLET_WALLETDB_H
|
|
|
|
#include <key.h>
|
|
#include <primitives/transaction_identifier.h>
|
|
#include <script/sign.h>
|
|
#include <wallet/db.h>
|
|
#include <wallet/walletutil.h>
|
|
|
|
#include <cstdint>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
class CScript;
|
|
class uint160;
|
|
class uint256;
|
|
struct CBlockLocator;
|
|
|
|
namespace wallet {
|
|
class CMasterKey;
|
|
class CWallet;
|
|
class CWalletTx;
|
|
struct WalletContext;
|
|
|
|
// Logs information about the database, including available engines, features, and other capabilities
|
|
void LogDBInfo();
|
|
|
|
/**
|
|
* Overview of wallet database classes:
|
|
*
|
|
* - WalletBatch is an abstract modifier object for the wallet database, and encapsulates a database
|
|
* batch update as well as methods to act on the database. It should be agnostic to the database implementation.
|
|
*/
|
|
|
|
/** Error statuses for the wallet database.
|
|
* Values are in order of severity. When multiple errors occur, the most severe (highest value) will be returned.
|
|
*/
|
|
enum class DBErrors : int
|
|
{
|
|
LOAD_OK = 0,
|
|
NEED_RESCAN = 1,
|
|
NEED_REWRITE = 2,
|
|
EXTERNAL_SIGNER_SUPPORT_REQUIRED = 3,
|
|
NONCRITICAL_ERROR = 4,
|
|
TOO_NEW = 5,
|
|
UNKNOWN_DESCRIPTOR = 6,
|
|
LOAD_FAIL = 7,
|
|
UNEXPECTED_LEGACY_ENTRY = 8,
|
|
LEGACY_WALLET = 9,
|
|
CORRUPT = 10,
|
|
};
|
|
|
|
namespace DBKeys {
|
|
extern const std::string ACENTRY;
|
|
extern const std::string ACTIVEEXTERNALSPK;
|
|
extern const std::string ACTIVEINTERNALSPK;
|
|
extern const std::string BESTBLOCK;
|
|
extern const std::string BESTBLOCK_NOMERKLE;
|
|
extern const std::string CRYPTED_KEY;
|
|
extern const std::string CSCRIPT;
|
|
extern const std::string DEFAULTKEY;
|
|
extern const std::string DESTDATA;
|
|
extern const std::string FLAGS;
|
|
extern const std::string HDCHAIN;
|
|
extern const std::string KEY;
|
|
extern const std::string KEYMETA;
|
|
extern const std::string LOCKED_UTXO;
|
|
extern const std::string MASTER_KEY;
|
|
extern const std::string MINVERSION;
|
|
extern const std::string NAME;
|
|
extern const std::string OLD_KEY;
|
|
extern const std::string ORDERPOSNEXT;
|
|
extern const std::string POOL;
|
|
extern const std::string PURPOSE;
|
|
extern const std::string SETTINGS;
|
|
extern const std::string TX;
|
|
extern const std::string VERSION;
|
|
extern const std::string WALLETDESCRIPTOR;
|
|
extern const std::string WALLETDESCRIPTORCKEY;
|
|
extern const std::string WALLETDESCRIPTORKEY;
|
|
extern const std::string WATCHMETA;
|
|
extern const std::string WATCHS;
|
|
|
|
// Keys in this set pertain only to the legacy wallet (LegacyScriptPubKeyMan) and are removed during migration from legacy to descriptors.
|
|
extern const std::unordered_set<std::string> LEGACY_TYPES;
|
|
} // namespace DBKeys
|
|
|
|
/* simple HD chain data model */
|
|
class CHDChain
|
|
{
|
|
public:
|
|
uint32_t nExternalChainCounter;
|
|
uint32_t nInternalChainCounter;
|
|
CKeyID seed_id; //!< seed hash160
|
|
int64_t m_next_external_index{0}; // Next index in the keypool to be used. Memory only.
|
|
int64_t m_next_internal_index{0}; // Next index in the keypool to be used. Memory only.
|
|
|
|
static const int VERSION_HD_BASE = 1;
|
|
static const int VERSION_HD_CHAIN_SPLIT = 2;
|
|
static const int CURRENT_VERSION = VERSION_HD_CHAIN_SPLIT;
|
|
int nVersion;
|
|
|
|
CHDChain() { SetNull(); }
|
|
|
|
SERIALIZE_METHODS(CHDChain, obj)
|
|
{
|
|
READWRITE(obj.nVersion, obj.nExternalChainCounter, obj.seed_id);
|
|
if (obj.nVersion >= VERSION_HD_CHAIN_SPLIT) {
|
|
READWRITE(obj.nInternalChainCounter);
|
|
}
|
|
}
|
|
|
|
void SetNull()
|
|
{
|
|
nVersion = CHDChain::CURRENT_VERSION;
|
|
nExternalChainCounter = 0;
|
|
nInternalChainCounter = 0;
|
|
seed_id.SetNull();
|
|
}
|
|
|
|
bool operator==(const CHDChain& chain) const
|
|
{
|
|
return seed_id == chain.seed_id;
|
|
}
|
|
};
|
|
|
|
class CKeyMetadata
|
|
{
|
|
public:
|
|
static const int VERSION_BASIC=1;
|
|
static const int VERSION_WITH_HDDATA=10;
|
|
static const int VERSION_WITH_KEY_ORIGIN = 12;
|
|
static const int CURRENT_VERSION=VERSION_WITH_KEY_ORIGIN;
|
|
int nVersion;
|
|
int64_t nCreateTime; // 0 means unknown
|
|
std::string hdKeypath; //optional HD/bip32 keypath. Still used to determine whether a key is a seed. Also kept for backwards compatibility
|
|
CKeyID hd_seed_id; //id of the HD seed used to derive this key
|
|
KeyOriginInfo key_origin; // Key origin info with path and fingerprint
|
|
bool has_key_origin = false; //!< Whether the key_origin is useful
|
|
|
|
CKeyMetadata()
|
|
{
|
|
SetNull();
|
|
}
|
|
explicit CKeyMetadata(int64_t nCreateTime_)
|
|
{
|
|
SetNull();
|
|
nCreateTime = nCreateTime_;
|
|
}
|
|
|
|
SERIALIZE_METHODS(CKeyMetadata, obj)
|
|
{
|
|
READWRITE(obj.nVersion, obj.nCreateTime);
|
|
if (obj.nVersion >= VERSION_WITH_HDDATA) {
|
|
READWRITE(obj.hdKeypath, obj.hd_seed_id);
|
|
}
|
|
if (obj.nVersion >= VERSION_WITH_KEY_ORIGIN)
|
|
{
|
|
READWRITE(obj.key_origin);
|
|
READWRITE(obj.has_key_origin);
|
|
}
|
|
}
|
|
|
|
void SetNull()
|
|
{
|
|
nVersion = CKeyMetadata::CURRENT_VERSION;
|
|
nCreateTime = 0;
|
|
hdKeypath.clear();
|
|
hd_seed_id.SetNull();
|
|
key_origin.clear();
|
|
has_key_origin = false;
|
|
}
|
|
};
|
|
|
|
struct DbTxnListener
|
|
{
|
|
std::function<void()> on_commit, on_abort;
|
|
};
|
|
|
|
/** Access to the wallet database.
|
|
* Opens the database and provides read and write access to it. Each read and write is its own transaction.
|
|
* Multiple operation transactions can be started using TxnBegin() and committed using TxnCommit()
|
|
* Otherwise the transaction will be committed when the object goes out of scope.
|
|
* Optionally (on by default) it will flush to disk on close.
|
|
* Every 1000 writes will automatically trigger a flush to disk.
|
|
*/
|
|
class WalletBatch
|
|
{
|
|
private:
|
|
template <typename K, typename T>
|
|
bool WriteIC(const K& key, const T& value, bool fOverwrite = true)
|
|
{
|
|
if (!m_batch->Write(key, value, fOverwrite)) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
template <typename K>
|
|
bool EraseIC(const K& key)
|
|
{
|
|
if (!m_batch->Erase(key)) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
public:
|
|
explicit WalletBatch(WalletDatabase &database) :
|
|
m_batch(database.MakeBatch())
|
|
{
|
|
}
|
|
WalletBatch(const WalletBatch&) = delete;
|
|
WalletBatch& operator=(const WalletBatch&) = delete;
|
|
|
|
bool WriteName(const std::string& strAddress, const std::string& strName);
|
|
bool EraseName(const std::string& strAddress);
|
|
|
|
bool WritePurpose(const std::string& strAddress, const std::string& purpose);
|
|
bool ErasePurpose(const std::string& strAddress);
|
|
|
|
bool WriteTx(const CWalletTx& wtx);
|
|
bool EraseTx(Txid hash);
|
|
|
|
bool WriteKeyMetadata(const CKeyMetadata& meta, const CPubKey& pubkey, bool overwrite);
|
|
bool WriteKey(const CPubKey& vchPubKey, const CPrivKey& vchPrivKey, const CKeyMetadata &keyMeta);
|
|
bool WriteCryptedKey(const CPubKey& vchPubKey, const std::vector<unsigned char>& vchCryptedSecret, const CKeyMetadata &keyMeta);
|
|
bool WriteMasterKey(unsigned int nID, const CMasterKey& kMasterKey);
|
|
bool EraseMasterKey(unsigned int id);
|
|
|
|
bool WriteWatchOnly(const CScript &script, const CKeyMetadata &keymeta);
|
|
bool EraseWatchOnly(const CScript &script);
|
|
|
|
bool WriteBestBlock(const CBlockLocator& locator);
|
|
bool ReadBestBlock(CBlockLocator& locator);
|
|
|
|
// Returns true if wallet stores encryption keys
|
|
bool IsEncrypted();
|
|
|
|
bool WriteOrderPosNext(int64_t nOrderPosNext);
|
|
|
|
bool WriteDescriptorKey(const uint256& desc_id, const CPubKey& pubkey, const CPrivKey& privkey);
|
|
bool WriteCryptedDescriptorKey(const uint256& desc_id, const CPubKey& pubkey, const std::vector<unsigned char>& secret);
|
|
bool WriteDescriptor(const uint256& desc_id, const WalletDescriptor& descriptor);
|
|
bool WriteDescriptorDerivedCache(const CExtPubKey& xpub, const uint256& desc_id, uint32_t key_exp_index, uint32_t der_index);
|
|
bool WriteDescriptorParentCache(const CExtPubKey& xpub, const uint256& desc_id, uint32_t key_exp_index);
|
|
bool WriteDescriptorLastHardenedCache(const CExtPubKey& xpub, const uint256& desc_id, uint32_t key_exp_index);
|
|
bool WriteDescriptorCacheItems(const uint256& desc_id, const DescriptorCache& cache);
|
|
|
|
bool WriteLockedUTXO(const COutPoint& output);
|
|
bool EraseLockedUTXO(const COutPoint& output);
|
|
|
|
bool WriteAddressPreviouslySpent(const CTxDestination& dest, bool previously_spent);
|
|
bool WriteAddressReceiveRequest(const CTxDestination& dest, const std::string& id, const std::string& receive_request);
|
|
bool EraseAddressReceiveRequest(const CTxDestination& dest, const std::string& id);
|
|
bool EraseAddressData(const CTxDestination& dest);
|
|
|
|
bool WriteActiveScriptPubKeyMan(uint8_t type, const uint256& id, bool internal);
|
|
bool EraseActiveScriptPubKeyMan(uint8_t type, bool internal);
|
|
|
|
DBErrors LoadWallet(CWallet* pwallet);
|
|
|
|
//! Write the given client_version.
|
|
bool WriteVersion(int client_version) { return m_batch->Write(DBKeys::VERSION, CLIENT_VERSION); }
|
|
|
|
//! Delete records of the given types
|
|
bool EraseRecords(const std::unordered_set<std::string>& types);
|
|
|
|
bool WriteWalletFlags(uint64_t flags);
|
|
//! Begin a new transaction
|
|
bool TxnBegin();
|
|
//! Commit current transaction
|
|
bool TxnCommit();
|
|
//! Abort current transaction
|
|
bool TxnAbort();
|
|
bool HasActiveTxn() { return m_batch->HasActiveTxn(); }
|
|
|
|
//! Registers db txn callback functions
|
|
void RegisterTxnListener(const DbTxnListener& l);
|
|
|
|
private:
|
|
std::unique_ptr<DatabaseBatch> m_batch;
|
|
|
|
// External functions listening to the current db txn outcome.
|
|
// Listeners are cleared at the end of the transaction.
|
|
std::vector<DbTxnListener> m_txn_listeners;
|
|
};
|
|
|
|
/**
|
|
* Executes the provided function 'func' within a database transaction context.
|
|
*
|
|
* This function ensures that all db modifications performed within 'func()' are
|
|
* atomically committed to the db at the end of the process. And, in case of a
|
|
* failure during execution, all performed changes are rolled back.
|
|
*
|
|
* @param database The db connection instance to perform the transaction on.
|
|
* @param process_desc A description of the process being executed, used for logging purposes in the event of a failure.
|
|
* @param func The function to be executed within the db txn context. It returns a boolean indicating whether to commit or roll back the txn.
|
|
* @return true if the db txn executed successfully, false otherwise.
|
|
*/
|
|
bool RunWithinTxn(WalletDatabase& database, std::string_view process_desc, const std::function<bool(WalletBatch&)>& func);
|
|
|
|
bool LoadKey(CWallet* pwallet, DataStream& ssKey, DataStream& ssValue, std::string& strErr);
|
|
bool LoadCryptedKey(CWallet* pwallet, DataStream& ssKey, DataStream& ssValue, std::string& strErr);
|
|
bool LoadEncryptionKey(CWallet* pwallet, DataStream& ssKey, DataStream& ssValue, std::string& strErr);
|
|
bool LoadHDChain(CWallet* pwallet, DataStream& ssValue, std::string& strErr);
|
|
|
|
//! Returns true if there are any DBKeys::LEGACY_TYPES record in the wallet db
|
|
bool HasLegacyRecords(CWallet& wallet);
|
|
bool HasLegacyRecords(CWallet& wallet, DatabaseBatch& batch);
|
|
} // namespace wallet
|
|
|
|
#endif // BITCOIN_WALLET_WALLETDB_H
|