Andrew Chow
7be62df80f
Merge bitcoin/bitcoin#26078 : p2p: return CSubNet in LookupSubNet
...
fb3e812277041f239b97b88689a5076796d75b9b p2p: return `CSubNet` in `LookupSubNet` (brunoerg)
Pull request description:
Analyzing the usage of `LookupSubNet`, noticed that most cases uses check if the subnet is valid by calling `subnet.IsValid()`, and the boolean returned by `LookupSubNet` hasn't been used so much, see:
29d540b7ad/src/httpserver.cpp (L172-L174)
29d540b7ad/src/net_permissions.cpp (L114-L116)
It makes sense to return `CSubNet` instead of `bool`.
ACKs for top commit:
achow101:
ACK fb3e812277041f239b97b88689a5076796d75b9b
vasild:
ACK fb3e812277041f239b97b88689a5076796d75b9b
theStack:
Code-review ACK fb3e812277041f239b97b88689a5076796d75b9b
stickies-v:
Concept ACK, but Approach ~0 (for now). Reviewed the code (fb3e812277041f239b97b88689a5076796d75b9b) and it all looks good to me.
Tree-SHA512: ba50d6bd5d58dfdbe1ce1faebd80dd8cf8c92ac53ef33519860b83399afffab482d5658cb6921b849d7a3df6d5cea911412850e08f3f4e27f7af510fbde4b254
2023-10-26 14:29:47 -04:00
..
2023-10-05 15:10:33 +02:00
2022-12-24 23:49:50 +00:00
2023-09-14 10:25:26 +10:00
2021-12-30 19:36:57 +02:00
2022-04-20 14:35:52 +01:00
2022-12-24 23:49:50 +00:00
2023-07-13 20:37:14 +02:00
2023-01-13 09:40:57 +00:00
2021-12-30 19:36:57 +02:00
2023-09-06 13:59:12 +02:00
2023-07-13 20:37:14 +02:00
2023-07-13 20:37:14 +02:00
2021-12-30 19:36:57 +02:00
2021-11-12 19:51:55 +00:00
2023-09-15 14:34:17 +02:00
2023-10-06 19:43:32 +02:00
2023-03-21 13:04:21 +00:00
2023-08-11 18:11:07 +02:00
2023-02-03 10:33:31 -05:00
2023-10-02 18:10:30 -04:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2023-08-17 15:31:56 -04:00
2023-08-17 15:31:27 -04:00
2021-12-30 19:36:57 +02:00
2023-08-17 15:31:56 -04:00
2023-07-17 13:27:46 +02:00
2021-12-30 19:36:57 +02:00
2023-09-12 22:51:42 +02:00
2023-09-13 16:12:51 +02:00
2022-12-13 15:08:24 -05:00
2021-12-30 19:36:57 +02:00
2023-10-04 13:16:52 +01:00
2023-03-21 13:54:11 +01:00
2021-12-30 19:36:57 +02:00
2023-09-19 13:41:24 +02:00
2023-07-13 20:37:14 +02:00
2023-07-17 09:39:52 +02:00
2023-09-19 14:19:57 +00:00
2023-07-13 20:37:14 +02:00
2023-01-13 09:40:57 +00:00
2023-02-17 13:34:40 -05:00
2023-08-14 17:38:27 -04:00
2023-07-13 20:37:14 +02:00
2023-09-12 12:14:31 -04:00
2023-09-15 14:34:17 +02:00
2021-12-30 19:36:57 +02:00
2021-11-12 19:51:55 +00:00
2023-09-06 13:59:12 +02:00
2023-10-12 11:27:19 +02:00
2023-10-17 18:27:52 -04:00
2022-01-06 22:14:16 -05:00
2021-09-22 10:39:08 +02:00
2021-12-30 19:36:57 +02:00
2022-12-24 23:49:50 +00:00
2023-09-05 10:13:25 +02:00
2023-06-05 11:02:47 -04:00
2023-05-30 16:27:21 -03:00
2022-12-24 23:49:50 +00:00
2023-10-02 18:11:11 -04:00
2023-10-12 11:56:37 +01:00
2023-04-04 18:33:08 +02:00
2021-12-30 19:36:57 +02:00
2023-07-27 09:36:05 +02:00
2023-07-13 20:37:14 +02:00
2023-07-13 20:37:14 +02:00
2023-07-13 20:37:14 +02:00
2023-03-23 19:38:38 +01:00
2023-07-13 20:37:14 +02:00
2023-01-26 10:44:05 +01:00
2023-08-18 12:52:30 -04:00
2023-08-23 20:13:49 -04:00
2023-01-13 09:40:57 +00:00
2023-07-13 20:37:14 +02:00
2021-10-05 11:10:37 +02:00
2023-10-03 11:38:20 -04:00
2023-09-19 14:19:57 +00:00
2023-10-13 08:55:12 -03:00
2021-12-30 19:36:57 +02:00
2022-12-13 15:08:24 -05:00
2023-07-13 20:37:14 +02:00
2021-11-12 19:51:55 +00:00
2023-07-13 20:37:14 +02:00
2023-09-07 11:34:34 +01:00
2023-09-12 12:14:31 -04:00
2021-11-12 19:51:55 +00:00
2022-12-13 15:08:24 -05:00
2023-01-13 09:40:57 +00:00
2023-07-13 20:37:14 +02:00
2023-07-13 20:37:14 +02:00
2023-06-09 14:58:49 -04:00
2023-07-13 20:37:14 +02:00
2021-12-30 19:36:57 +02:00
2023-07-13 20:37:14 +02:00
2023-07-13 20:37:14 +02:00
2023-01-26 10:44:05 +01:00
2023-01-26 10:44:05 +01:00
2023-10-12 11:56:37 +01:00
2023-07-13 20:37:14 +02:00
2021-12-30 19:36:57 +02:00
2023-09-12 12:14:31 -04:00
2023-09-07 11:34:34 +01:00
2023-07-13 20:37:14 +02:00
2023-06-03 15:37:11 +02:00
2023-08-07 11:32:34 +02:00
2023-07-13 20:37:14 +02:00