Wladimir J. van der Laan 7b6e8bc442

Merge #10795: No longer ever reuse keypool indexes ...

1fc8c3d No longer ever reuse keypool indexes (Matt Corallo)

Pull request description:

  This fixes an issue where you could reserve a keypool entry, then
  top up the keypool, writing out a new key at the given index, then
  return they key from the pool. This isnt likely to cause issues,
  but given there is no reason to ever re-use keypool indexes
  (they're 64 bits...), best to avoid it alltogether.

  Builds on #10235, should probably get a 15 tag.

Tree-SHA512: c13a18a90f1076fb74307f2d64e9d80149811524c6bda259698ff2c65adaf8c6c3f2a3a07a5f4bf03251bc942ba8f5fd33a4427aa4256748c40b062991682caf

2017-07-18 09:30:33 +02:00

..

bench

Avoid static analyzer warnings regarding uninitialized arguments

2017-07-15 14:26:50 +02:00

compat

[trivial] Add end of namespace comments

2017-05-31 22:21:25 +02:00

config

…

consensus

Fix typos

2017-07-15 14:28:40 +02:00

crypto

Limit variable scope

2017-06-05 00:52:36 +02:00

leveldb

Fixed multiple typos

2017-06-22 19:18:10 +03:00

obj

…

obj-test

…

policy

Improve api to estimatesmartfee

2017-07-17 10:52:14 -04:00

primitives

Merge #10760: Avoid dereference-of-casted-pointer

2017-07-15 12:22:50 -07:00

qt

Merge #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue

2017-07-17 17:13:11 +02:00

rpc

Convert named argument from nblocks to conf_target

2017-07-17 10:52:14 -04:00

script

Avoid dereference-of-casted-pointer

2017-07-07 10:45:31 -07:00

secp256k1

Fixed multiple typos

2017-06-22 19:18:10 +03:00

support

Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class

2017-06-28 02:12:06 +02:00

test

Merge #10706: Improve wallet fee logic and fix GUI bugs

2017-07-17 09:25:33 +02:00

univalue

…

wallet

No longer ever reuse keypool indexes

2017-07-17 12:12:48 -04:00

zmq

Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class

2017-06-28 02:12:06 +02:00

.clang-format

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

addrdb.cpp

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrdb.h

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrman.cpp

Merge #9792: FastRandomContext improvements and switch to ChaCha20

2017-04-24 14:28:49 +02:00

addrman.h

Merge #9792: FastRandomContext improvements and switch to ChaCha20

2017-04-24 14:28:49 +02:00

amount.h

Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module

2017-05-03 18:00:13 +02:00

arith_uint256.cpp

Fix instantiation and array accesses in class base_uint<BITS>

2017-06-07 17:21:29 +00:00

arith_uint256.h

Fix instantiation and array accesses in class base_uint<BITS>

2017-06-07 17:21:29 +00:00

base58.cpp

Fix subscript[0] in base58.cpp

2017-07-08 13:33:01 -07:00

base58.h

Fix subscript[0] in base58.cpp

2017-07-08 13:33:01 -07:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Remove duplicate include

2017-07-16 02:25:25 +02:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

bitcoind-res.rc

…

bitcoind.cpp

init: Factor out AppInitLockDataDirectory

2017-07-17 14:56:52 +02:00

blockencodings.cpp

Fix typos

2017-07-15 14:28:40 +02:00

blockencodings.h

…

bloom.cpp

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

bloom.h

…

chain.cpp

[MOVEONLY] Move LastCommonAncestor to chain

2017-06-26 10:45:48 -07:00

chain.h

[MOVEONLY] Move LastCommonAncestor to chain

2017-06-26 10:45:48 -07:00

chainparams.cpp

chainparams: make supported service bits option explicit

2017-06-22 15:21:22 -04:00

chainparams.h

chainparams: make supported service bits option explicit

2017-06-22 15:21:22 -04:00

chainparamsbase.cpp

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

chainparamsbase.h

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

chainparamsseeds.h

…

checkpoints.cpp

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

checkpoints.h

…

checkqueue.h

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

clientversion.cpp

…

clientversion.h

Fix build warning from #error text

2017-04-07 14:37:25 -04:00

coins.cpp

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

coins.h

Merge #10558: Address nits from per-utxo change

2017-06-28 11:44:22 -07:00

compat.h

…

compressor.cpp

Fix subscript[0] in compressor.cpp

2017-07-08 13:33:01 -07:00

compressor.h

…

core_io.h

…

core_memusage.h

Avoid dereference-of-casted-pointer

2017-07-07 10:45:31 -07:00

core_read.cpp

Fix signed/unsigned comparison warning introduced in c8e29d7ff0.

2017-07-12 14:03:42 -04:00

core_write.cpp

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

cuckoocache.h

Merge #10577: Add an explanation of quickly hashing onto a non-power of two range.

2017-06-24 11:28:04 +02:00

dbwrapper.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

dbwrapper.h

Report on-disk size in gettxoutsetinfo

2017-05-26 13:33:39 -07:00

fs.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

fs.h

[Trivial] Add BITCOIN_FS_H endif footer in fs.h

2017-05-19 02:01:28 -07:00

hash.cpp

Cleanup (safe, it was checked) subscript[0] in MurmurHash3 (and cleanup MurmurHash3 to be more clear).

2017-07-08 13:33:01 -07:00

hash.h

Add specialization of SipHash for 256 + 32 bit data

2017-05-26 13:24:25 -07:00

httprpc.cpp

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

httprpc.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

httpserver.cpp

[refactor] move SplitHostPort() into utilstrencodings

2017-07-12 17:06:15 -04:00

httpserver.h

Fixed multiple typos

2017-06-22 19:18:10 +03:00

indirectmap.h

…

init.cpp

init: Factor out AppInitLockDataDirectory

2017-07-17 14:56:52 +02:00

init.h

init: Factor out AppInitLockDataDirectory

2017-07-17 14:56:52 +02:00

key.cpp

Fix subscript[0] potential bugs in key.cpp

2017-07-08 13:37:06 -07:00

key.h

Remove unused C++ code not covered by unit tests

2017-04-26 21:20:02 +02:00

keystore.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

keystore.h

Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class

2017-06-28 02:12:06 +02:00

limitedmap.h

…

Makefile.am

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

Makefile.bench.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.leveldb.include

build: verify that the assembler can handle crc32 functions

2017-07-13 12:49:05 -04:00

Makefile.qt.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.qttest.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.test.include

Merge #10544: Update to LevelDB 1.20

2017-06-13 19:48:13 +02:00

memusage.h

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

merkleblock.cpp

Merge #9980: Fix mem access violation merkleblock

2017-07-17 15:12:39 -07:00

merkleblock.h

Adding assert to avoid a memory access violation inside of PartialMerkleTree::CalcHash()

2017-07-12 10:48:37 -05:00

miner.cpp

scripted-diff: Fully remove BOOST_FOREACH

2017-06-05 20:10:50 +02:00

miner.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

net_processing.cpp

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

net_processing.h

Add timeout for headers sync

2017-06-05 16:33:35 -04:00

net.cpp

Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector

2017-07-08 13:31:47 -07:00

net.h

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

netaddress.cpp

Fix subscript[0] in netaddress.cpp

2017-07-08 13:33:01 -07:00

netaddress.h

net: add an internal subnet for representing unresolved hostnames

2017-06-14 18:05:00 -04:00

netbase.cpp

Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets

2017-07-15 13:26:49 -07:00

netbase.h

[refactor] move SplitHostPort() into utilstrencodings

2017-07-12 17:06:15 -04:00

netmessagemaker.h

…

noui.cpp

…

noui.h

…

pow.cpp

…

pow.h

…

prevector.h

Explicitly initialize prevector::_union to avoid new warning

2017-07-14 20:52:38 -04:00

protocol.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

protocol.h

Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.

2017-07-16 21:22:05 +02:00

pubkey.cpp

Fix 2 subscript[0] bugs in pubkey.cpp, and eliminate one extra size check

2017-07-08 13:31:47 -07:00

pubkey.h

…

random.cpp

random: only use getentropy on openbsd

2017-07-17 13:14:53 -04:00

random.h

Merge #10377: Use rdrand as entropy source on supported platforms

2017-06-14 15:22:15 +02:00

rest.cpp

Fixed multiple typos

2017-06-22 19:18:10 +03:00

reverse_iterator.h

Introduce src/reverse_iterator.hpp and include it...

2017-06-22 03:48:42 +02:00

reverselock.h

…

scheduler.cpp

Expose if CScheduler is being serviced, assert its not in EmptyQueue

2017-07-10 21:08:19 -04:00

scheduler.h

Expose if CScheduler is being serviced, assert its not in EmptyQueue

2017-07-10 21:08:19 -04:00

serialize.h

Fix subscript[0] in validation.cpp

2017-07-08 13:33:01 -07:00

streams.h

Fix subscript[0] in streams.h

2017-07-08 13:33:01 -07:00

sync.cpp

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

sync.h

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

timedata.h

…

tinyformat.h

…

torcontrol.cpp

Fix subscript[0] in torcontrol

2017-07-08 13:33:01 -07:00

torcontrol.h

…

txdb.cpp

Avoid dereference-of-casted-pointer

2017-07-07 10:45:31 -07:00

txdb.h

Merge #10148: Use non-atomic flushing with block replay

2017-06-28 18:26:41 +02:00

txmempool.cpp

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

txmempool.h

Merge #10685: Clarify CCoinsViewMemPool documentation.

2017-06-28 11:22:00 -07:00

ui_interface.cpp

…

ui_interface.h

[Qt] allow to execute a callback during splashscreen progress

2017-06-29 17:48:08 +02:00

uint256.cpp

…

uint256.h

…

undo.h

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

util.cpp

Merge #10118: Util: Remove redundant calls to argsGlobal.IsArgSet()

2017-06-27 16:29:11 +02:00

util.h

Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.

2017-07-16 21:22:05 +02:00

utilmoneystr.cpp

…

utilmoneystr.h

…

utilstrencodings.cpp

Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets

2017-07-15 13:26:49 -07:00

utilstrencodings.h

[refactor] move SplitHostPort() into utilstrencodings

2017-07-12 17:06:15 -04:00

utiltime.cpp

[logging] log system time and mock time

2017-05-10 15:49:00 -04:00

utiltime.h

[logging] log system time and mock time

2017-05-10 15:49:00 -04:00

validation.cpp

Merge #10618: Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 17:49:48 -07:00

validation.h

Merge #10192: Cache full script execution results in addition to signatures

2017-06-29 20:19:21 +02:00

validationinterface.cpp

Flush CValidationInterface callbacks prior to destruction

2017-07-07 12:55:57 -04:00

validationinterface.h

Remove declaration of unused function: void UpdatedTransaction(const uint256 &)

2017-07-15 20:04:04 +02:00

version.h

Remove unused constant MEMPOOL_GD_VERSION

2017-06-09 01:45:36 +02:00

versionbits.cpp

Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class

2017-06-28 02:12:06 +02:00

versionbits.h

scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/

2017-05-30 19:21:52 +02:00

warnings.cpp

…

warnings.h

…