MarcoFalke
42fedb4acd
Merge bitcoin/bitcoin#23156 : refactor: Remove unused ParsePrechecks and ParseDouble
...
fa9d72a7947d2cff541794e21e0040c3c1d43b32 Remove unused ParseDouble and ParsePrechecks (MarcoFalke)
fa3cd2853530c86c261ac7266ffe4f1726fe9ce6 refactor: Remove unused ParsePrechecks from ParseIntegral (MarcoFalke)
Pull request description:
All of the `ParsePrechecks` are already done by `ToIntegral`, so remove them from `ParseIntegral`.
Also:
* Remove redundant `{}`. See https://github.com/bitcoin/bitcoin/pull/20457#discussion_r720116866
* Add missing failing c-string test case
* Add missing failing test cases for non-int32_t integral types
ACKs for top commit:
laanwj:
Code review ACK fa9d72a7947d2cff541794e21e0040c3c1d43b32, good find on ParseDouble not being used at all, and testing for behavior of embedded NULL characters is always a good thing.
practicalswift:
cr ACK fa9d72a7947d2cff541794e21e0040c3c1d43b32
Tree-SHA512: 3d654dcaebbf312dd57e54241f9aa6d35b1d1d213c37e4c6b8b9a69bcbe8267a397474a8b86b57740fbdd8e3d03b4cdb6a189a9eb8e05cd38035dab195410aa7
2021-10-04 15:06:37 +02:00
..
2020-12-10 07:15:42 +01:00
2021-09-21 10:09:56 +02:00
2021-03-16 19:52:37 +01:00
2021-09-07 13:31:10 +01:00
2021-03-15 10:41:30 +08:00
2021-08-21 19:25:33 +02:00
2021-06-18 23:13:07 +00:00
2021-03-15 17:26:35 -07:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-08-20 15:45:15 +02:00
2021-02-22 10:27:22 +01:00
2021-03-15 10:41:30 +08:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-07-20 15:36:23 +02:00
2021-08-27 10:55:41 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-08-21 19:25:33 +02:00
2021-03-03 12:23:41 +02:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-09-06 12:41:36 +02:00
2021-03-11 13:45:14 +08:00
2021-05-18 07:13:25 +02:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-07 13:41:14 +02:00
2021-05-21 19:41:43 +00:00
2021-08-21 19:25:33 +02:00
2021-03-09 12:56:44 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-05-24 10:29:58 +02:00
2021-09-07 10:44:48 +02:00
2021-07-04 21:30:50 +02:00
2021-03-11 13:45:14 +08:00
2021-08-04 19:20:32 +08:00
2021-06-13 09:43:54 +02:00
2021-09-30 14:21:17 +00:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2021-09-22 10:39:08 +02:00
2021-07-27 14:53:24 +03:00
2021-05-12 16:13:30 +02:00
2021-09-07 15:24:14 +01:00
2021-06-04 16:12:04 +02:00
2021-03-16 19:52:31 +01:00
2021-06-14 13:58:05 +02:00
2021-05-25 08:20:43 -07:00
2020-12-31 09:45:41 +01:00
2021-05-09 10:04:01 +02:00
2021-10-04 15:06:37 +02:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-03-03 09:17:37 +01:00
2021-03-03 09:17:37 +01:00
2021-03-24 06:57:55 +01:00
2021-08-21 19:25:33 +02:00
2020-12-10 07:15:42 +01:00
2021-07-19 19:12:54 +02:00
2021-04-22 17:28:39 +03:00
2020-12-10 07:15:42 +01:00
2021-04-09 13:17:37 +02:00
2020-12-10 07:15:42 +01:00
2020-12-15 19:00:36 +01:00
2021-08-21 19:25:33 +02:00
2021-05-11 21:24:49 +02:00
2021-05-04 09:24:17 +02:00
2020-12-10 07:15:42 +01:00
2021-03-17 14:56:20 +08:00
2021-04-25 10:36:00 +02:00
2020-12-10 07:15:42 +01:00
2021-05-12 10:20:59 +02:00
2020-12-15 19:00:36 +01:00
2021-07-01 12:57:53 -04:00
2021-09-24 14:22:53 -05:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-03-30 10:42:45 +02:00
2021-03-03 09:17:37 +01:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2021-09-30 14:21:17 +00:00
2021-05-09 10:25:21 +02:00
2021-09-29 13:24:14 +02:00
2021-05-11 08:54:24 +02:00
2021-03-04 08:39:27 +01:00
2021-09-24 14:22:49 -05:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2021-08-21 19:25:33 +02:00
2020-12-10 07:15:42 +01:00
2021-07-14 18:45:53 +05:30
2021-07-14 18:45:53 +05:30
2021-09-20 12:16:20 +02:00
2021-06-10 15:04:39 -04:00
2021-09-07 10:44:43 +02:00