cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-05 13:11:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Hennadii Stepanov 774a4f517c
Merge bitcoin-core/gui#403: refactor: Make paths to update Encryption and HD wallet statuses simpler 
b8aa84b1a116599a6dd3b9ddb4e6c178a6688b1b qt, refactor: Replace `if` check with `assert` (Hennadii Stepanov)
fcdc8b0fcb9dc81b76289abc57a4203671f748eb qt, refactor: Drop redundant signalling in WalletView::setWalletModel (Hennadii Stepanov)
37dcf161d3dd1f7862a67bec1e8f2887cbd6de90 qt, refactor: Emit WalletView::encryptionStatusChanged signal directly (Hennadii Stepanov)
7d0d4c04903cafade32be3bf2bf1cad3f33c6c03 qt: Add WalletFrame::currentWalletSet signal (Hennadii Stepanov)

Pull request description:

  This PR makes signal-slot paths to reach `setHDStatus` and `setEncryptionStatus` functions shorter and easier to reason about them.

  Required to simplify #398 (see https://github.com/bitcoin-core/gui/pull/398#discussion_r686094883).

  ---

  **Note for reviewers.** Please verify that "Encrypt Wallet..." menu item, and the following icons

  ![DeepinScreenshot_select-area_20210811202120](https://user-images.githubusercontent.com/32963518/129074601-13fa998a-ac47-4ad2-be00-ba400b12c18a.png)

  and updated properly in each and every possible scenario.

ACKs for top commit:
  jarolrod:
    tACK b8aa84b1a116599a6dd3b9ddb4e6c178a6688b1b
  Talkless:
    Code review ACK b8aa84b1a116599a6dd3b9ddb4e6c178a6688b1b. Did build on Debian Sid with Qt 5.15.2 but no actual testing performed.
  ryanofsky:
    Code review ACK b8aa84b1a116599a6dd3b9ddb4e6c178a6688b1b. Only change since last review was rebase

Tree-SHA512: 275737cdba02baff71049df41bc24089e916f96326dd2dea26ec607c7949cb3aae368eeabbe3ad5a0a27651503a1d65536873726de854c5f6af259bcc29727e7
2021-08-26 15:56:18 +03:00
..
bench
[addrman] Remove all public uses of CAddrMan.Clear() from the tests
2021-08-19 11:26:53 +01:00
compat
Remove support for double serialization
2021-05-24 16:15:05 -07:00
config
…
consensus
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
crc32c
…
crypto
[crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD
2021-06-23 09:46:38 -07:00
index
Merge bitcoin/bitcoin#22047: index, rpc: Coinstatsindex follow-ups
2021-07-28 15:19:34 +02:00
init
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
interfaces
Merge bitcoin/bitcoin#19101: refactor: remove ::vpwallets and related global variables
2021-08-19 09:42:21 +08:00
ipc
Add ipc::Context and ipc::capnp::Context structs
2021-06-10 09:58:45 -05:00
leveldb
…
logging
…
node
Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file
2021-08-19 10:44:25 +12:00
policy
MOVEONLY: context-free package policies
2021-06-02 17:26:44 +01:00
primitives
…
qt
Merge bitcoin-core/gui#403: refactor: Make paths to update Encryption and HD wallet statuses simpler
2021-08-26 15:56:18 +03:00
rpc
[addrman] Merge the two Add() functions
2021-08-15 22:35:13 -07:00
script
Merge bitcoin/bitcoin#22275: A few follow-ups for taproot signing
2021-08-23 12:25:49 +08:00
secp256k1
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
support
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
test
Merge bitcoin/bitcoin#22648: doc, test: improve i2p/tor docs and i2p reachable unit tests
2021-08-26 12:44:46 +02:00
univalue
…
util
Merge bitcoin/bitcoin#22772: refactor: hasher cleanup (follow-up to 19935)
2021-08-24 11:12:15 +08:00
wallet
Merge bitcoin/bitcoin#22713: Fix build with Boost 1.77.0
2021-08-26 16:20:52 +08:00
zmq
zmq: use msg: prefix over errno= in zmqError
2021-06-09 19:25:13 +08:00
.clang-format
[tools] Allow argument/parameter bin packing in clang-format
2021-02-18 10:07:37 +00:00
addrdb.cpp
[tests] Remove CAddrMan.Clear() call from CAddrDB::Read()
2021-08-18 14:00:52 +01:00
addrdb.h
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
addrman.cpp
[addrman] Clean up ctor
2021-08-19 11:29:54 +01:00
addrman.h
[addrman] Clean up ctor
2021-08-19 11:29:54 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
banman.h
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
base58.cpp
refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)
2021-01-31 17:35:16 +01:00
base58.h
…
bech32.cpp
naming nits
2021-03-17 17:59:22 -07:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-cli.cpp
Fix typo in bitcoin-cli.cpp
2021-08-24 07:44:09 +02:00
bitcoin-tx-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-tx.cpp
util: make ParseMoney return a std::optional<CAmount>
2021-08-04 19:48:24 +08:00
bitcoin-util-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-util.cpp
refactor: Pass grind args vector as const reference
2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-wallet.cpp
Remove unused OptionsCategory arg from AddCommand
2021-06-18 20:09:23 +02:00
bitcoind-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoind.cpp
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
doc: Various validation doc fixups
2021-06-03 13:53:31 +02:00
chainparams.cpp
test: Set regtest.BIP66Height = 102 to speed up tests
2021-08-05 12:08:33 +02:00
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
[p2p] remove unused segwitheight=-1 option
2021-07-07 22:13:01 -07:00
chainparamsbase.h
…
chainparamsseeds.h
contrib, p2p: update I2P hardcoded seeds
2021-07-30 11:03:44 +02:00
checkqueue.h
…
clientversion.cpp
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
clientversion.h
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
refactor: Use CPubKey vector constructor where possible
2021-05-04 06:53:32 +02:00
compressor.h
…
core_io.h
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
core_memusage.h
…
core_read.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
core_write.cpp
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
cuckoocache.h
…
dbwrapper.cpp
refactor: Use only one temporary buffer in CreateObfuscateKey
2021-05-04 06:53:37 +02:00
dbwrapper.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
tests: Skip SQLite fsyncs while testing
2021-04-12 19:29:03 -04:00
external_signer.cpp
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
log: Move "Pre-allocating up to position 0x[...] in [...].dat" log message to debug category
2021-02-10 20:46:25 +00:00
flatfile.h
…
fs.cpp
Fix build with Boost 1.77.0
2021-08-24 12:49:02 +02:00
fs.h
…
hash.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
hash.h
Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8
2021-04-23 11:35:15 -07:00
httprpc.cpp
Drop JSONRPCRequest constructors after #21366
2021-04-07 04:53:26 -04:00
httprpc.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
httpserver.cpp
refactor: Make httpserver work queue a unique_ptr
2021-06-28 11:47:05 +02:00
httpserver.h
…
i2p.cpp
net: do not connect to I2P hosts on port!=0
2021-07-09 11:19:37 +02:00
i2p.h
i2p: use pointers to Sock to accommodate mocking
2021-03-16 13:59:18 +01:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#22220: util: make ParseMoney return a std::optional<CAmount>
2021-08-24 10:43:38 +08:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
…
key.cpp
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
key.h
Improve comments in taproot signing logic
2021-08-20 14:29:23 -04:00
logging.cpp
log, refactor: use guard clause in LogCategoriesList()
2021-07-22 23:09:52 +02:00
logging.h
log: sort LogCategoriesList and LogCategoriesString alphabetically
2021-07-22 23:09:42 +02:00
Makefile.am
Merge bitcoin/bitcoin#22218: multiprocess: Add ipc::Context and ipc::capnp::Context structs
2021-07-22 08:26:30 +02:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
qt, refactor: Move InitExecutor class into its own module
2021-07-14 21:54:32 +03:00
Makefile.qttest.include
test: remove qt byteswap compattests
2021-03-29 11:12:26 +08:00
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
Makefile.test.include
Merge bitcoin/bitcoin#21882: build: Fix undefined reference to __mulodi4
2021-07-29 20:53:36 +08:00
mapport.cpp
refactor: Use appropriate thread constructor
2021-04-29 18:39:01 +03:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
util: make ParseMoney return a std::optional<CAmount>
2021-08-04 19:48:24 +08:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
Drop us=... message in net debug for sending version message
2021-08-21 19:16:47 -04:00
net_processing.h
Merge bitcoin/bitcoin#22577: Close minor startup race between main and scheduler threads
2021-08-04 16:37:12 +02:00
net_types.h
…
net.cpp
[addrman] Move peers.dat parsing to init.cpp
2021-08-18 14:00:52 +01:00
net.h
scripted-diff: replace clientInterface with m_client_interface in net
2021-08-18 13:54:43 +08:00
netaddress.cpp
Merge bitcoin/bitcoin#22179: Torv2 removal followups
2021-07-08 17:20:35 +02:00
netaddress.h
Fix whitespace in touched files
2021-07-30 11:24:59 +02:00
netbase.cpp
Merge #21387: p2p: Refactor sock to add I2P fuzz and unit tests
2021-03-30 17:41:13 +02:00
netbase.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
outputtype.h
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
protocol.h
doc: Remove incorrect INIT_PROTO_VERSION from nTime comment
2021-08-23 18:53:34 +02:00
psbt.cpp
Make GetInputUTXO safer: verify non-witness UTXO match
2021-06-12 12:25:28 -07:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
pubkey.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
random.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
random.h
…
randomenv.cpp
rand: only try and use freeifaddrs if available
2021-03-29 11:08:29 +08:00
randomenv.h
…
rest.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
reverse_iterator.h
…
scheduler.cpp
test: Fix off-by-one in mockscheduler test RPC
2021-05-14 12:49:16 +02:00
scheduler.h
…
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
shutdown.h
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
signet.cpp
Merge #21330: Deal with missing data in signature hashes more consistently
2021-04-13 10:24:31 +08:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
…
streams.h
streams: Accept URef obj for VectorReader unserialize
2021-05-05 20:19:03 +02:00
sync.cpp
…
sync.h
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
torcontrol: Resolve Tor control plane address
2021-06-27 19:27:25 +02:00
torcontrol.h
tests: Add fuzzing harness for TorController
2021-03-02 12:21:32 +00:00
txdb.cpp
doc: add comment about CCoinsViewDBCursor constructor
2021-06-18 14:15:39 -04:00
txdb.h
move-only(ish): don't expose CCoinsViewDBCursor
2021-06-18 14:14:15 -04:00
txmempool.cpp
[mempool] check ancestor/descendant limits for packages
2021-08-05 12:37:28 +01:00
txmempool.h
[mempool] check ancestor/descendant limits for packages
2021-08-05 12:37:28 +01:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
[net processing] Add Orphanage empty consistency check
2021-07-20 13:12:42 +01:00
txrequest.cpp
doc: Fix typos from codespell lint
2021-04-07 19:26:25 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
[policy] ancestor/descendant limits for packages
2021-08-06 10:04:59 +01:00
validation.h
misc package validation doc improvements
2021-08-05 12:37:28 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…