cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 19:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke baf9cedee8
Merge #18817: doc: Document differences in bitcoind and bitcoin-qt locale handling 
ca185cf5a14b16d61814d7172284bc8efcd28b69 doc: Document differences in bitcoind and bitcoin-qt locale handling (practicalswift)

Pull request description:

  Document differences in `bitcoind` and `bitcoin-qt` locale handling.

  Since this seems to be the root cause to the locale dependency issues we've seen over the years I thought it was worth documenting :)

  Note that 1.) `QLocale` (used by Qt), 2.) C locale (used by locale-sensitive C standard library functions/POSIX functions and some parts of the C++ standard library such as `std::to_string`) and 3.) C++ locale (used by the C++ input/output library) are three separate things. This comment is about the perhaps surprising interference with the C locale (2) that takes place as part of the Qt initialization.

ACKs for top commit:
  hebasto:
    re-ACK ca185cf5a14b16d61814d7172284bc8efcd28b69

Tree-SHA512: e51c32f3072c506b0029a001d8b108125e1acb4f2b6a48a6be721ddadda9da0ae77a9b39ff33f9d9eebabe2244c1db09e8502e3e7012d7a5d40d98e96da0dc44
2020-08-29 10:03:45 +02:00
..
bench
util: make EncodeBase58Check consume Spans
2020-08-12 16:25:50 +02:00
compat
net: Use C++11 member initialization in protocol
2020-05-20 08:27:07 -04:00
config
…
consensus
Add txids with non-standard inputs to reject filter
2020-08-04 13:29:40 -04:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
build: improve builtin_clz* detection
2020-06-29 11:31:17 +08:00
index
Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB
2020-08-21 12:48:46 +08:00
interfaces
Merge #19289: wallet: GetWalletTx and IsMine require cs_wallet lock
2020-08-27 16:21:37 +02:00
leveldb
…
logging
Remove use of non-standard zero variadic macros
2020-04-30 18:02:04 +08:00
node
Add support for tx-relay via wtxid
2020-07-19 02:05:29 -04:00
policy
Add txids with non-standard inputs to reject filter
2020-08-04 13:29:40 -04:00
primitives
refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic
2020-07-30 13:44:54 -07:00
qt
Merge #18817: doc: Document differences in bitcoind and bitcoin-qt locale handling
2020-08-29 10:03:45 +02:00
rpc
Merge #19607: [p2p] Add Peer struct for per-peer data in net processing
2020-08-28 20:29:16 +02:00
script
Merge #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071)
2020-08-25 20:18:40 +08:00
secp256k1
Update src/secp256k1 subtree
2020-06-09 13:39:09 -07:00
support
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
test
Merge #19607: [p2p] Add Peer struct for per-peer data in net processing
2020-08-28 20:29:16 +02:00
univalue
…
util
util: make EncodeBase64 consume Spans
2020-08-25 18:52:57 +02:00
wallet
Merge #19169: rpc: Validate provided keys for query_options parameter in listunspent
2020-08-27 20:17:25 +02:00
zmq
…
.clang-format
tools: clang-format 6 compatibility
2020-07-06 03:52:37 +02:00
addrdb.cpp
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
addrdb.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
banlist: log post-swept banlist size at startup
2020-07-08 21:44:45 +08:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
base58.h
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace usage of GetScriptForWitness with GetScriptForDestination
2020-08-14 08:44:42 +12:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: gArgs -> args
2020-08-24 07:52:17 +02:00
blockencodings.cpp
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
blockfilter.h
[indexes] Fix default [de]serialization of BlockFilter.
2020-05-26 17:27:15 -04:00
bloom.cpp
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
bloom.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Merge #19316: [net] Cleanup logic around connection types
2020-08-12 10:01:44 +08:00
chainparams.h
…
chainparamsbase.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
chainparamsbase.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
Drop unused GIT_COMMIT_DATE macro
2020-05-04 19:53:58 +03:00
clientversion.h
…
coins.cpp
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
coins.h
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
compat.h
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
refactor: Replace const char* to std::string
2020-05-22 01:40:31 +09:00
core_write.cpp
refactor: Make HexStr take a span
2020-08-06 19:41:43 +02:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
Drop unused CDBWrapper methods
2020-07-08 14:26:14 +03:00
dummywallet.cpp
wallet: try -avoidpartialspends mode and use its result if fees are below threshold
2020-08-06 10:07:00 +09:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Add missing includes to fix compile errors
2020-06-16 15:15:46 -04:00
fs.h
…
hash.cpp
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
hash.h
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
httprpc.cpp
Merge #18740: Remove g_rpc_node global
2020-05-21 06:53:39 -04:00
httprpc.h
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
httpserver.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #19779: Remove gArgs global from init
2020-08-26 15:18:38 +08:00
init.h
init: Pass reference to ArgsManager around instead of relying on global
2020-08-24 07:45:17 +02:00
key_io.cpp
…
key_io.h
…
key.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
key.h
…
limitedmap.h
…
logging.cpp
log: remove deprecated db log category
2020-06-07 17:03:49 +02:00
logging.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
Makefile.am
Move only: Move CDiskTxPos to its own file
2020-08-15 18:23:55 -04:00
Makefile.bench.include
Replace current benchmarking framework with nanobench
2020-06-13 12:24:18 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
scripted-diff: rename movie folder to animation
2020-06-29 18:49:13 +01:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
tests: Add fuzzing harness for CNode
2020-08-27 17:50:39 +00:00
memusage.h
…
merkleblock.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
merkleblock.h
…
miner.cpp
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
miner.h
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
net_permissions.cpp
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_permissions.h
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_processing.cpp
Merge #19607: [p2p] Add Peer struct for per-peer data in net processing
2020-08-28 20:29:16 +02:00
net_processing.h
Merge #19607: [p2p] Add Peer struct for per-peer data in net processing
2020-08-28 20:29:16 +02:00
net_types.h
…
net.cpp
net: add nLastBlockTime/TXTime to CNodeStats, CNode::copyStats
2020-08-15 12:03:16 +02:00
net.h
net: add nLastBlockTime/TXTime to CNodeStats, CNode::copyStats
2020-08-15 12:03:16 +02:00
netaddress.cpp
Merge #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes
2020-08-28 17:51:37 +02:00
netaddress.h
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.cpp
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.h
…
netmessagemaker.h
refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg
2020-05-11 00:20:57 +02:00
noui.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
noui.h
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
optional.h
…
outputtype.cpp
Enable Wswitch for OutputType
2020-07-01 18:03:12 -04:00
outputtype.h
Remove confusing OutputType::CHANGE_AUTO
2020-07-01 18:02:38 -04:00
pow.cpp
…
pow.h
…
prevector.h
prevector: Avoid unnamed struct, which is a GNU extension
2020-04-30 18:02:03 +08:00
protocol.cpp
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
protocol.h
Merge #19721: p2p: comment out unused MSG_FILTERED_WITNESS_BLOCK
2020-08-18 12:15:48 +08:00
psbt.cpp
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
psbt.h
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
pubkey.cpp
…
pubkey.h
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
Add templated GetRandomDuration<>
2020-04-30 09:19:14 -04:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
rpc: Avoid useless mempool query in gettxoutproof
2020-07-26 16:44:07 +02:00
reverse_iterator.h
…
scheduler.cpp
clang-format scheduler
2020-06-21 06:02:59 -04:00
scheduler.h
clang-format scheduler
2020-06-21 06:02:59 -04:00
serialize.h
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
shutdown.cpp
…
shutdown.h
…
span.h
Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2020-07-30 13:57:09 -07:00
streams.h
refactor: Drop unused CBufferedFile::Seek()
2020-07-26 22:46:28 +03:00
sync.cpp
test: Add LockStackEmpty()
2020-08-02 16:42:39 +03:00
sync.h
test: Add LockStackEmpty()
2020-08-02 16:42:39 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
2020-08-18 10:46:53 +03:00
timedata.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Replace hidden service with onion service
2020-08-07 14:55:02 +02:00
torcontrol.h
…
txdb.cpp
Merge #18637: coins: allow cache resize after init
2020-07-29 07:53:19 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
refactor: make txmempool interface use GenTxid
2020-07-30 13:45:03 -07:00
txmempool.h
refactor: make txmempool interface use GenTxid
2020-07-30 13:45:03 -07:00
uint256.cpp
refactor: Make HexStr take a span
2020-08-06 19:41:43 +02:00
uint256.h
Make uint256 Span-convertible by adding ::data()
2020-07-30 13:57:09 -07:00
undo.h
…
validation.cpp
Merge #19660: refactor: Make HexStr take a span
2020-08-09 15:35:58 +02:00
validation.h
Pass mempool pointer to GetCoinsCacheSizeState
2020-07-29 12:30:11 +02:00
validationinterface.cpp
trivial: Suggested cleanups to surrounding code
2020-05-22 16:30:07 -04:00
validationinterface.h
trivial: Suggested cleanups to surrounding code
2020-05-22 16:30:07 -04:00
version.h
Add p2p message "wtxidrelay"
2020-07-19 02:10:41 -04:00
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
warnings.cpp
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00
warnings.h
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00