Samuel Dobson 8af835a72d

Merge #16796: wallet: Fix segfault in CreateWalletFromFile ...

fa734603b78ba31ebf0da5d2dbe87386eafff01a wallet: Fix segmentation fault in CreateWalletFromFile (MarcoFalke)
fab3c34412379598b812631e3c123e9467cdc485 test: Print both messages on failure in assert_raises_message (MarcoFalke)
faa13539d5262bb7a512e9ff82e80083e04315ee wallet: Fix documentation around WalletParameterInteraction (MarcoFalke)

Pull request description:

  Comes with a test to aid review. The test should fail without the fix to bitcoind

  The following `CreateWalletFromFile` issues are fixed:

  * `walletFile` refers to freed memory and will thus corrupt the debug.log and/or crash the node if read
  * `WalletParameterInteraction` was moved to `CreateWalletFromFile` and `WalletInit::ParameterInteraction` without updating the documentation

ACKs for top commit:
  promag:
    ACK fa734603b78ba31ebf0da5d2dbe87386eafff01a.
  darosior:
    ACK fa734603b78ba31ebf0da5d2dbe87386eafff01a
  meshcollider:
    LGTM, code-read ACK fa734603b78ba31ebf0da5d2dbe87386eafff01a

Tree-SHA512: 2aceb63a3f25b90a840cfa08d37f5874aad4eb3df8c2ebf94e2ed18b55809b185e6920bdb345b988bff1fcea5e68a214fe06c361f7da2c01a3cc29e0cc421cb4

2019-09-09 23:34:05 +12:00

..

__init__.py

Rename rpc-tests directory to functional

2017-03-20 10:40:31 -04:00

address.py

test: Test p2sh-witness and bech32 in wallet_import_rescan

2019-08-14 17:20:07 -04:00

authproxy.py

test: Properly log named args in authproxy

2019-04-08 18:38:54 -04:00

bignum.py

Remove unused variables and/or function calls

2017-08-28 15:18:14 +02:00

blocktools.py

test: Properly serialize BIP34 coinbase height

2019-07-09 14:12:33 -04:00

coverage.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

descriptors.py

Descriptor checksum

2019-02-15 22:36:05 -08:00

key.py

Add comments to Python ECDSA implementation

2019-04-18 13:23:26 -07:00

messages.py

Avoid using mutable default parameter values

2019-08-26 10:45:25 +00:00

mininode.py

test: Fail early on disconnect in mininode.wait_for_*

2019-07-26 16:11:26 -04:00

netutil.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

script.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

segwit_addr.py

Use BIP173 addresses in segwit.py test

2017-09-28 17:29:01 -07:00

siphash.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

socks5.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

test_framework.py

test: Adapt test framework for chains other than "regtest"

2019-07-31 17:00:25 -04:00

test_node.py

test: Remove incorrect and unused try-block in assert_debug_log

2019-09-04 13:10:37 -04:00

util.py

test: Print both messages on failure in assert_raises_message

2019-09-03 14:10:58 -04:00

wallet_util.py

[tests] move wallet util functions to wallet_util.py

2019-01-04 17:49:17 -08:00