Andrew Chow 194710d8ff

Merge bitcoin/bitcoin#25481: wallet: unify max signature logic ...

d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9 wallet: use CCoinControl to estimate signature size (S3RK)
a94659c84ee10ac5915eb5a6b654435183d88521 wallet: replace GetTxSpendSize with CalculateMaximumSignedInputSize (S3RK)

Pull request description:

  Currently `DummySignTx` and `DummySignInput` use different ways to determine signature size.
  This PR unifies the way wallet estimates signature size for various inputs.
  Instead of passing boolean flags from calling code the `use_max_sig` is now calculated at the place of signature creation using information available in `CCoinControl`

ACKs for top commit:
  achow101:
    ACK d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9
  theStack:
    Code-review ACK d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9

Tree-SHA512: e790903ad4683067070aa7dbf7434a1bd142282a5bc425112e64d88d27559f1a2cd60c68d6022feaf6b845237035cb18ece10f6243d719ba28173b69bd99110a

2022-07-08 10:27:06 -04:00

..

rpc

Merge bitcoin/bitcoin#25337: refactor: encapsulate wallet's address book access

2022-07-08 10:16:08 -04:00

test

Merge bitcoin/bitcoin#25481: wallet: unify max signature logic

2022-07-08 10:27:06 -04:00

bdb.cpp

wallet: don't read db every time that a new WalletBatch is created

2022-06-16 12:18:58 -03:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

coinselection.cpp

Revert "bnb: exit selection when best_waste is 0"

2022-06-28 17:27:06 -04:00

coinselection.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

feebumper.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#25337: refactor: encapsulate wallet's address book access

2022-07-08 10:16:08 -04:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

receive.cpp

wallet: avoid extra IsSpentKey -> GetWalletTx lookups

2022-06-08 11:22:40 -03:00

receive.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

wallet: also search taproot pubkeys in FillPSBT

2022-06-27 16:47:48 -04:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

Merge bitcoin/bitcoin#25481: wallet: unify max signature logic

2022-07-08 10:27:06 -04:00

spend.h

wallet: use CCoinControl to estimate signature size

2022-06-28 08:54:39 +02:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

wallet: add GetWitnessHash()

2022-02-01 08:44:51 -03:00

wallet.cpp

Merge bitcoin/bitcoin#25481: wallet: unify max signature logic

2022-07-08 10:27:06 -04:00

wallet.h

Merge bitcoin/bitcoin#25481: wallet: unify max signature logic

2022-07-08 10:27:06 -04:00

walletdb.cpp

Merge bitcoin/bitcoin#25383: wallet: don't read db every time that a new 'WalletBatch' is created

2022-06-30 18:38:20 +02:00

walletdb.h

walletdb: Create a mock database of specific type

2022-05-10 11:54:02 -04:00

wallettool.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00