cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-13 17:08:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
fanquake 94d6a18f23
Merge #16507: feefilter: Compute the absolute fee rather than stored rate 
eb7b78165966f2c79da71b993c4c4d793e37297f modify p2p_feefilter test to catch rounding error (Gregory Sanders)
6a51f7951716d6d6fc0f9b56028f3a0dd02b61c8 Disallow implicit conversion for CFeeRate constructor (Gregory Sanders)
8e59af55aaf1b196575084bce2448af02d97d745 feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic (Gregory Sanders)

Pull request description:

  This means we will use the rounding-down behavior in `GetFee` to match both mempool acceptance and wallet logic, with minimal changes.

  Fixes https://github.com/bitcoin/bitcoin/issues/16499

  Replacement PR for https://github.com/bitcoin/bitcoin/pull/16500

ACKs for top commit:
  ajtowns:
    ACK eb7b78165966f2c79da71b993c4c4d793e37297f code review only
  naumenkogs:
    utACK eb7b78165966f2c79da71b993c4c4d793e37297f
  achow101:
    re ACK eb7b78165966f2c79da71b993c4c4d793e37297f
  promag:
    ACK eb7b78165966f2c79da71b993c4c4d793e37297f.

Tree-SHA512: 484a11c8f0e825f0c983b1f7e71cf6252b1bba6858194abfe4c088da3bae8a418ec539ef6c4181bf30940e277a95c08d493595d59dfcc6ddf77c65b05563dd7e
2019-10-04 13:46:45 -04:00
..
bench
scripted-diff: Use ArgsManager::DEBUG_ONLY flag
2019-07-27 15:05:14 +03:00
compat
add stdin helpers for password input support
2019-10-01 12:19:31 +09:00
config
…
consensus
Merge #16713: Ignore old versionbit activations to avoid 'unknown softforks' warning
2019-09-27 15:25:53 -04:00
crypto
Add ChaCha20Poly1305@Bitcoin AEAD implementation
2019-06-25 15:13:02 +02:00
index
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
interfaces
Revert "gui: Generate bech32 addresses by default (take 2, fixup)"
2019-09-26 16:23:32 -04:00
leveldb
Pull leveldb subtree
2019-01-26 12:45:48 -05:00
node
move-only: move coins statistics utils out of RPC
2019-08-27 11:51:56 -04:00
policy
Disallow implicit conversion for CFeeRate constructor
2019-10-03 14:03:27 -04:00
primitives
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
qt
Merge #17031: gui: Prevent processing duplicate payment requests
2019-10-04 06:19:08 -04:00
rpc
Merge #16908: txmempool: Make entry time type-safe (std::chrono)
2019-10-02 16:55:36 +02:00
script
Merge #13266: refactor: privatize SignatureExtractorChecker [moveonly]
2019-10-02 13:25:48 +02:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
Improve documentation of memory_cleanse()
2019-07-01 12:59:44 +02:00
test
Merge #16931: test: add unittests for CheckProofOfWork
2019-09-30 11:42:47 +02:00
univalue
Update univalue subtree
2018-09-07 08:21:14 -04:00
util
Don't rename main thread at process level
2019-10-03 06:58:47 +02:00
wallet
Disallow implicit conversion for CFeeRate constructor
2019-10-03 14:03:27 -04:00
zmq
rpc: switch to using RPCHelpMan.Check()
2019-07-08 09:53:52 +09:00
.clang-format
Fix inconsistent namespace formatting guidelines
2018-04-13 15:37:20 -04:00
addrdb.cpp
addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
2019-06-14 08:30:43 +02:00
addrdb.h
banman: Add, use CBanEntry ctor that takes ban reason
2019-01-16 13:54:18 -05:00
addrman.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
addrman.h
[addrman] Ensure collisions eventually get resolved
2019-02-27 16:53:44 -05:00
amount.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
arith_uint256.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
arith_uint256.h
Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1
2018-12-04 19:55:04 +02:00
attributes.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
banman.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
banman.h
Allow connections from misbehavior banned peers.
2019-01-22 21:10:48 +00:00
base58.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
base58.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
bech32.cpp
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
add newline after -stdin*
2019-10-01 12:19:31 +09:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
bitcoin-wallet-res.rc
[tools] Add wallet inspection and modification tool
2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp
bitcoin-wallet: Add a missing closing parenthesis in the help
2019-09-13 16:59:06 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Don't rename main thread at process level
2019-10-03 06:58:47 +02:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
disallow oversized CBlockHeaderAndShortTxIDs
2018-11-13 12:41:41 -08:00
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
refactor: Improve CRollingBloomFilter::reset by using std::fill
2019-05-22 15:55:50 +01:00
bloom.h
Removes unsed CBloomFilter constructor.
2018-08-13 01:24:55 +02:00
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
[doc] chain: Declare BLOCK_VALID_HEADER reserved
2019-08-05 07:58:58 -04:00
chainparams.cpp
chainparams: Bump assumed chain params
2019-10-01 07:33:24 -04:00
chainparams.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsbase.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
chainparamsbase.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsseeds.h
contrib: Remove invalid nodes from seeds list
2019-10-02 08:51:12 +02:00
checkqueue.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
clientversion.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
clientversion.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
coins.cpp
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
coins.h
make SaltedOutpointHasher noexcept
2019-09-25 20:56:38 +02:00
compat.h
windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2019-01-23 16:28:27 +08:00
compressor.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
compressor.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
core_read.cpp
Include core_io.h from core_read.cpp
2019-06-06 08:00:33 +02:00
core_write.cpp
Don't show addresses or P2PK in decoderawtransaction
2019-08-30 11:29:21 +09:00
cuckoocache.h
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-08-27 18:19:33 +02:00
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
dummywallet.cpp
Expose wallet creation to the GUI via WalletController
2019-09-05 20:36:57 -04:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
Style cleanup.
2019-02-22 17:38:45 -08:00
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
httprpc.h
Cleanup StartRest()
2018-08-11 09:34:47 +03:00
httpserver.cpp
Remove global symbols: Avoid using the global namespace if possible
2019-05-25 23:23:11 +02:00
httpserver.h
[build] Add several util units
2019-04-09 17:53:08 -04:00
indirectmap.h
…
init.cpp
doc: Remove mention of renamed mapBlocksUnlinked
2019-09-30 14:34:25 -04:00
init.h
Pass chain and client variables where needed
2018-11-06 11:44:40 -04:00
key_io.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
key_io.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
key.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
key.h
CKey: add method to negate the key
2019-03-27 13:59:50 +01:00
limitedmap.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
logging.cpp
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
logging.h
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
Makefile.am
add stdin helpers for password input support
2019-10-01 12:19:31 +09:00
Makefile.bench.include
Merge #15649: Add ChaCha20Poly1305@Bitcoin AEAD
2019-07-11 22:00:16 +02:00
Makefile.leveldb.include
build: Remove WINVER pre define in Makefile.leveldb.inlcude
2019-01-26 09:28:48 +08:00
Makefile.qt_locale.include
qt: Periodic translations update
2019-09-30 09:41:11 +02:00
Makefile.qt.include
build: Factor out qt translations from build system
2019-09-29 14:24:54 +02:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
Move ismine to wallet module
2019-06-19 18:06:30 -04:00
memusage.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
merkleblock.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
merkleblock.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
miner.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
miner.h
[rpc] mining: Omit uninitialized currentblockweight, currentblocktx
2019-02-12 11:34:57 -05:00
net_permissions.cpp
util: Move ResolveErrMsg to util/error
2019-08-15 10:05:32 -04:00
net_permissions.h
Make whitebind/whitelist permissions more flexible
2019-08-11 11:33:27 +09:00
net_processing.cpp
feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic
2019-10-03 14:03:27 -04:00
net_processing.h
refactor : use RelayTransaction in BroadcastTransaction utility
2019-07-24 19:47:56 -04:00
net.cpp
Merge #15558: Don't query all DNS seeds at once
2019-09-23 12:53:50 +08:00
net.h
txmempool: Make entry time type-safe (std::chrono)
2019-09-23 08:00:14 -04:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
netaddress: Update CNetAddr for ORCHIDv2
2019-05-15 14:21:48 -04:00
netbase.cpp
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netbase.h
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netmessagemaker.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
noui.cpp
Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors
2019-08-01 15:17:10 +02:00
noui.h
Suppress output in test_bitcoin for expected errors
2019-07-03 14:03:21 +02:00
optional.h
Remove 'boost::optional'-related gcc warnings
2019-01-30 22:44:28 +02:00
outputtype.cpp
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
outputtype.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pow.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pow.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
prevector.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
protocol.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
protocol.h
Remove unused bits from the service flags enum
2019-07-12 14:14:54 -04:00
psbt.cpp
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00
psbt.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pubkey.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pubkey.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
random.cpp
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
random.h
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
rest.cpp
refactor: pcoinsTip -> CChainState::CoinsTip()
2019-08-06 13:13:06 -04:00
reverse_iterator.h
scripted-diff: Remove trailing whitespaces
2018-07-24 20:46:23 +01:00
reverselock.h
…
scheduler.cpp
Switch all RNG code to the built-in PRNG.
2019-01-16 16:34:56 -08:00
scheduler.h
trivial: correct parameter name in comments
2019-02-10 17:17:32 -05:00
serialize.h
Support serialization of std::vector<bool>
2019-08-26 11:36:33 -07:00
shutdown.cpp
Break circular dependency: init -> * -> init by extracting shutdown.h
2018-06-25 00:08:49 -04:00
shutdown.h
Break circular dependency: init -> * -> init by extracting shutdown.h
2018-06-25 00:08:49 -04:00
span.h
Add more methods to Span class
2018-07-27 11:52:18 -07:00
streams.h
util: CBufferedFile fixes
2019-09-10 07:53:09 -06:00
sync.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
sync.h
scripted-diff: Rename LockAnnotation to LockAssertion
2019-05-17 13:29:04 +02:00
threadinterrupt.cpp
Merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection
2018-08-31 16:00:38 +02:00
threadinterrupt.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
threadsafety.h
Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
2019-05-17 13:29:04 +02:00
timedata.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
timedata.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
fix: tor: Call event_base_loopbreak from the event's callback
2019-07-17 15:32:38 +01:00
torcontrol.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
txdb.cpp
refactor: have CCoins* data managed under CChainState
2019-08-15 11:04:10 -04:00
txdb.h
refactor: have CCoins* data managed under CChainState
2019-08-15 11:04:10 -04:00
txmempool.cpp
feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic
2019-10-03 14:03:27 -04:00
txmempool.h
feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic
2019-10-03 14:03:27 -04:00
ui_interface.cpp
Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit
2019-06-18 15:59:53 -04:00
ui_interface.h
Add MSG_NOPREFIX flag for user messages
2019-06-19 19:22:34 +03:00
uint256.cpp
Merge #14734: fix an undefined behavior in uint::SetHex
2019-07-03 14:18:29 +02:00
uint256.h
uint256: Remove unnecessary crypto/common.h use
2018-09-18 14:27:05 +09:00
undo.h
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
validation.cpp
Merge #16908: txmempool: Make entry time type-safe (std::chrono)
2019-10-02 16:55:36 +02:00
validation.h
validation: Make GetWitnessCommitmentIndex public
2019-09-24 11:16:05 -04:00
validationinterface.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
validationinterface.h
Remove extra CBlockIndex declaration
2019-06-25 15:02:34 -04:00
version.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
versionbits.cpp
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbits.h
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbitsinfo.cpp
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
versionbitsinfo.h
MOVEONLY: Move versionbits info out of versionbits.o
2018-09-23 22:55:11 +02:00
walletinitinterface.h
refactor: Cleanup walletinitinterface.h
2019-09-08 17:29:30 +03:00
warnings.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
warnings.h
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00