MarcoFalke 100fa0a62a

Merge #17300: LegacyScriptPubKeyMan code cleanups ...

53fe0b70adeffe4cb94e6fa18a9abbdf674a2cd0 Fix missing strFailReason in CreateTransaction (Russell Yanofsky)
4b28a05f080de8acefaaa74f1204829995611d9e Fix misplaced AssertLockHeld (Russell Yanofsky)
2632b1f12466f970b667b42f462a6503df88e128 doc: Clarify WalletStorage / Wallet relation (Russell Yanofsky)
628d11b2ba0f1ba715c2358373e603a56d9f69ff Add back mistakenly removed AssertLockHeld (Russell Yanofsky)
52cf68f7ffa1dd3a6850606a75c32b77b1308c4b Refactor: Add GetLegacyScriptPubKeyMan helper (Russell Yanofsky)

Pull request description:

  This PR implements suggested code cleanups from https://github.com/bitcoin/bitcoin/pull/17260 review comments

ACKs for top commit:
  Sjors:
    ACK 53fe0b70adeffe4cb94e6fa18a9abbdf674a2cd0
  achow101:
    ACK 53fe0b70adeffe4cb94e6fa18a9abbdf674a2cd0
  MarcoFalke:
    ACK 53fe0b70adeffe4cb94e6fa18a9abbdf674a2cd0

Tree-SHA512: a577b96cb21a9aa7185d7d900e4db0665c302adcd12097957b9d8e838a8548c7de8f901bcb83e7c46d231b841221345c9264f5e29ed069f3d9236896430f959b

2019-10-31 14:40:39 -04:00

..

test

Merge #16839: Replace Connman and BanMan globals with NodeContext local

2019-10-30 12:35:41 +01:00

coincontrol.cpp

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coincontrol.h

refactor: Replace all uses of boost::optional with our own Optional type

2019-10-30 14:27:31 +01:00

coinselection.cpp

refactor: Replace all uses of boost::optional with our own Optional type

2019-10-30 14:27:31 +01:00

coinselection.h

…

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

Remove unused includes

2019-10-15 22:56:43 +00:00

db.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

db.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

feebumper.cpp

[wallet] Remove state argument from CWallet::CommitTransaction

2019-10-18 09:43:01 -04:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

…

init.cpp

Pass NodeContext, ConnMan, BanMan references more places

2019-10-28 10:30:51 -04:00

ismine.h

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

load.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

psbtwallet.cpp

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

psbtwallet.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcdump.cpp

Refactor: Add GetLegacyScriptPubKeyMan helper

2019-10-29 12:20:19 -04:00

rpcwallet.cpp

Merge #16839: Replace Connman and BanMan globals with NodeContext local

2019-10-30 12:35:41 +01:00

rpcwallet.h

Avoid using g_rpc_node global in wallet code

2019-10-28 10:30:51 -04:00

scriptpubkeyman.cpp

Add back mistakenly removed AssertLockHeld

2019-10-29 12:21:57 -04:00

scriptpubkeyman.h

doc: Clarify WalletStorage / Wallet relation

2019-10-29 12:23:47 -04:00

wallet.cpp

Fix missing strFailReason in CreateTransaction

2019-10-29 12:25:28 -04:00

wallet.h

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

walletdb.cpp

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

walletdb.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

wallettool.cpp

Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan

2019-10-29 08:19:23 -04:00

wallettool.h

Remove unused includes

2019-10-15 22:56:43 +00:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

Move wallet enums to walletutil.h

2019-10-25 19:20:24 -04:00