Ryan Ofsky 39950e148d

Merge bitcoin/bitcoin#31295: refactor: Prepare compile-time check of bilingual format strings ...

fa3e074304780549b1e7972217930e34fa55f59a refactor: Tidy fixups (MarcoFalke)
fa72646f2b197810a324cb0544d9a1fac37d3f9c move-only: Detail_CheckNumFormatSpecifiers and G_TRANSLATION_FUN (MarcoFalke)
faff8403f0aac3b5ec26d3c7fc98240f879f9906 refactor: Pick translated string after format (MarcoFalke)

Pull request description:

  The changes are required for https://github.com/bitcoin/bitcoin/pull/31061, however they also make sense on their own. For example, they are fixing up an `inline namespace`, which lead to compile errors otherwise (can be tested by observing the compile error after reverting the changes to `src/util/strencodings.h`). Also, a unit test comment is fixed.

ACKs for top commit:
  ryanofsky:
    Code review ACK fa3e074304780549b1e7972217930e34fa55f59a. Nice changes! These should allow related PRs to be simpler.
  l0rinc:
    ACK fa3e074304780549b1e7972217930e34fa55f59a
  hodlinator:
    cr-ACK fa3e074304780549b1e7972217930e34fa55f59a

Tree-SHA512: 37371181a348610442186b5fbb7a6032d0caf70aae566002ad60be329a3131a2b89f28f6c51e10872079f987986925dc8c0611bde639057bee4f572d2b9ba92a

2024-12-04 11:15:58 -05:00

..

rpc

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

test

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

bdb.cpp

scripted-diff: LogPrint -> LogDebug

2024-08-29 13:49:57 +02:00

bdb.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

CMakeLists.txt

cmake: Add systemtap-sdt optional package support

2024-08-16 19:27:41 +01:00

coincontrol.cpp

…

coincontrol.h

[wallet, rpc]: add max_tx_weight to tx funding options

2024-06-27 15:31:21 +01:00

coinselection.cpp

scripted-diff: LogPrint -> LogDebug

2024-08-29 13:49:57 +02:00

coinselection.h

Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2)

2024-07-17 18:27:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

crypter.h

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

db.cpp

Merge bitcoin/bitcoin#29071: refactor: Remove Span operator==, Use std::ranges::equal

2024-08-28 10:34:47 +01:00

db.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

dump.cpp

bdb: Be able to make byteswapped databases

2024-05-16 15:03:13 -04:00

dump.h

…

external_signer_scriptpubkeyman.cpp

util: add TransactionError includes and namespace declarations

2024-05-16 10:16:08 -05:00

external_signer_scriptpubkeyman.h

common: Add PSBTError enum

2024-05-16 10:16:08 -05:00

feebumper.cpp

refactor: Tidy fixups

2024-11-15 17:16:54 +01:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

interfaces.cpp

gui: Use wallet name for wallet migration rather than WalletModel

2024-08-13 11:25:38 -04:00

load.cpp

Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups

2024-09-20 13:26:38 -04:00

load.h

…

migrate.cpp

refactor: Add explicit cast to expected_last_page to silence fuzz ISan

2024-06-07 17:30:38 +02:00

migrate.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

receive.cpp

…

receive.h

…

salvage.cpp

refactor: Tidy fixups

2024-11-15 17:16:54 +01:00

salvage.h

…

scriptpubkeyman.cpp

wallet: provide WalletBatch to 'DeleteRecords'

2024-10-21 08:29:22 -03:00

scriptpubkeyman.h

wallet: provide WalletBatch to 'DeleteRecords'

2024-10-21 08:29:22 -03:00

spend.cpp

tracing: only prepare tracepoint args if attached

2024-10-28 14:27:47 +01:00

spend.h

…

sqlite.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

sqlite.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

transaction.cpp

…

transaction.h

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

types.h

util: move error.h TransactionError enum to node/types.h

2024-05-16 10:16:08 -05:00

wallet.cpp

refactor: Tidy fixups

2024-11-15 17:16:54 +01:00

wallet.h

wallet: migration, consolidate main wallet db writes

2024-10-21 08:29:23 -03:00

walletdb.cpp

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

walletdb.h

wallet: introduce active db txn listeners

2024-10-21 08:29:22 -03:00

wallettool.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

wallettool.h

…

walletutil.cpp

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

walletutil.h

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00