cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-10 23:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/test/fuzz
History
laanwj 7008087548
Merge bitcoin/bitcoin#24410: [kernel 2a/n] Split hashing/index GetUTXOStats codepaths, decouple from coinstatsindex 
664a14ba7ccb40aa82d35a59831acd35db1897a6 coinstats: Move GetUTXOStats to rpc/blockchain (Carl Dong)
f1006875665ffe8ff5da8185effe25b860743b4e kernel: Use ComputeUTXOStats in validation (Carl Dong)
faa52387e8e4856445b1cfc9b5e072ce8f690f36 style-only: Rearrange using decls after scripted-diff (Carl Dong)
f329a9298c06ffe74b9e9fbc07bfe6d282fef9cb scripted-diff: Move src/kernel/coinstats to kernel:: (Carl Dong)
0e54456f0498e52131f8ae0c76b4dfe25f45b076 Use only kernel/coinstats.h in index/coinstatsindex.h (Carl Dong)
80970985c965f79b8c376c8a922497e385445dd8 coinstats: Split node/coinstats.h to kernel/coinstats.h (Carl Dong)
35f73ce4b2efd7341fe55f77b334f27ad8aad090 coinstats: Move hasher codepath to kernel/coinstats (Carl Dong)
b7634fe02b6b030f5d62502c73db84ba9a276640 Move logic from LookupUTXOStatsWithIndex to CoinStatsIndex::LookUpStats (Carl Dong)
1352e410a5b84070279ff28399083cb3ab278593 coinstats: Separate hasher/index lookup codepaths (Carl Dong)
524463daf6a10b20a4e20116a68101a684929eda coinstats: Return purely out-param CCoinsStats (Carl Dong)
46eb9fc56a296a2acea10ec7e5bf7b1827f73c45 coinstats: Extract index_requested in-member to in-param (Carl Dong)
a789f3f2b878e1236f8e043a8bb1ffb1afc1b673 coinstats: Extract hash_type in-member to in-param (Carl Dong)
102294898d708b7adc0150aba8e500a4aa19bc1c includes: Remove rpc/util.h -> node/coinstats.h (Carl Dong)
0848db9c35d9eae4d68cbdbef68c337656f3c906 fuzz: Remove useless GetUTXOStats fuzz case (Carl Dong)
52b1939993771d0a8a718ca1667241872de8241a kernel: Remove unnecessary blockfilter{index,}.cpp (Carl Dong)

Pull request description:

  Part of: #24303
  Depends on: #24322

  The `GetUTXOStats` function has 2 codepaths:
    - One which queries the `CoinStatsIndex` for the UTXO hash
    - One which actually performs the hashing

  For `libbitcoinkernel`, the only place where we call `GetUTXOStats` is in `PopulateAndValidateSnapshots`, which uses the `SHA256D` hash, and is therefore unable to use the `CoinStatsIndex` since that only provides `MuHash` hashes. Not that I think indices necessarily belong in `libbitcoinkernel` anyway.

  This PR separates these 2 aforementioned codepaths of `GetUTXOStats`, uses the hashing codepath in `PopulateAndValidateSnapshots`, and removes the need to link in `index/coinstatsindex.cpp` and `node/coinstats.cpp`.

  -----

  Logistically, this PR:
  - Extracts out the `index_requested` and `hash_type` members of `CoinStats`, which served as "in-params" to `GetUTXOStats` embedded within the `CoinStats` struct. This allows `CoinStats` to only consist of "out-param" members, and be returned by `GetUTXOStats` without needing to be an "in-out" param
  - Introduce the purely virtual `UTXOHashers` class, with 3 implementations: `SHA256DHasher`, `MuHashHasher`, and `NullHasher`. These replace the existing template-based polymorphism.
  - Split `GetUTXOStats` into:
      - `CalculateUTXOStatsWithHasher(UTXOHasher&, ...)`, and
      - `LookupUTXOStatsWithIndex(CoinStatsIndex&, ...)`
  - Use `CalculateUTXOStatsWithHasher` directly where appropriate (`src/validation.cpp` and `src/fuzz`)
  - Move `GetUTXOStats` to `rpc/blockchain`, which is the only place that depends on `GetUTXOStats`'s weird fallback behaviour
  - Move `LookupUTXOStatsWithIndex` to `index/coinstatsindex`

  Code organization:
  - `src/`
    - `kernel/` → only contains the hashing codepath
      - `coinstats.cpp` → hashing codepath implementations
      - `coinstats.h` → header for `kernel/coinstats.cpp`
    - `index/` → only contains the index codepath
      - `coinstatsindex.cpp` → index codepath implementations
      - `coinstatsindex.h`
    - `validation.cpp` → only uses the hashing codepath
    - `rpc/blockchain.cpp` → uses both the hashing and index codepath, old `GetUTXOStats` fallback logic moved here as static
    - `test/fuzz/coins_view.cpp` → only uses the hashing codepath

  TODOs:
  - [x] Commit messages could be fleshed out more

  Would love any feedback!

ACKs for top commit:
  laanwj:
    Code review ACK 664a14ba7ccb40aa82d35a59831acd35db1897a6

Tree-SHA512: 18722c7bd279174d2d1881fec33ea04a9b261aae1c12e998cf434ef297d8ded47de69c526c8033a2ba7abc93ba3d2ff5faf4ce05e8888c725c31cf885ce3ef73
2022-05-24 14:43:00 +02:00
..
addition_overflow.cpp
util: Add SaturatingAdd helper
2022-02-21 14:32:53 +01:00
addrman.cpp
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
asmap_direct.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
asmap.cpp
[netgroupman] Add GetMappedAS() and GetGroup()
2022-04-20 14:35:52 +01:00
autofile.cpp
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
banman.cpp
scripted-diff: Use clang-tidy syntax for C++ named arguments
2021-11-19 12:41:47 +01:00
base_encode_decode.cpp
Use std::string_view throughout util strencodings/string
2022-04-27 14:13:39 +02:00
bech32.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
block_header.cpp
…
block.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
blockfilter.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bloom_filter.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
buffered_file.cpp
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
chain.cpp
Require CBlockIndex::RaiseValidity() to hold cs_main
2022-01-25 20:43:28 +01:00
checkqueue.cpp
test, bench: make prevector and checkqueue swap member functions noexcept
2022-04-28 20:34:43 +02:00
coins_view.cpp
fuzz: Remove useless GetUTXOStats fuzz case
2022-05-20 16:33:24 -04:00
connman.cpp
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
crypto_aes256.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
crypto_aes256cbc.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
crypto_chacha20_poly1305_aead.cpp
Move AdditionOverflow to util, Add CheckedAdd with unit tests
2021-12-17 10:46:39 +01:00
crypto_chacha20.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
crypto_common.cpp
…
crypto_diff_fuzz_chacha20.cpp
Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)
2022-04-26 10:41:45 +01:00
crypto_hkdf_hmac_sha256_l32.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
crypto_poly1305.cpp
…
crypto.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
cuckoocache.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
decode_tx.cpp
…
descriptor_parse.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deserialize.cpp
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
eval_script.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
fee_rate.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
fees.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
flatfile.cpp
…
float.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
fuzz.cpp
Remove unused GetTimeSeconds
2022-05-11 16:39:23 +02:00
fuzz.h
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
FuzzedDataProvider.h
…
golomb_rice.cpp
scripted-diff: rename MapIntoRange to FastRange64
2022-01-06 11:29:55 -05:00
hex.cpp
util: Add ParseHex<std::byte>() helper
2022-04-27 19:53:17 +02:00
http_request.cpp
Use std::string_view throughout util strencodings/string
2022-04-27 14:13:39 +02:00
i2p.cpp
…
integer.cpp
Merge bitcoin/bitcoin#23438: refactor: Use spans of std::byte in serialize
2022-01-27 19:19:12 +01:00
key_io.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
kitchen_sink.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
load_external_block_file.cpp
refactor: Remove chainparams arg from CChainState member functions
2021-06-13 09:43:54 +02:00
locale.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
merkleblock.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
message.cpp
…
miniscript_decode.cpp
fuzz: add a fuzz target for Miniscript decoding from Script
2022-03-17 14:09:09 +01:00
minisketch.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
muhash.cpp
fuzz: Cleanup muhash fuzz target
2021-09-22 10:39:08 +02:00
multiplication_overflow.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net.cpp
[net processing] Move tx relay data to Peer
2022-03-18 11:35:56 +00:00
netaddress.cpp
net: remove unused CNetAddr::GetHash()
2022-02-11 15:21:52 +01:00
netbase_dns_lookup.cpp
p2p, refactor: drop unused DNSLookupFn param in LookupSubnet()
2021-12-07 13:13:18 +01:00
node_eviction.cpp
scripted-diff: rename TxRelay members
2022-03-18 11:35:58 +00:00
p2p_transport_serialization.cpp
scripted-diff: Rename CNetMessage::m_command with CNetMessage::m_type
2022-01-15 20:59:19 +02:00
parse_hd_keypath.cpp
…
parse_iso8601.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
parse_numbers.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
parse_script.cpp
…
parse_univalue.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
policy_estimator_io.cpp
…
policy_estimator.cpp
scripted-diff: Use clang-tidy syntax for C++ named arguments
2021-11-19 12:41:47 +01:00
pow.cpp
Move AdditionOverflow to util, Add CheckedAdd with unit tests
2021-12-17 10:46:39 +01:00
prevector.cpp
test, bench: make prevector and checkqueue swap member functions noexcept
2022-04-28 20:34:43 +02:00
primitives_transaction.cpp
…
process_message.cpp
refactor: Set fSuccessfullyConnected in FillNode
2021-12-01 12:15:01 +01:00
process_messages.cpp
refactor: Set fSuccessfullyConnected in FillNode
2021-12-01 12:15:01 +01:00
protocol.cpp
…
psbt.cpp
Make DecodeBase{32,64} always return vector, not string
2022-04-27 14:12:55 +02:00
random.cpp
…
rbf.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rolling_bloom_filter.cpp
scripted-diff: Move bloom to src/common
2021-10-05 11:10:37 +02:00
rpc.cpp
Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC
2022-01-28 08:46:03 +01:00
script_assets_test_minimizer.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
script_bitcoin_consensus.cpp
…
script_descriptor_cache.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
script_flags.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
script_format.cpp
refactor: merge ScriptPubKeyToUniv & ScriptToUniv into one function
2022-03-30 20:00:23 +01:00
script_interpreter.cpp
…
script_ops.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
script_sigcache.cpp
…
script_sign.cpp
refactor: Change * to & in MutableTransactionSignatureCreator
2022-05-04 11:49:29 +02:00
script.cpp
fuzz: Split script formatting from script fuzz target
2022-02-15 12:19:34 +01:00
scriptnum_ops.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
secp256k1_ec_seckey_import_export_der.cpp
…
secp256k1_ecdsa_signature_parse_der_lax.cpp
…
signature_checker.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
signet.cpp
…
socks5.cpp
…
span.cpp
…
spanparsing.cpp
…
string.cpp
fuzz: SplitString with multiple separators
2022-05-04 07:34:48 +02:00
strprintf.cpp
…
system.cpp
fuzz: Fix memory leak in system fuzz target
2021-09-29 13:24:14 +02:00
timedata.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
torcontrol.cpp
fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop
2021-11-12 19:51:55 +00:00
transaction.cpp
refactor: use named args when ScriptToUniv or TxToUniv are invoked
2022-03-30 20:00:27 +01:00
tx_in.cpp
…
tx_out.cpp
…
tx_pool.cpp
Do not pass CChainParams& to BlockAssembler constructor
2022-05-18 18:46:07 +02:00
txrequest.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
util.cpp
net: add new method Sock::SetSockOpt() that wraps setsockopt()
2022-04-15 09:14:49 +02:00
util.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
utxo_snapshot.cpp
validation: remove redundant CChainParams params from ChainstateManager methods
2022-05-10 12:09:33 +10:00
validation_load_mempool.cpp
fuzz: Initialize a TestingSetup for test_one_input
2021-06-10 15:04:39 -04:00
versionbits.cpp
rpc: getdeploymentinfo: include signalling info
2022-01-15 04:37:56 +10:00