fanquake 820129aee9

Merge bitcoin/bitcoin#22686: wallet: Use GetSelectionAmount in ApproximateBestSubset ...

92885c4f69a5e6fc4989677d6e5be8a666fbff0d test: Test for ApproximateBestSubset edge case with too little fees (Andrew Chow)
d9262324e80da32725e21d4e0fbfee56f25490b1 wallet: Assert that enough was selected to cover the fees (Andrew Chow)
2de222c40198d3d528668d78cc52e2ce3fa96765 wallet: Use GetSelectionAmount for target value calculations (Andrew Chow)

Pull request description:

  The `m_value` used for the target calculation in `ApproximateBestSubset` is incorrect, it should be `GetSelectionAmount`. This causes a bug that is only apparent when the minimum relay fee is set to be very high.

  A test case is added for this, in addition to an assert in `CreateTransactionInternal` that would have also caught this issue if someone were able to hit the edge case.

  Fixes #22670

ACKs for top commit:
  instagibbs:
    utACK 92885c4f69

Tree-SHA512: bd61fa61ffb60873e097737eebea3afe8a42296ba429de9038b3a4706763b34de9409de6cdbab21ff7f51f4787b503f840873182d9c4a1d6e12a54b017953547

2021-08-16 11:23:53 +08:00

..

test

Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors

2021-08-09 14:45:12 +12:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

…

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

wallet: Use GetSelectionAmount for target value calculations

2021-08-13 00:34:02 -04:00

coinselection.h

Have OutputGroup determine the value to use

2021-05-19 15:35:11 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

…

db.cpp

Merge bitcoin/bitcoin#21944: wallet: Fix issues when walletdir is root directory

2021-06-09 22:53:36 +12:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

Replace size/weight estimate tuple with struct for named fields

2021-05-26 07:33:09 +08:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100

2021-05-26 19:32:51 +08:00

interfaces.cpp

Use bilingual_str for address fetching functions

2021-07-01 12:57:51 -04:00

ismine.h

…

load.cpp

scripted-diff: Fix ellipsis after pr20773

2021-05-27 13:46:36 +03:00

load.h

…

receive.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

receive.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

rpcdump.cpp

Merge bitcoin/bitcoin#21500: wallet, rpc: add an option to list private descriptors

2021-08-09 14:09:07 +12:00

rpcwallet.cpp

Add a new RPC command: restorewallet

2021-08-10 22:44:54 -03:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors

2021-08-09 14:45:12 +12:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors

2021-08-09 14:45:12 +12:00

spend.cpp

wallet: Assert that enough was selected to cover the fees

2021-08-13 00:34:47 -04:00

spend.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite PRAGMA assignments

2021-05-17 17:22:36 +02:00

sqlite.h

…

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

refactor: Switch serialize to uint8_t (1/n)

2021-05-31 14:56:17 +02:00

wallet.cpp

Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors

2021-08-09 14:45:12 +12:00

wallet.h

Change SignTransaction's input_errors to use bilingual_str

2021-07-01 12:57:53 -04:00

walletdb.cpp

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

walletdb.h

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

wallettool.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

wallettool.h

…

walletutil.cpp

scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls

2021-05-24 10:29:58 +02:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00