Ava Chow 08e6aaabef

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning ...

1ce45baed7dd2da3f1cb85c9c25110e5537451ae rpc: getwalletinfo, return wallet 'birthtime' (furszy)
83c66444d0604f0a9ec3bc3f89d4f1a810b7cda0 test: coverage for wallet birth time interaction with -reindex (furszy)
6f497377aa17cb8a590fd7717fa8ededf4249999 wallet: fix legacy spkm default birth time (furszy)
75fbf444c1e13c6ba0e79a34871534c845a13849 wallet: birth time update during tx scanning (furszy)
b4306e3c8db6cbaedc8845c6d21c750b39f682bf refactor: rename FirstKeyTimeChanged to MaybeUpdateBirthTime (furszy)

Pull request description:

  Fixing #28897.

  As the user may have imported a descriptor with a timestamp newer
  than the actual birth time of the first key (by setting 'timestamp=now'),
  the wallet needs to update the birth time when it detects a transaction
  older than the oldest descriptor timestamp.

  Testing Notes:
  Can cherry-pick the test commit on top of master. It will fail there.

ACKs for top commit:
  Sjors:
    re-utACK 1ce45baed7dd2da3f1cb85c9c25110e5537451ae
  achow101:
    ACK 1ce45baed7dd2da3f1cb85c9c25110e5537451ae

Tree-SHA512: 10c2382f87356ae9ea3fcb637d7edc5ed0e51e13cc2729c314c9ffb57c684b9ac3c4b757b85810c0a674020b7287c43d3be8273bcf75e2aff0cc1c037f1159f9

2023-12-14 16:27:40 -05:00

..

rpc

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

test

Merge bitcoin/bitcoin#29065: bench: wallet, fix change position out of range error

2023-12-13 12:45:30 -05:00

bdb.cpp

refactor: Return enum in LockDirectory

2023-10-26 10:25:22 +02:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coincontrol.h

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

crypter.cpp

refactor: Remove unused C-style casts

2023-07-24 15:32:00 +02:00

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

scripted-diff: Use DataStream in most places

2023-11-28 12:42:37 +01:00

dump.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

external_signer_scriptpubkeyman.h

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

feebumper.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

init: completely remove -zapwallettxes (remaining hidden option)

2023-11-03 20:00:44 +01:00

interfaces.cpp

wallet: use optional for change position as an optional in CreateTransaction

2023-12-08 17:12:19 -05:00

load.cpp

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

load.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

receive.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

spend.cpp

Merge bitcoin/bitcoin#28994: wallet: skip BnB when SFFO is enabled

2023-12-12 10:52:12 -05:00

spend.h

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

sqlite.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

sqlite.h

wallet: sqlite: force sqlite3.h to be included by the cpp files

2023-07-06 19:53:44 +00:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

wallet.h

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

walletdb.cpp

build: Enable -Wunreachable-code

2023-12-05 15:36:08 +01:00

walletdb.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

wallettool.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00