MarcoFalke
5e49b2a252
Merge bitcoin/bitcoin#24050 : validation: Give m_block_index ownership of CBlockIndexs
...
6c23c415613d8b847e6f6a2f872be893da9f4384 refactor: Rewrite AddToBlockIndex with try_emplace (Carl Dong)
c05cf7aa1e1c15089753897a10c14762027d4b99 style: Modernize range-based loops over m_block_index (Carl Dong)
c2a1655799c5d5dab9b14bd2a6b2d2296efd6964 style-only: Use using instead of typedef for BlockMap (Carl Dong)
dd79dad17545424d145e846026518d70da594380 refactor: Rewrite InsertBlockIndex with try_emplace (Carl Dong)
531dce034718523967808a89c18ba69a1e3e5a1f tests: Remove now-unnecessary manual Unload's (Carl Dong)
bec86ae32683ac56b4e6ba9c9b7d21cfbdf4ac03 blockstorage: Make m_block_index own CBlockIndex's (Carl Dong)
Pull request description:
Part of: #24303
Split off from: #22564
```
Instead of having CBlockIndex's live on the heap, which requires manual
memory management, have them be owned by m_block_index. This means that
they will live and die with BlockManager.
```
The second commit demonstrates how this makes calls to `Unload()` to satisfy the address sanitizer unnecessary.
ACKs for top commit:
ajtowns:
ACK 6c23c415613d8b847e6f6a2f872be893da9f4384
MarcoFalke:
re-ACK 6c23c415613d8b847e6f6a2f872be893da9f4384 🎨
Tree-SHA512: 81b2b5119be27cc0f8a9457b11da60cc60930315d2a5be36be89fe253d32073ffe622348ff153114b9b3212197bddbc791810913a43811b33cc58e7162bd105b
2022-03-07 13:15:27 +01:00
..
2022-03-02 12:09:27 +01:00
2022-02-01 11:19:18 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-09-29 14:10:29 +02:00
2022-02-17 03:42:08 +09:00
2022-02-17 00:36:47 +01:00
2022-03-02 12:09:27 +01:00
2022-03-01 18:32:01 +01:00
2021-10-05 11:10:47 -04:00
2022-03-02 15:25:48 +01:00
2021-12-30 19:36:57 +02:00
2022-02-04 22:47:49 +08:00
2022-03-07 13:15:27 +01:00
2022-02-14 16:01:26 -05:00
2022-02-19 09:35:10 +01:00
2022-03-05 17:20:55 +01:00
2022-03-07 13:15:27 +01:00
2022-03-04 07:28:23 -05:00
2021-12-15 09:19:50 -05:00
2022-01-02 11:40:31 +01:00
2022-03-07 13:15:27 +01:00
2021-10-11 20:45:56 +08:00
2022-03-02 06:09:27 -05:00
2022-03-07 13:15:27 +01:00
2022-01-31 16:53:12 +01:00
2021-11-12 11:46:34 +01:00
2021-09-07 09:11:10 +02:00
2022-02-25 08:45:11 +01:00
2021-12-30 19:36:57 +02:00
2021-12-28 21:54:51 +01:00
2022-02-25 09:53:10 +09:00
2022-02-25 09:53:10 +09:00
2022-01-13 15:56:59 +01:00
2022-01-28 19:27:25 +00:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-25 09:43:54 +01:00
2021-12-06 14:17:41 +13:00
2022-02-14 14:53:46 -05:00
2021-08-17 16:54:47 +08:00
2022-02-22 15:36:19 +00:00
2021-08-17 16:54:47 +08:00
2022-02-22 15:36:19 +00:00
2021-08-17 16:54:47 +08:00
2022-02-22 15:36:19 +00:00
2021-08-17 16:54:47 +08:00
2022-02-22 15:36:19 +00:00
2021-08-17 16:54:47 +08:00
2022-02-22 15:36:19 +00:00
2022-01-06 11:29:55 -05:00
2022-01-25 10:49:46 +01:00
2022-01-31 09:23:54 +01:00
2022-02-24 16:19:09 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-22 15:15:27 +01:00
2021-12-30 19:36:57 +02:00
2022-02-22 15:36:19 +00:00
2022-02-22 15:36:19 +00:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-11 17:21:44 +01:00
2022-01-07 13:37:47 -05:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-06 22:14:16 -05:00
2021-08-24 11:30:09 +02:00
2021-12-30 19:36:57 +02:00
2022-02-03 18:35:52 +08:00
2022-02-17 12:30:11 +01:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-13 18:35:25 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-03-07 11:42:36 +01:00
2022-02-22 15:36:19 +00:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-03 18:35:52 +08:00
2022-02-03 18:35:52 +08:00
2022-03-03 19:31:36 +00:00
2022-02-13 20:59:07 +00:00
2021-09-24 15:40:04 +08:00
2021-10-15 01:02:45 +00:00
2021-10-21 09:37:30 +08:00
2022-02-28 16:59:56 +01:00
2022-02-13 20:59:07 +00:00
2022-02-13 20:59:07 +00:00
2021-12-20 10:53:01 -05:00
2021-12-20 10:53:01 -05:00
2022-02-15 12:19:34 +01:00
2021-10-11 20:46:25 +08:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-03-07 08:47:05 +01:00
2022-01-25 18:48:41 +01:00
2021-12-14 18:58:45 +01:00
2021-12-30 19:36:57 +02:00
2022-03-02 15:42:37 +01:00
2022-03-02 15:42:40 +01:00
2022-02-11 15:21:52 +01:00
2022-02-11 15:21:52 +01:00
2022-03-02 09:33:03 +01:00
2022-03-02 09:33:03 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2022-02-02 17:22:42 +01:00
2022-01-30 08:59:10 -03:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-06 22:14:16 -05:00
2022-01-14 13:25:23 +01:00
2022-01-14 13:27:41 +01:00
2022-01-02 11:52:11 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:13:40 +01:00
2022-02-09 17:21:04 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-03-02 15:40:35 +01:00
2022-03-02 15:40:30 +01:00
2022-03-01 18:32:01 +01:00
2021-12-30 19:36:57 +02:00
2022-02-21 19:07:29 +01:00
2022-01-28 20:52:53 +01:00
2022-01-25 11:20:18 +08:00
2022-01-25 11:20:18 +08:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2022-03-07 13:15:27 +01:00
2022-03-07 12:13:32 +01:00
2022-01-28 18:07:08 +10:00
2022-01-28 08:46:03 +01:00
2022-01-06 22:14:16 -05:00
2021-12-30 19:36:57 +02:00