Ava Chow 835948d44b

Merge bitcoin/bitcoin#26836: wallet: batch and simplify addressbook migration process ...

86960cdb7f75eaa2ae150914c54240d1d5ef96d1 wallet: migration, batch addressbook records removal (furszy)
342c45f80e32b0320829ce380b5854844cd74bc8 wallet: addressbook migration, batch db writes (furszy)
595bbe6e81885d35179aba6137dc63d0e652cc1f refactor: wallet, simplify addressbook migration (furszy)
d0943315b1d00905fe7f4513b2f3f47b88a99e8f refactor: SetAddressBookWithDB, minimize number of map lookups (furszy)
bba4f8dcb55de3ca4963711dc17882b43cb0bc4a refactor: SetAddrBookWithDB, signal only if write succeeded (furszy)
97b075392305becfbad4d497614478cff2d9237f wallet: clean redundancies in DelAddressBook (furszy)

Pull request description:

  Commits decoupled from #28574, focused on the address book cloning process

  Includes:

  1) DB batch operations and flow simplification for the address book migration process.
  2) Code improvements to `CWallet::DelAddressBook` and `Wallet::SetAddrBookWithDB` methods.

  These changes will let us consolidate all individual write operations that take place during the wallet migration process into a single db txn in the future.

ACKs for top commit:
  achow101:
    ACK 86960cdb7f75eaa2ae150914c54240d1d5ef96d1
  josibake:
    reACK 86960cdb7f

Tree-SHA512: 10c941df3cd84fd8662b9c9ca6a1ed2c7402d38c677d2fc66b8b6c9edc6d73e827a5821487bbcacb5569d502934fa548fd10699e2ec45185f869e43174d8b2a1

2024-02-08 09:05:00 -05:00

..

rpc

wallet: clarify replaced_by_txid and replaces_txid in help output

2024-01-23 17:34:16 -07:00

test

Merge bitcoin/bitcoin#29112: sqlite: Disallow writing from multiple SQLiteBatchs

2024-02-07 21:46:06 -05:00

bdb.cpp

refactor: Return enum in LockDirectory

2023-10-26 10:25:22 +02:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coincontrol.h

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

crypter.cpp

refactor: Remove unused C-style casts

2023-07-24 15:32:00 +02:00

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

wallet: remove unused 'accept_no_keys' arg from decryption process

2024-02-03 12:56:43 -03:00

dump.cpp

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

dump.h

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

external_signer_scriptpubkeyman.cpp

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

external_signer_scriptpubkeyman.h

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

feebumper.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

init: completely remove -zapwallettxes (remaining hidden option)

2023-11-03 20:00:44 +01:00

interfaces.cpp

wallet: use optional for change position as an optional in CreateTransaction

2023-12-08 17:12:19 -05:00

load.cpp

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

load.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

receive.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#28833: wallet: refactor: remove unused SignatureData instances in spkm's FillPSBT methods

2024-02-06 13:35:41 -05:00

scriptpubkeyman.h

wallet: remove unused 'accept_no_keys' arg from decryption process

2024-02-03 12:56:43 -03:00

spend.cpp

Merge bitcoin/bitcoin#28560: wallet, rpc: FundTransaction refactor

2024-01-23 16:40:58 -05:00

spend.h

refactor: pass CRecipient to FundTransaction

2024-01-19 15:04:56 +01:00

sqlite.cpp

sqlite: Ensure that only one SQLiteBatch is writing to db at a time

2024-02-06 12:24:36 -05:00

sqlite.h

sqlite: Ensure that only one SQLiteBatch is writing to db at a time

2024-02-06 12:24:36 -05:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

Merge bitcoin/bitcoin#26836: wallet: batch and simplify addressbook migration process

2024-02-08 09:05:00 -05:00

wallet.h

Merge bitcoin/bitcoin#26836: wallet: batch and simplify addressbook migration process

2024-02-08 09:05:00 -05:00

walletdb.cpp

refactor: Compile unreachable code

2024-01-25 16:25:55 +01:00

walletdb.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

wallettool.cpp

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00