cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-19 20:09:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/rpc
History
Andrew Chow 19a7e608f9
Merge bitcoin/bitcoin#28505: rpc: bumpfee, improve doc for 'reduce_output' arg 
b3db8c9d5ccfe5c31341169fa7ac044427122921 rpc: bumpfee, improve doc for 'reduce_output' arg (furszy)

Pull request description:

  Fixes #28180. Resulted from discussions with S3RK, achow101, and Murch.

  The current argument name and description are dangerous as it don't
  describe the case where the user selects the recipient output as the
  change address. This one could end up been increased by the inputs
  minus outputs remainder. Which, when `bumpfee` adds new inputs
  to the transaction, leads the process to send more coins to the
  recipient. Which is not what the user would expect from a
  'reduce_output' param naming.

ACKs for top commit:
  S3RK:
    ACK b3db8c9d5ccfe5c31341169fa7ac044427122921
  achow101:
    ACK b3db8c9d5ccfe5c31341169fa7ac044427122921
  murchandamus:
    ACK b3db8c9d5ccfe5c31341169fa7ac044427122921

Tree-SHA512: 91f607e2f5849041d7c099afdddae11af8bed5b1ac90c9d22921267f272e21b44e107d6968e037f05f958a61fe29e94e5fb44b224fb3606f197f83ec4ba3b1e7
2023-09-27 16:46:27 -04:00
..
blockchain.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
blockchain.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
client.cpp
rpc: bumpfee, improve doc for 'reduce_output' arg
2023-09-26 20:17:02 -03:00
client.h
refactor: rpc: hide and rename ParseNonRFCJSONValue()
2023-03-23 18:18:46 +00:00
external_signer.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
fees.cpp
rpc: Run type check against RPCArgs
2023-01-11 17:42:09 +01:00
mempool.cpp
Refactor: Replace 'isMockableChain' with inline 'ChainType' check for 'submitpackage'
2023-09-15 16:32:11 +02:00
mempool.h
…
mining.cpp
rpc: Add MaybeArg() and Arg() default helper
2023-08-24 10:44:45 +02:00
mining.h
…
net.cpp
Merge bitcoin/bitcoin#26366: rpc, test: addnode improv + add test coverage for invalid command
2023-09-21 06:35:16 -04:00
node.cpp
Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers
2023-08-07 22:31:46 +02:00
output_script.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
protocol.h
…
rawtransaction_util.cpp
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2023-05-09 18:48:52 +02:00
rawtransaction_util.h
wallet: add outputs arguments to bumpfee and psbtbumpfee
2023-01-17 13:28:53 +02:00
rawtransaction.cpp
rpc: descriptorprocesspsbt return hex encoded tx
2023-09-15 16:46:09 +01:00
register.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
request.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
request.h
…
server_util.cpp
refactor: Split util::AnyPtr into its own file
2023-05-20 12:03:33 +02:00
server_util.h
net: add Ensure{any}Banman
2023-02-09 17:14:01 -03:00
server.cpp
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
server.h
RPC: Add add OBJ_NAMED_PARAMS type
2023-05-03 11:27:51 -05:00
signmessage.cpp
…
txoutproof.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
util.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
util.h
rpc: Add MaybeArg() and Arg() default helper
2023-08-24 10:44:45 +02:00