MacroFake 062b9db0cc

Merge bitcoin/bitcoin#25594: refactor: Return BResult from restoreWallet ...

fa475e9c7977a952617738f2ee8cf600c07d4df8 refactor: Return BResult from restoreWallet (MacroFake)
fa8de09edc9ec4e6d171df80f746174a0ec58afb Prepare BResult for non-copyable types (MacroFake)

Pull request description:

  This avoids the `error` in-out param (and if `warnings` is added to `BResult`, it will avoid passing that in-out param as well).

  Also, as it is needed for this change, prepare `BResult` for non-copyable types.

ACKs for top commit:
  w0xlt:
    reACK fa475e9c79
  ryanofsky:
    Code review ACK fa475e9c7977a952617738f2ee8cf600c07d4df8. Changes since last review were replacing auto with explicit type and splitting commits

Tree-SHA512: 46350883572f13721ddd198f5dfb88d2fa58ebcbda416f74da3563ea15c920fb1e6ff30558526a4ac91c36c21e6afe27751a4e51b7b8bcbcbe805209f4e9014b

2022-07-14 10:04:42 +02:00

..

rpc

Merge bitcoin/bitcoin#25464: rpc: Reduce Univalue push_backV peak memory usage in listtransactions

2022-07-13 15:58:53 +01:00

test

Merge bitcoin/bitcoin#25218: refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination

2022-07-12 13:56:48 +02:00

bdb.cpp

wallet: don't read db every time that a new WalletBatch is created

2022-06-16 12:18:58 -03:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

coinselection.cpp

Revert "bnb: exit selection when best_waste is 0"

2022-06-28 17:27:06 -04:00

coinselection.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

send: refactor CreateTransaction flow to return a BResult<CTransactionRef>

2022-07-08 11:18:35 -03:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

refactor: Return BResult from restoreWallet

2022-07-12 19:20:01 +02:00

ismine.h

…

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

…

receive.cpp

wallet: avoid extra IsSpentKey -> GetWalletTx lookups

2022-06-08 11:22:40 -03:00

receive.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

wallet: refactor GetNewDestination, use BResult

2022-07-08 11:18:35 -03:00

scriptpubkeyman.h

wallet: refactor GetNewDestination, use BResult

2022-07-08 11:18:35 -03:00

spend.cpp

Merge bitcoin/bitcoin#25218: refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination

2022-07-12 13:56:48 +02:00

spend.h

Merge bitcoin/bitcoin#25218: refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination

2022-07-12 13:56:48 +02:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

…

transaction.h

…

wallet.cpp

wallet: change ScanForWalletTransactions to use Ticks()

2022-07-12 10:29:08 -03:00

wallet.h

Merge bitcoin/bitcoin#25218: refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination

2022-07-12 13:56:48 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#25383: wallet: don't read db every time that a new 'WalletBatch' is created

2022-06-30 18:38:20 +02:00

walletdb.h

walletdb: Create a mock database of specific type

2022-05-10 11:54:02 -04:00

wallettool.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…