cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-16 16:32:47 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/interfaces
History
merge-script 2702711c3a
Merge bitcoin/bitcoin#34642: wallet: call SyncWithValidationInterfaceQueue after disconnecting chain notifications 
98e8af4bb991fd8edeb15c0fb8afa66bff6b5cac wallet: Drain validation interface queue after notifications disconnect (Ava Chow)
52992ebe1c55c8f7219b824f05d22fbc18acb794 interfaces: Add waitForNotifications() to call SyncWithValidationInterfaceQueue() (Ava Chow)

Pull request description:

  When the wallet disconnects chain notifications, it is expecting no further notifications to execute, but this is not the case. This results in test failures such as in #34354. Instead of disconnecting the notifications and continuing shutdown, we should wait for the validation interface queue to be drained before the rest of wallet shutdown. This is achieved by adding an `interfaces::Chain::waitForNotifications()` function which calls `SyncWithValidationInterfaceQueue()`.

  Fixes #34354

ACKs for top commit:
  stickies-v:
    utACK 98e8af4bb991fd8edeb15c0fb8afa66bff6b5cac
  furszy:
    ACK 98e8af4bb991fd8edeb15c0fb8afa66bff6b5cac
  rkrux:
    crACK 98e8af4bb991fd8edeb15c0fb8afa66bff6b5cac
  sedited:
    ACK 98e8af4bb991fd8edeb15c0fb8afa66bff6b5cac

Tree-SHA512: 263628556f740cb633d3970c22a0dfdb52a644bd1d0cd5a69c2970524edbb0e25d592cb39fc9bf1d0c281eebce09578526e2958dffee9026fc7473db35bd0dec
2026-03-02 22:00:53 +01:00
..
chain.h
interfaces: Add waitForNotifications() to call SyncWithValidationInterfaceQueue()
2026-02-27 12:16:35 -08:00
echo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
handler.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.h
ipc mining: break compatibility with existing clients (version bump)
2026-02-12 03:34:08 +01:00
ipc.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mining.h
ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup
2026-02-24 10:15:14 -05:00
node.h
refactor: Remove empty caption from ThreadSafeMessageBox
2026-01-14 19:36:14 +01:00
README.md
multiprocess: Add comments and documentation
2021-04-23 03:02:50 -05:00
types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
wallet.h
refactor: interfaces, make 'createTransaction' less error-prone
2026-02-06 18:15:59 -05:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #19160.

  • Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.