cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 19:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Wladimir J. van der Laan b386d37360
Merge #18710: Add local thread pool to CCheckQueue 
bb6fcc75d1ec94b733d1477c816351c50be5faf9 refactor: Drop boost::thread stuff in CCheckQueue (Hennadii Stepanov)
6784ac471bb32b6bb8e2de60986f123eb4990706 bench: Use CCheckQueue local thread pool (Hennadii Stepanov)
dba30695fc42f45828db008e7e5b81cb2b5d8551 test: Use CCheckQueue local thread pool (Hennadii Stepanov)
01511776acb0c7ec216dc9c8112531067763f1cb Add local thread pool to CCheckQueue (Hennadii Stepanov)
0ef938685b5c079a6f5a98daf0e3865d718d817b refactor: Use member initializers in CCheckQueue (Hennadii Stepanov)

Pull request description:

  This PR:
  - gets rid of `boost::thread_group` in the `CCheckQueue` class
  - allows thread safety annotation usage in the `CCheckQueue` class
  - is alternative to #14464 (https://github.com/bitcoin/bitcoin/pull/18710#issuecomment-616618525, https://github.com/bitcoin/bitcoin/pull/18710#issuecomment-617291612)

  Also, with this PR (I hope) it could be easier to resurrect a bunch of brilliant ideas from #9938.

  Related: #17307

ACKs for top commit:
  laanwj:
    Code review ACK bb6fcc75d1ec94b733d1477c816351c50be5faf9
  LarryRuane:
    ACK bb6fcc75d1ec94b733d1477c816351c50be5faf9
  jonatack:
    Code review ACK bb6fcc75d1ec94b733d1477c816351c50be5faf9 and verified rebase to master builds cleanly with unit/functional tests green

Tree-SHA512: fddeb720d5a391b48bb4c6fa58ed34ccc3f57862fdb8e641745c021841c8340e35c5126338271446cbd98f40bd5484f27926aa6c3e76fa478ba1efafe72e73c1
2021-01-25 20:21:19 +01:00
..
bench
Merge #18710: Add local thread pool to CCheckQueue
2021-01-25 20:21:19 +01:00
compat
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
config
…
consensus
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
crc32c
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
crypto
Merge #19055: Add MuHash3072 implementation
2021-01-07 17:57:17 +01:00
index
Merge #19935: Move SaltedHashers to separate file and add some new ones
2021-01-13 08:49:17 +01:00
interfaces
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
leveldb
…
logging
…
node
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
policy
refactor: Use C++17 std::array deduction for ALL_FEE_ESTIMATE_HORIZONS
2021-01-03 18:38:31 +01:00
primitives
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
qt
Merge bitcoin-core/gui#176: Fix TxViewDelegate layout
2021-01-21 18:54:19 +01:00
rpc
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
script
Merge #19935: Move SaltedHashers to separate file and add some new ones
2021-01-13 08:49:17 +01:00
secp256k1
Update secp256k1 subtree to latest master
2020-10-27 23:08:48 -07:00
support
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
test
Merge #18710: Add local thread pool to CCheckQueue
2021-01-25 20:21:19 +01:00
univalue
Update univalue subtree
2020-11-19 15:48:24 +01:00
util
Merge #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls
2021-01-21 18:48:03 +01:00
wallet
Merge #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls
2021-01-21 18:48:03 +01:00
zmq
Merge #20523: zmq: deduplicate 'sequence' publisher message creation/sending
2021-01-22 12:58:47 +08:00
.clang-format
…
addrdb.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrdb.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrman.cpp
Don't declare de facto const reference variables as non-const
2020-12-06 18:44:31 +00:00
addrman.h
Merge #20291: [net] Consolidate logic around calling CAddrMan::Connected()
2020-11-19 16:30:54 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.h
…
base58.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
base58.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-cli.cpp
netinfo: add user help documentation
2021-01-05 21:31:48 +01:00
bitcoin-tx-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-tx.cpp
Move TX_MAX_STANDARD_VERSION to policy
2020-12-10 11:12:08 +01:00
bitcoin-util-res.rc
Add bitcoin-util command line utility
2021-01-12 18:34:25 +10:00
bitcoin-util.cpp
Merge #20938: build: fix linking against -latomic when building for riscv
2021-01-18 18:33:24 +01:00
bitcoin-wallet-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-wallet.cpp
wallet: Add missing check for -descriptors wallet tool option
2020-12-17 20:36:41 +01:00
bitcoind-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoind.cpp
init: Signal-safe instant shutdown
2020-12-15 17:21:06 +01:00
blockencodings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockencodings.h
…
blockfilter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockfilter.h
…
bloom.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bloom.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Move signet onion seed from v2 to v3
2020-12-15 14:12:01 +01:00
chainparams.h
Remove gArgs global from CreateChainParams to aid testing
2020-09-29 10:20:05 +02:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsbase.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.21
2020-10-25 14:25:00 +01:00
checkqueue.h
refactor: Drop boost::thread stuff in CCheckQueue
2020-09-24 06:55:34 +03:00
clientversion.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
clientversion.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
coins.cpp
Merge #19935: Move SaltedHashers to separate file and add some new ones
2021-01-13 08:49:17 +01:00
coins.h
Move Hashers to util/hasher.{cpp/h}
2020-11-10 14:33:37 -05:00
compat.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_memusage.h
…
core_read.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_write.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
cuckoocache.h
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
dbwrapper.cpp
…
dbwrapper.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
dummywallet.cpp
wallet: Remove -upgradewallet from dummywallet
2020-11-04 12:16:57 -05:00
flatfile.cpp
Fix possible data race when committing block files
2020-08-25 16:46:46 +00:00
flatfile.h
…
fs.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
fs.h
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
hash.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
hash.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httprpc.cpp
rpc: Validate -rpcauth arguments
2020-11-23 21:02:54 +00:00
httprpc.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httpserver.cpp
net: Drop unneeded headers when compat.h included
2020-10-22 21:45:20 +03:00
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #18710: Add local thread pool to CCheckQueue
2021-01-25 20:21:19 +01:00
init.h
Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const
2020-12-06 00:22:40 +00:00
key_io.cpp
Replace boost::variant with std::variant
2021-01-05 10:10:50 +01:00
key_io.h
…
key.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
key.h
…
logging.cpp
Don't declare de facto const member functions as non-const
2020-12-06 18:44:25 +00:00
logging.h
Don't declare de facto const member functions as non-const
2020-12-06 18:44:25 +00:00
Makefile.am
build: Add var printing target to src/Makefile.am
2021-01-21 10:57:31 -05:00
Makefile.bench.include
net: Add libnatpmp support
2021-01-07 18:07:09 +02:00
Makefile.crc32c.include
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
…
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
Merge bitcoin-core/gui#176: Fix TxViewDelegate layout
2021-01-21 18:54:19 +01:00
Makefile.qttest.include
net: Add libnatpmp support
2021-01-07 18:07:09 +02:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
Makefile.test.include
Merge #18077: net: Add NAT-PMP port forwarding support
2021-01-07 19:41:55 +01:00
mapport.cpp
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
mapport.h
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
miner.cpp
Don't declare de facto const member functions as non-const
2020-12-06 18:44:25 +00:00
miner.h
Don't declare de facto const member functions as non-const
2020-12-06 18:44:25 +00:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
net_permissions.h
Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
2020-10-12 12:14:53 -07:00
net_processing.cpp
Merge #20811: refactor: move net_processing implementation details out of header
2021-01-13 09:48:06 +01:00
net_processing.h
net_processing: move Peer definition to .cpp
2021-01-09 23:27:45 +10:00
net_types.h
…
net.cpp
[net] Cleanup InactivityChecks() and add commenting about time
2021-01-19 10:50:36 +00:00
net.h
[net] Cleanup InactivityChecks() and add commenting about time
2021-01-19 10:50:36 +00:00
netaddress.cpp
net: allow CSubNet of non-IP networks
2021-01-10 15:51:15 +01:00
netaddress.h
Merge #20852: net: allow CSubNet of non-IP networks
2021-01-11 11:27:47 +01:00
netbase.cpp
net: update GetNetworkName() with all enum Network cases
2020-10-15 19:21:38 +02:00
netbase.h
…
netmessagemaker.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
optional.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
outputtype.cpp
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
outputtype.h
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
protocol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
psbt.cpp
psbt: Assert that tx has a value in UpdatePSBTOutput
2020-12-19 09:45:39 +01:00
psbt.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
pubkey.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
pubkey.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
…
randomenv.cpp
util: Allow use of C++14 chrono literals
2020-12-08 16:47:36 +01:00
randomenv.h
…
rest.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Support bypassing range check in ReadCompactSize
2020-10-09 10:32:19 +02:00
shutdown.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
shutdown.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
signet.cpp
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
signet.h
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
span.h
Merge #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute
2020-11-25 15:18:33 +01:00
streams.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
sync.cpp
sync: Improve CheckLastCritical()
2020-12-10 20:46:29 +02:00
sync.h
Merge #20495: sync: Use decltype(auto) return type for WITH_LOCK
2021-01-12 15:56:19 +08:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
torcontrol.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
torcontrol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
txdb.cpp
…
txdb.h
…
txmempool.cpp
locks: Annotate CTxMemPool::check to require cs_main
2021-01-20 16:15:03 -05:00
txmempool.h
locks: Annotate CTxMemPool::check to require cs_main
2021-01-20 16:15:03 -05:00
txrequest.cpp
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
undo.h
…
validation.cpp
Merge #18710: Add local thread pool to CCheckQueue
2021-01-25 20:21:19 +01:00
validation.h
Merge #18710: Add local thread pool to CCheckQueue
2021-01-25 20:21:19 +01:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00