bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-02 09:46:14 +00:00

History

Merge #16670 : util: Add Join helper to join a list of strings

faebf6271467048dc8a9a0c526a0f8565023a966 rpc: Use Join helper in rpc/util (MarcoFalke)
fa8cd6f9c13319baca467864661982a3dfb2320c util: Add Join helper to join a list of strings (MarcoFalke)

Pull request description:

  We have a lot of enumerations in the code and sometimes those enumerations need to be mentioned in the RPC or command line documentation. Previously, each caller would have a couple of lines inline to join the strings or the joined string is hardcoded in the documentation. A helper to join strings would make code such as https://github.com/bitcoin/bitcoin/pull/16629#discussion_r315852446 less verbose and easier to read.

  Also, warnings commonly accumulate in complex RPCs, since a warning doesn't lead to an early return. A helper to join those warnings would make code such as https://github.com/bitcoin/bitcoin/pull/16394/files#r309324997 less verbose and easier to read.

ACKs for top commit:
  practicalswift:
    ACK faebf6271467048dc8a9a0c526a0f8565023a966

Tree-SHA512: 80f2db86a05c63b686f510585c1c631250271a8958fd71fafaac91559ffd2ec25d609bf7d53412ba27f87eff5893ac9dd9c2f296fc0c73581556e1d6a734a36f

2019-08-22 08:41:00 -04:00

blockchain.cpp

RPC: add weight to mempool entry output

2019-08-19 11:34:10 +08:00

blockchain.h

rpc: Add lock annotations to block{,header}ToJSON

2019-05-02 14:33:26 -04:00

client.cpp

[RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables

2019-07-04 08:02:23 -04:00

client.h

Update copyright headers to 2018