Suhas Daftuar
4eb515574e
Make TX_WITNESS_STRIPPED its own rejection reason ...
Previously, TX_WITNESS_MUTATED could be returned during transaction validation
for either transactions that had a witness that was non-standard, or for
transactions that had no witness but were invalid due to segwit validation
rules.
However, for txid/wtxid-relay considerations, net_processing distinguishes the
witness stripped case separately, because it affects whether a wtxid should be
able to be added to the reject filter. It is safe to add the wtxid of a
witness-mutated transaction to the filter (as that wtxid shouldn't collide with
the txid, and hence it wouldn't interfere with transaction relay from
txid-relay peers), but it is not safe to add the wtxid (== txid) of a
witness-stripped transaction to the filter, because that would interfere with
relay of another transaction with the same txid (but different wtxid) when
relaying from txid-relay peers.
Also updates the comment explaining this logic, and explaining that we can get
rid of this complexity once there's a sufficient deployment of wtxid-relaying
peers on the network.
2020-07-19 02:10:42 -04:00
2020-07-15 15:35:11 +02:00
2020-05-20 08:27:07 -04:00
2020-07-19 02:10:42 -04:00
2020-01-28 17:00:01 +01:00
2020-06-29 11:31:17 +08:00
2020-06-27 11:49:28 -04:00
2020-07-09 13:07:37 +02:00
2020-01-28 16:59:07 +01:00
2020-04-30 18:02:04 +08:00
2020-07-19 02:05:29 -04:00
2020-07-05 13:46:38 +03:00
2020-05-20 07:30:29 -04:00
2020-07-16 09:55:19 +02:00
2020-07-16 21:38:09 +02:00
2020-07-01 17:24:46 -04:00
2020-06-09 13:39:09 -07:00
2020-05-29 17:22:07 -04:00
2020-07-18 09:24:58 +02:00
2020-02-09 07:44:29 -08:00
2020-07-11 15:02:07 +02:00
2020-07-14 16:21:01 +02:00
2020-04-16 13:33:09 -04:00
2020-07-06 03:52:37 +02:00
2020-06-22 12:12:22 +02:00
2020-07-03 20:43:55 -07:00
2020-05-06 14:59:28 +02:00
2020-03-04 14:24:19 +01:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-07-08 21:44:45 +08:00
2020-07-03 20:43:55 -07:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-10-16 08:56:57 -07:00
2019-09-05 13:25:11 +12:00
2020-07-05 16:39:17 +02:00
2020-04-16 13:33:09 -04:00
2020-05-25 12:36:48 -04:00
2020-06-27 11:49:28 -04:00
2020-05-28 09:55:39 +03:00
2020-05-28 09:55:39 +03:00
2020-04-20 14:57:48 +00:00
2020-05-26 17:27:15 -04:00
2020-06-21 06:41:55 -04:00
2020-05-20 07:30:29 -04:00
2019-12-30 10:42:20 +13:00
2020-04-16 13:33:09 -04:00
2020-06-15 18:22:52 +09:00
2020-04-16 13:33:09 -04:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-04-03 16:29:26 +02:00
2020-04-16 13:33:09 -04:00
2020-05-04 19:53:58 +03:00
2020-05-03 18:42:14 +00:00
2020-05-06 13:15:28 +02:00
2019-12-30 10:42:20 +13:00
2020-04-16 13:33:09 -04:00
2019-12-30 10:42:20 +13:00
2020-05-22 01:40:31 +09:00
2020-07-16 21:38:09 +02:00
2020-04-08 14:45:27 +00:00
2019-12-30 10:42:20 +13:00
2020-07-08 14:26:14 +03:00
2020-05-01 07:39:00 -04:00
2020-05-20 07:30:29 -04:00
2020-06-16 15:15:46 -04:00
2019-12-30 10:42:20 +13:00
2019-03-31 11:41:05 -07:00
2020-05-21 06:53:39 -04:00
2020-05-13 16:20:13 -04:00
2020-06-27 11:49:28 -04:00
2020-04-16 13:33:09 -04:00
2020-04-16 13:33:09 -04:00
2020-07-14 16:33:01 +02:00
2020-05-13 16:20:13 -04:00
2019-12-30 10:42:20 +13:00
2020-06-10 18:29:33 -07:00
2019-12-30 10:42:20 +13:00
2020-06-07 17:03:49 +02:00
2020-05-28 09:54:24 +03:00
2020-06-27 11:49:35 -04:00
2020-04-29 00:31:41 -07:00
2020-01-28 17:01:48 +01:00
2020-05-12 18:03:39 +03:00
2020-04-01 12:49:15 +02:00
2020-06-29 18:49:13 +01:00
2019-11-21 21:13:08 +01:00
2020-04-05 01:01:13 +02:00
2020-04-05 10:46:24 +08:00
2020-07-18 09:24:58 +02:00
2020-04-16 13:33:09 -04:00
2020-03-30 16:09:51 -07:00
2020-03-30 16:09:51 -07:00
2020-06-15 08:08:19 -04:00
2020-06-15 08:08:19 -04:00
2020-07-09 12:48:05 +02:00
2020-07-09 12:48:05 +02:00
2020-07-19 02:10:42 -04:00
2020-07-19 02:05:29 -04:00
2019-10-29 11:30:12 +02:00
2020-07-14 10:24:43 +01:00
2020-07-18 19:00:01 -04:00
2020-07-10 14:58:42 +02:00
2020-07-10 14:58:42 +02:00
2020-06-22 12:12:22 +02:00
2020-01-08 12:35:59 +00:00
2020-05-11 00:20:57 +02:00
2020-06-27 11:49:28 -04:00
2020-05-05 04:45:59 +03:00
2019-12-30 10:42:20 +13:00
2020-07-01 18:03:12 -04:00
2020-07-01 18:02:38 -04:00
2020-04-30 18:02:03 +08:00
2020-07-19 02:10:41 -04:00
2020-07-19 02:10:41 -04:00
2020-06-24 16:32:19 -04:00
2020-06-24 16:32:19 -04:00
2019-12-30 10:42:20 +13:00
2020-06-10 17:35:43 +03:00
2020-05-15 08:58:49 -04:00
2020-04-30 09:19:14 -04:00
2020-04-16 13:33:09 -04:00
2019-11-12 14:50:44 -08:00
2020-06-24 18:41:45 +02:00
2020-06-21 06:02:59 -04:00
2020-06-21 06:02:59 -04:00
2020-06-22 12:12:22 +02:00
2020-06-26 13:49:52 -07:00
2019-12-30 10:42:20 +13:00
2020-06-25 21:27:34 +03:00
2020-06-11 15:49:39 +03:00
2019-12-30 10:42:20 +13:00
2020-06-11 15:49:39 +03:00
2020-06-27 11:49:28 -04:00
2019-12-06 10:02:08 +01:00
2020-01-08 12:35:59 +00:00
2019-12-30 10:42:20 +13:00
2020-06-27 11:49:28 -04:00
2020-01-15 02:18:00 +07:00
2020-07-18 19:00:01 -04:00
2020-07-18 19:00:01 -04:00
2020-01-23 16:35:08 -05:00
2020-01-23 16:35:08 -05:00
2020-04-16 13:33:09 -04:00
2020-07-19 02:10:42 -04:00
2020-07-11 19:41:24 +02:00
2020-05-22 16:30:07 -04:00
2020-05-22 16:30:07 -04:00
2020-07-19 02:10:41 -04:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-06-10 15:01:20 +03:00
2020-06-10 15:01:20 +03:00
4eb515574e