cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-17 10:59:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 4eada5d8b1
Merge #20816: net: Move RecordBytesSent() call out of cs_vSend lock 
378aedc45248cea82d9a3e6dc1038d6828008a76 [net] Add cs_vSend lock annotations (John Newbery)
673254515a2f97e53dd8c7335c836b083ba7e31a [net] Move RecordBytesSent() call out of cs_vSend lock (John Newbery)

Pull request description:

  RecordBytesSent() does not require cs_vSend to be locked, so reduce the scope of cs_vSend.

  Also correctly annotate the CNode data members that are guarded by cs_vSend.

  This is a simpler alternative to #19673.

ACKs for top commit:
  jnewbery:
    ok, reverting to commit 378aedc which has two ACKs already. Any style issues can be fixed up in future PRs.
  troygiorshev:
    ACK 378aedc45248cea82d9a3e6dc1038d6828008a76
  theStack:
    re-ACK 378aedc45248cea82d9a3e6dc1038d6828008a76
  MarcoFalke:
    review ACK 378aedc45248cea82d9a3e6dc1038d6828008a76 🔌

Tree-SHA512: e9cd6c472b7e1479120c1bf2d1c640cf6d18c7d589a5f9b7dfc4875e5790adaab403a7a1b945a47e79e7249a614b8583270e4549f89b22e8a9edb2e4818b0d07
2021-01-06 07:07:35 +01:00
..
bench
doc: fix various typos
2021-01-04 12:31:31 +08:00
compat
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
config
…
consensus
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
crc32c
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
crypto
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
index
Merge #19846: build: enable unused member function diagnostic
2021-01-05 12:06:40 +01:00
interfaces
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
leveldb
…
logging
…
node
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
policy
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
primitives
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
qt
doc: fix various typos
2021-01-04 12:31:31 +08:00
rpc
rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
2021-01-01 15:08:07 +01:00
script
Merge #19846: build: enable unused member function diagnostic
2021-01-05 12:06:40 +01:00
secp256k1
Update secp256k1 subtree to latest master
2020-10-27 23:08:48 -07:00
support
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
test
Merge #19846: build: enable unused member function diagnostic
2021-01-05 12:06:40 +01:00
univalue
Update univalue subtree
2020-11-19 15:48:24 +01:00
util
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
wallet
doc: fix various typos
2021-01-04 12:31:31 +08:00
zmq
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
.clang-format
tools: clang-format 6 compatibility
2020-07-06 03:52:37 +02:00
addrdb.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrdb.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
Merge #20291: [net] Consolidate logic around calling CAddrMan::Connected()
2020-11-19 16:30:54 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
base58.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-cli.cpp
cli -netinfo: print oversized/extreme ping times as "-"
2020-10-25 16:51:21 +01:00
bitcoin-tx-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-tx.cpp
Move TX_MAX_STANDARD_VERSION to policy
2020-12-10 11:12:08 +01:00
bitcoin-wallet-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-wallet.cpp
wallet: Add missing check for -descriptors wallet tool option
2020-12-17 20:36:41 +01:00
bitcoind-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoind.cpp
init: Signal-safe instant shutdown
2020-12-15 17:21:06 +01:00
blockencodings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockfilter.h
[indexes] Fix default [de]serialization of BlockFilter.
2020-05-26 17:27:15 -04:00
bloom.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bloom.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Move signet onion seed from v2 to v3
2020-12-15 14:12:01 +01:00
chainparams.h
Remove gArgs global from CreateChainParams to aid testing
2020-09-29 10:20:05 +02:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsbase.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.21
2020-10-25 14:25:00 +01:00
checkqueue.h
…
clientversion.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
clientversion.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
coins.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
coins.h
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
compat.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_memusage.h
…
core_read.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_write.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
cuckoocache.h
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
dbwrapper.cpp
…
dbwrapper.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
dummywallet.cpp
wallet: Remove -upgradewallet from dummywallet
2020-11-04 12:16:57 -05:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fs.h
…
hash.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
hash.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httprpc.cpp
rpc: Validate -rpcauth arguments
2020-11-23 21:02:54 +00:00
httprpc.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httpserver.cpp
net: Drop unneeded headers when compat.h included
2020-10-22 21:45:20 +03:00
httpserver.h
…
indirectmap.h
…
init.cpp
refactor: Remove nMyStartingHeight from CNode/Connman
2021-01-02 10:24:45 +01:00
init.h
Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const
2020-12-06 00:22:40 +00:00
key_io.cpp
…
key_io.h
…
key.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
key.h
…
logging.cpp
log: remove deprecated db log category
2020-06-07 17:03:49 +02:00
logging.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
Makefile.am
Merge #20434: contrib: Parse ELF directly for symbol and security checks
2020-12-18 12:16:40 +01:00
Makefile.bench.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.crc32c.include
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.qttest.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
Makefile.test.include
Merge #20377: fuzz: Fill various small fuzzing gaps
2020-12-29 09:27:29 +01:00
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
miner.cpp
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
miner.h
Remove mapLinks in favor of entry inlined structs with iterator type erasure
2020-09-04 09:46:44 -07:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
net_permissions.h
Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
2020-10-12 12:14:53 -07:00
net_processing.cpp
refactor: Remove nMyStartingHeight from CNode/Connman
2021-01-02 10:24:45 +01:00
net_processing.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
net_types.h
…
net.cpp
Merge #20816: net: Move RecordBytesSent() call out of cs_vSend lock
2021-01-06 07:07:35 +01:00
net.h
Merge #20816: net: Move RecordBytesSent() call out of cs_vSend lock
2021-01-06 07:07:35 +01:00
netaddress.cpp
Check if Cjdns address is valid
2020-12-14 14:48:52 -03:00
netaddress.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
netbase.cpp
net: update GetNetworkName() with all enum Network cases
2020-10-15 19:21:38 +02:00
netbase.h
…
netmessagemaker.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
optional.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
outputtype.cpp
Enable Wswitch for OutputType
2020-07-01 18:03:12 -04:00
outputtype.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
protocol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
psbt.cpp
psbt: Assert that tx has a value in UpdatePSBTOutput
2020-12-19 09:45:39 +01:00
psbt.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
pubkey.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
pubkey.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
…
randomenv.cpp
util: Allow use of C++14 chrono literals
2020-12-08 16:47:36 +01:00
randomenv.h
…
rest.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
reverse_iterator.h
…
scheduler.cpp
clang-format scheduler
2020-06-21 06:02:59 -04:00
scheduler.h
clang-format scheduler
2020-06-21 06:02:59 -04:00
serialize.h
Support bypassing range check in ReadCompactSize
2020-10-09 10:32:19 +02:00
shutdown.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
shutdown.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
signet.cpp
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
signet.h
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
span.h
Merge #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute
2020-11-25 15:18:33 +01:00
streams.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
sync.cpp
sync: Improve CheckLastCritical()
2020-12-10 20:46:29 +02:00
sync.h
[skip ci] sync: Check precondition in LEAVE_CRITICAL_SECTION() macro
2020-12-10 20:46:39 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
torcontrol.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
torcontrol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
txdb.cpp
Merge #18637: coins: allow cache resize after init
2020-07-29 07:53:19 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
refactor: Clean up CTxMemPool initializer list
2020-10-23 14:41:40 +02:00
txmempool.h
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
txrequest.cpp
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
undo.h
…
validation.cpp
[mempool] Remove error suppression on upgrade
2021-01-04 12:02:29 -08:00
validation.h
Merge #20575: Do not run functions with necessary side-effects in assert()
2020-12-16 23:14:53 +01:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00