mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-01 03:01:05 +00:00
5b1aae12ca
Fix GUI startup crash reported by Rspigler in https://github.com/bitcoin/bitcoin/issues/24457 that happens if settings.json contains an integer value for any of the configuration options which GUI settings can currently clash with (-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy, -proxy, -onion, -onion, -lang, and -prune). Fix is a one-line change in ArgsManager::GetArg.
32 lines
999 B
C++
32 lines
999 B
C++
// Copyright (c) 2018 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <qt/bitcoin.h>
|
|
#include <qt/test/optiontests.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <util/system.h>
|
|
|
|
#include <QSettings>
|
|
#include <QTest>
|
|
|
|
#include <univalue.h>
|
|
|
|
//! Entry point for BitcoinApplication tests.
|
|
void OptionTests::optionTests()
|
|
{
|
|
// Test regression https://github.com/bitcoin/bitcoin/issues/24457. Ensure
|
|
// that setting integer prune value doesn't cause an exception to be thrown
|
|
// in the OptionsModel constructor
|
|
gArgs.LockSettings([&](util::Settings& settings) {
|
|
settings.forced_settings.erase("prune");
|
|
settings.rw_settings["prune"] = 3814;
|
|
});
|
|
gArgs.WriteSettingsFile();
|
|
OptionsModel{};
|
|
gArgs.LockSettings([&](util::Settings& settings) {
|
|
settings.rw_settings.erase("prune");
|
|
});
|
|
gArgs.WriteSettingsFile();
|
|
}
|