fanquake 46494b08e2

Merge #16798: Refactor rawtransaction_util's SignTransaction to separate prevtx parsing ...

39034f1ee628dae0bc9da5b1b30b8a424e66d968 Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow)

Pull request description:

  Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information.

  This allows for `SignTransaction` to just take any `SigningProvider`.

  Split from #16341

ACKs for top commit:
  MarcoFalke:
    ACK 39034f1ee628dae0bc9da5b1b30b8a424e66d968
  instagibbs:
    utACK 39034f1ee6
  ryanofsky:
    utACK 39034f1ee628dae0bc9da5b1b30b8a424e66d968. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, https://github.com/bitcoin/bitcoin/pull/16341#pullrequestreview-278610269 other than rebase with no conflicts.

Tree-SHA512: 09f7733e90691766bfb5cf0f20e913dbf270bd3b51abdcad966b24d110e562ed85fd3d0d1d7bbea61f903340060052ec73c4817b09aee0dc1f3916d781a9e40c

2019-09-07 08:39:56 +08:00

..

test

Encapsulate tx status in a Confirmation struct

2019-08-23 14:53:20 -04:00

coincontrol.cpp

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coincontrol.h

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coinselection.cpp

Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection

2018-12-12 14:22:12 -08:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

crypter.h

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

db.cpp

Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record

2019-07-27 22:45:31 +12:00

db.h

Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record

2019-07-27 22:45:31 +12:00

feebumper.cpp

Restrict lifetime of ReserveDestination to CWallet::CreateTransaction

2019-07-10 11:38:37 -04:00

feebumper.h

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

fees.cpp

[wallet] abort when attempting to fund a transaction above maxtxfee

2019-06-28 22:44:38 -04:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Use ArgsManager::NETWORK_ONLY flag

2019-07-27 22:51:58 +03:00

ismine.cpp

Move various SigningProviders to signingprovider.{cpp,h}

2019-07-09 16:20:18 -04:00

ismine.h

Change ismine to take a CWallet instead of CKeyStore

2019-06-19 18:06:30 -04:00

load.cpp

scripted-diff: Make translation bilingual

2019-07-24 16:33:20 +03:00

load.h

scripted-diff: Bump copyright headers in wallet

2019-05-06 14:05:52 -04:00

psbtwallet.cpp

Merge #15427: Add support for descriptors to utxoupdatepsbt

2019-07-02 16:53:22 +02:00

psbtwallet.h

Remove unused TransactionError constants

2019-02-14 10:32:02 -05:00

rpcdump.cpp

Encapsulate tx status in a Confirmation struct

2019-08-23 14:53:20 -04:00

rpcwallet.cpp

Merge #16798: Refactor rawtransaction_util's SignTransaction to separate prevtx parsing

2019-09-07 08:39:56 +08:00

rpcwallet.h

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

wallet.cpp

Merge #16624: wallet: encapsulate transactions state

2019-09-06 01:28:54 +12:00

wallet.h

Modify wallet tx status if has been reorged out

2019-08-29 11:17:51 -04:00

walletdb.cpp

wallet: Drop unused OldKey

2019-07-31 18:35:46 +01:00

walletdb.h

Add setting as known type

2019-07-30 06:36:34 +01:00

wallettool.cpp

scripted-diff: Replace fprintf with tfm::format

2019-06-13 10:32:52 -04:00

wallettool.h

Move ismine to wallet module

2019-06-19 18:06:30 -04:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

wallet: Add WalletLocation utility class

2018-10-25 11:53:17 +01:00