fanquake 83c7269965

Merge bitcoin/bitcoin#27800: streams: Drop confusing DataStream::Serialize method and << operator ...

5cd0717a54ce7a2065b29d90717aa2eb1c5e302d streams: Drop confusing DataStream::Serialize method and << operator (Ryan Ofsky)

Pull request description:

  DataStream Serialize method has surprising behavior because it just serializes raw bytes without a length prefix. When you serialize a string or vector, a length prefix is serialized before the raw object contents so the object can be unambiguously deserialized later. But DataStreams don't support deserializing at all and just dump the raw bytes.

  Having this inconsistency is not necessary and could be confusing (see https://github.com/bitcoin/bitcoin/pull/27790#discussion_r1212315030) so this PR just drops the DataStream::Serialize method.

ACKs for top commit:
  furszy:
    lgtm ACK 5cd0717a
  MarcoFalke:
    lgtm ACK 5cd0717a54ce7a2065b29d90717aa2eb1c5e302d 🌙

Tree-SHA512: 49dd117de266f091a5336b13a91c5d8658abe1b3a0a9c51c8b5f6a2e0e814781b73afc39256353e79dade603a8a2761e8536716d1a48499720c266f4500477e2

2023-06-02 10:28:01 +01:00

..

rpc

Merge bitcoin/bitcoin#26485: RPC: Accept options as named-only parameters

2023-06-01 15:30:31 -04:00

test

fuzz: fix wallet notifications.cpp

2023-05-30 17:46:46 -03:00

bdb.cpp

wallet: bugfix, GetNewCursor() misses to provide batch ptr to BerkeleyCursor

2023-05-15 12:23:15 -03:00

bdb.h

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

coincontrol.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coincontrol.h

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coinselection.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

coinselection.h

refactor: Split util::insert into its own file

2023-05-20 12:03:31 +02:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

…

crypter.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

db.h

wallet: Move DummyDatabase to salvage

2023-05-03 10:45:10 -04:00

dump.cpp

streams: Drop confusing DataStream::Serialize method and << operator

2023-06-01 10:27:33 -04:00

dump.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

external_signer_scriptpubkeyman.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

external_signer_scriptpubkeyman.h

wallet: set keypool_size instead of access global args manager

2023-02-15 15:49:44 -03:00

feebumper.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

feebumper.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

…

init.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

load.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

wallet: Move DummyDatabase to salvage

2023-05-03 10:45:10 -04:00

salvage.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

scriptpubkeyman.cpp

wallet: skip block scan if block was created before wallet birthday

2023-05-25 10:45:38 -03:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#27759: Fix #includes in src/wallet

2023-05-29 16:33:14 +01:00

spend.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

spend.h

gui: bugfix, getAvailableBalance skips selected coins

2023-04-03 17:23:42 -03:00

sqlite.cpp

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

sqlite.h

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

transaction.cpp

…

transaction.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

streams: Drop confusing DataStream::Serialize method and << operator

2023-06-01 10:27:33 -04:00

wallet.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

walletdb.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

walletdb.h

walletdb: Remove unused CreateMockWalletDatabase

2023-05-15 16:14:43 -04:00

wallettool.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

Fix #includes in src/wallet

2023-05-25 15:52:08 +01:00