cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 03:31:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
glozow 3d0fca1288
Merge bitcoin/bitcoin#26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started 
7ad15d11005eac36421398530da127333d87ea80 [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (dergoegge)

Pull request description:

  This PR fixes a bug in the headers sync logic that enables submitting headers to a nodes block index that don't lead to a chain that surpasses our DoS limit.

  The issue is that we ignore the return value on [the first `IsContinuationOfLowWorkHeadersSync` call after a new headers sync is started](fabc031048/src/net_processing.cpp (L2553-L2568)), which leads to us passing headers to [`ProcessNewBlockHeaders`](fabc031048/src/net_processing.cpp (L2856)) when that initial `IsContinuationOfLowWorkHeadersSync` call returns `false`. One easy way (maybe the only?) to trigger this is by sending 2000 headers where the last header has a different `nBits` value than the prior headers (which fails the pre-sync logic [here](fabc031048/src/headerssync.cpp (L189))). Those 2000 headers will be passed to `ProcessNewBlockHeaders`.

  I haven't included a test here so far because we can't test this without changing the default value for `CRegTestParams::consensus.fPowAllowMinDifficultyBlocks` or doing some more involved refactoring.

ACKs for top commit:
  sipa:
    ACK 7ad15d11005eac36421398530da127333d87ea80
  glozow:
    ACK 7ad15d1100

Tree-SHA512: 9aabb8bf3700401e79863d0accda0befd2a83c4d469a53f97d827e51139e2f826aee08cdfbc8866b311b153f61fdac9b7aa515fcfa2a21c5e2812c2bf3c03664
2022-10-24 15:38:37 +01:00
..
bench
Merge bitcoin/bitcoin#26158: bench: add "priority level" to the benchmark framework
2022-10-20 11:05:03 -04:00
common
refactor: move run_command from util to common
2022-10-04 21:21:05 +00:00
compat
moveonly: move IsSelectableSocket() from compat.h to sock.{h,cpp}
2022-07-20 16:26:19 +02:00
config
…
consensus
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
crc32c
Update crc32c subtree to latest upstream master
2022-08-13 13:55:38 +01:00
crypto
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
index
Merge bitcoin/bitcoin#26215: index: Improve BaseIndex::BlockUntilSyncedToCurrentChain reliability
2022-10-10 14:23:00 +08:00
init
Update -debug and -debugexclude help docs for severity level logging
2022-08-20 11:55:17 +02:00
interfaces
Make validation interface capable of signalling header presync
2022-08-29 08:10:35 -04:00
ipc
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
kernel
refactor: mempool: add MemPoolLimits::NoLimits()
2022-10-05 13:07:11 +01:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-09-29 16:43:30 +01:00
logging
util, refactor: Add UNIQUE_NAME helper macro
2022-02-16 14:59:20 +02:00
minisketch
Update minisketch subtree to latest master
2022-06-29 16:35:02 +01:00
node
Merge bitcoin/bitcoin#25595: Verify PSBT inputs rather than check for fields being empty
2022-10-20 08:13:14 +08:00
policy
add lock annotation for FeeFilterRounder::round()
2022-10-13 14:42:59 -04:00
primitives
CBlockLocator: performance-move-const-arg Clang tidy fixups
2022-08-31 15:10:26 +02:00
qt
Merge bitcoin-core/gui#676: Update peers window "Transaction Relay" label and tooltip
2022-10-24 10:42:47 +02:00
rpc
Merge bitcoin/bitcoin#25412: rest: add /deploymentinfo endpoint
2022-10-13 13:30:55 -04:00
script
Merge bitcoin/bitcoin#25858: psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path
2022-10-13 09:40:27 -04:00
secp256k1
Update secp256k1 subtree to latest upstream master
2022-06-11 14:55:18 +01:00
support
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
test
test: Use C++11 member initializers for TestMemPoolEntryHelper
2022-10-18 17:32:44 +02:00
univalue
rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR
2022-09-15 10:24:53 -03:00
util
Merge bitcoin/bitcoin#25727: util, config: error on startup if conf or reindex are set in config file
2022-10-21 16:39:44 +08:00
wallet
Merge bitcoin/bitcoin#26302: refactor: Use type-safe time point for CWallet::m_next_resend
2022-10-24 10:11:13 +08:00
zmq
iwyu: Add zmq source files
2022-10-10 15:44:02 +01:00
.bear-tidy-config
tidy: enable modernize-use-nullptr
2022-04-26 10:43:33 +01:00
.clang-format
…
.clang-tidy
Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)
2022-08-31 08:38:24 +01:00
addrdb.cpp
Use steady clock for all millis bench logging
2022-07-30 10:23:58 +02:00
addrdb.h
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
addrman_impl.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.cpp
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
arith_uint256.cpp
Merge bitcoin/bitcoin#24077: util: Make base_uint::GetHex() and base_uint::SetHex() not depend on uint256
2022-04-14 07:15:22 +02:00
arith_uint256.h
Remove duplicate static_asserts
2022-04-14 19:26:22 +02:00
attributes.h
…
banman.cpp
Use steady clock for all millis bench logging
2022-07-30 10:23:58 +02:00
banman.h
refactor: Add thread safety annotation to BanMan::SweepBanned()
2022-05-20 15:17:00 +02:00
base58.cpp
scripted-diff: Rename ValidAsCString to ContainsNoNUL
2022-04-27 14:16:35 +02:00
base58.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
bech32.cpp
refactor: Make 64-bit shift explicit
2022-10-04 21:49:07 +01:00
bech32.h
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bitcoin-chainstate.cpp
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Update getpeerinfo/-netinfo/TxRelay#m_relay_txs relaytxes docs (for v24 backport)
2022-09-22 16:45:32 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
refactor: use <cstdio> over stdio.h
2022-09-21 16:53:11 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
util: improve bitcoin-wallet exit codes
2022-09-12 13:11:18 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Fix issues identified by codespell 2.2.1 and update ignored words
2022-09-15 13:03:40 +02:00
blockencodings.cpp
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockencodings.h
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockfilter.cpp
Use new Join() helper for ListBlockFilterTypes()
2022-08-24 10:15:32 +02:00
blockfilter.h
refactor: add LIFETIMEBOUND to blockfilter where needed
2022-08-31 16:51:32 +01:00
chain.cpp
CBlockLocator: performance-move-const-arg Clang tidy fixups
2022-08-31 15:10:26 +02:00
chain.h
Add functions to construct locators without CChain
2022-08-23 16:05:00 -04:00
chainparams.cpp
Update chainparams for 24.0 release
2022-08-31 15:31:34 +03:00
chainparams.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.h
…
chainparamsseeds.h
Merge bitcoin/bitcoin#25853: net: update testnet torv3 hardcoded seeds for 24.x
2022-09-09 10:07:39 +02:00
checkqueue.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
clientversion.cpp
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
clientversion.h
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
coins.cpp
Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks
2022-08-19 17:11:06 +02:00
coins.h
refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize()
2022-06-21 16:19:10 +02:00
compressor.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compressor.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_io.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
core_memusage.h
…
core_read.cpp
refactor: Make const refs vars where applicable
2022-07-27 13:27:57 +02:00
core_write.cpp
refactor: add stdd:: includes to core_write
2022-03-30 20:11:15 +01:00
cuckoocache.h
validationcaches: Use size_t for sizes
2022-08-03 12:03:28 -04:00
dbwrapper.cpp
db: add StoragePath to CDBWrapper/CCoinsViewDB
2022-09-13 12:38:06 -04:00
dbwrapper.h
db: add StoragePath to CDBWrapper/CCoinsViewDB
2022-09-13 12:38:06 -04:00
deploymentinfo.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentinfo.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentstatus.cpp
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
deploymentstatus.h
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
dummywallet.cpp
wallet: ensure wallet files are not reused across chains
2022-02-16 15:02:26 +02:00
external_signer.cpp
refactor: move run_command from util to common
2022-10-04 21:21:05 +00:00
external_signer.h
…
flatfile.cpp
Disallow more unsafe string->path conversions allowed by path append operators
2022-04-21 12:01:00 -05:00
flatfile.h
…
fs.cpp
fs: fully initialize _OVERLAPPED for win32
2022-09-14 11:55:10 +01:00
fs.h
fs: work around u8path deprecated-declaration warnings with libc++
2022-08-19 08:58:56 +01:00
hash.cpp
Fix link to MurmurHash3.cpp from Austin Appleby
2022-08-30 13:52:45 +02:00
hash.h
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
headerssync.cpp
Move headerssync logging to BCLog::NET
2022-08-30 12:09:04 -04:00
headerssync.h
Track headers presync progress and log it
2022-08-29 08:10:35 -04:00
httprpc.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
httprpc.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httpserver.cpp
Merge bitcoin/bitcoin#26131: log: log RPC port on startup
2022-09-30 16:29:22 +02:00
httpserver.h
Merge bitcoin/bitcoin#24681: build: Bump libevent minimum version up to 2.1.8
2022-04-06 13:19:36 +01:00
i2p.cpp
i2p: use the same destination type for transient and persistent addresses
2022-09-12 12:55:36 +02:00
i2p.h
i2p: add support for creating transient sessions
2022-08-11 17:51:18 +02:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#26142: Use PACKAGE_NAME in messages rather than hardcoding "Bitcoin Core"
2022-10-19 09:22:22 +02:00
init.h
Move init::SanityCheck to kernel::SanityCheck
2022-06-02 11:42:12 -04:00
key_io.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key_io.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.cpp
extended keys: fail to derive too large depth instead of wrapping around
2022-08-04 11:32:26 +02:00
key.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
logging.cpp
log: Add tx reconciliation log category
2022-10-17 12:00:59 +03:00
logging.h
log: Add tx reconciliation log category
2022-10-17 12:00:59 +03:00
Makefile.am
Merge bitcoin/bitcoin#26313: doc: consolidate library documentation to libraries.md
2022-10-18 13:44:56 +02:00
Makefile.bench.include
build: remove duplicate / unneeded libs from bench_bitcoin
2022-09-15 10:29:12 +01:00
Makefile.crc32c.include
build: Create .la library for crc32c
2022-04-26 16:25:38 -04:00
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: Pre-branch translation updates for 23.x
2022-02-28 16:59:56 +01:00
Makefile.qt.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.qttest.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.test_fuzz.include
fuzz: add util/mempool/h.cpp
2022-10-04 21:12:50 +01:00
Makefile.test_util.include
test: Remove unused txmempool include from tests
2022-10-18 14:02:09 +02:00
Makefile.test.include
Merge bitcoin/bitcoin#26158: bench: add "priority level" to the benchmark framework
2022-10-20 11:05:03 -04:00
Makefile.univalue.include
…
mapport.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
mapport.h
…
memusage.h
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
merkleblock.cpp
…
merkleblock.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_processing.cpp
Merge bitcoin/bitcoin#26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started
2022-10-24 15:38:37 +01:00
net_processing.h
net: add NetEventsInterface::g_msgproc_mutex
2022-09-15 14:44:38 +10:00
net_types.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
net_types.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net.cpp
Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods
2022-10-12 15:49:02 -04:00
net.h
Merge bitcoin/bitcoin#25989: init: abort if i2p/cjdns are chosen via -onlynet but are unreachable
2022-09-21 11:00:47 +01:00
netaddress.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
netaddress.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netbase.cpp
Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods
2022-10-12 15:49:02 -04:00
netbase.h
moveonly: move SetSocketNonBlocking() from netbase to util/sock
2022-07-20 16:26:24 +02:00
netgroup.cpp
[netgroup] Use nStartByte as offset for the last byte of the group
2022-04-25 15:09:14 +02:00
netgroup.h
[netgroupman] Remove NetGroupManager::GetAsmap()
2022-04-20 14:35:53 +01:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
noui.h
…
outputtype.cpp
Merge bitcoin/bitcoin#25734: wallet, refactor: #24584 follow-ups
2022-08-16 20:00:19 -04:00
outputtype.h
wallet: remove UNKNOWN type from OUTPUT_TYPES array
2022-08-18 16:47:15 -03:00
pow.cpp
Add function to validate difficulty changes
2022-08-23 11:34:10 -04:00
pow.h
Add function to validate difficulty changes
2022-08-23 11:34:10 -04:00
prevector.h
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
protocol.cpp
p2p: Announce reconciliation support
2022-10-17 12:35:43 +03:00
protocol.h
p2p: Announce reconciliation support
2022-10-17 12:35:43 +03:00
psbt.cpp
Verify PSBT inputs rather than check for fields being empty
2022-10-17 11:13:02 -04:00
psbt.h
Verify PSBT inputs rather than check for fields being empty
2022-10-17 11:13:02 -04:00
pubkey.cpp
Merge bitcoin/bitcoin#25642: Don't wrap around when deriving an extended key at a too large depth
2022-08-10 14:25:43 -04:00
pubkey.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
random.cpp
refactor: use <cstdlib> over stdlib.h
2022-09-23 10:48:47 +01:00
random.h
refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono)
2022-07-13 15:21:12 +02:00
randomenv.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
randomenv.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rest.cpp
Merge bitcoin/bitcoin#25412: rest: add /deploymentinfo endpoint
2022-10-13 13:30:55 -04:00
rest.h
Handle query string when parsing data format
2022-03-10 12:01:53 +01:00
reverse_iterator.h
…
scheduler.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
scheduler.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
serialize.h
Add ChronoFormatter to serialize
2022-07-26 11:05:04 +02:00
shutdown.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
shutdown.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
span.h
scripted-diff: rename BytePtr to AsBytePtr
2022-04-26 09:41:45 +01:00
streams.h
Merge bitcoin/bitcoin#25667: assumeutxo: snapshot initialization
2022-10-13 10:19:27 -04:00
sync.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
sync.h
Merge bitcoin/bitcoin#25676: sync: simplify and remove unused code from sync.h
2022-10-11 09:18:55 +08:00
threadinterrupt.cpp
Expose underlying clock in CThreadInterrupt
2022-07-13 15:20:49 +02:00
threadinterrupt.h
Fix iwyu
2022-08-20 09:33:01 +02:00
threadsafety.h
…
timedata.cpp
Make adjusted time type safe
2022-08-05 14:59:15 +02:00
timedata.h
Make adjusted time type safe
2022-08-05 14:59:15 +02:00
tinyformat.h
…
torcontrol.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
torcontrol.h
torcontrol: Query Tor for correct -onion configuration
2022-03-15 01:33:52 +00:00
txdb.cpp
CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()
2022-07-22 12:45:07 +02:00
txdb.h
db: add StoragePath to CDBWrapper/CCoinsViewDB
2022-09-13 12:38:06 -04:00
txmempool.cpp
Merge bitcoin/bitcoin#26103: refactor: mempool: use CTxMemPool::Limits
2022-10-09 10:28:32 -04:00
txmempool.h
Merge bitcoin/bitcoin#26103: refactor: mempool: use CTxMemPool::Limits
2022-10-09 10:28:32 -04:00
txorphanage.cpp
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txorphanage.h
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txrequest.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
Use ReadLE64 in uint256::GetUint64() instead of duplicating logic
2022-09-15 16:48:50 -04:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#25830: refactor: Replace m_params with chainman.GetParams()
2022-10-19 10:04:34 +02:00
validation.h
Merge bitcoin/bitcoin#25830: refactor: Replace m_params with chainman.GetParams()
2022-10-19 10:04:34 +02:00
validationinterface.cpp
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
validationinterface.h
scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
2022-05-09 18:35:44 +02:00
version.h
…
versionbits.cpp
Sanity assert GetAncestor() != nullptr where appropriate
2022-05-05 15:55:44 +02:00
versionbits.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
walletinitinterface.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
warnings.cpp
scripted-diff: Convert global Mutexes to GlobalMutexes
2022-05-21 01:23:23 +10:00
warnings.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00