merge-script 3c1418666b

Merge bitcoin/bitcoin#32930: Resolve guix non-determinism with emplace_back instead of push_back ...

f43571010e3853e83a21aa4774b1c8da47b5d961 Resolve guix non-determinism with emplace_back instead of push_back (Ava Chow)

Pull request description:

  For some reason, building x86_64-w64-mingw32 on x86_64 and aarch64 results in a single instruction difference which can be traced down to prevector.h:174. The ultimate caller of this is the copy constructor for a prevector that ends up being called by std::vector::push_back in walletmodel.cpp:183. By replacing the push_back with an emplace_back, somehow this non-determinism goes away.

  Closes #32923

ACKs for top commit:
  l0rinc:
    code review ACK f43571010e3853e83a21aa4774b1c8da47b5d961
  Sjors:
    utACK f43571010e3853e83a21aa4774b1c8da47b5d961
  maflcko:
    lgtm ACK f43571010e3853e83a21aa4774b1c8da47b5d961

Tree-SHA512: 5bf0571f32cb72efc0c533e16d2704cfc3a79bcef2943f0892743572808610fb00ca8ab41223897536f8e5090bf4030735be910942de8116652d02bc3f231e2e

2025-07-11 10:24:40 +01:00

..

bench

Merge bitcoin/bitcoin#32758: wallet: remove dead code in legacy wallet migration

2025-07-10 14:41:44 -07:00

common

Merge bitcoin/bitcoin#32673: clang-tidy: Apply modernize-deprecated-headers

2025-06-11 15:08:23 -07:00

compat

build: simplify *ifaddr handling

2025-05-08 16:49:58 +01:00

consensus

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

crc32c

…

crypto

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

index

Explicitly close all AutoFiles that have been written

2025-06-16 15:33:15 +02:00

init

refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options

2025-02-13 12:30:15 -05:00

interfaces

remove RPCTimerInterface and RPCRunLater

2025-07-03 06:26:23 -04:00

ipc

refactor: modernize deprecated ipc headers

2025-06-19 16:29:55 +02:00

kernel

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

leveldb

Update leveldb subtree to latest upstream

2025-05-30 16:51:49 +01:00

logging

scripted-diff: modernize outdated trait patterns - values

2025-02-21 10:43:01 +01:00

minisketch

Update minisketch subtree to latest upstream

2025-05-13 18:07:47 +01:00

node

Merge bitcoin/bitcoin#32862: rpc: use CScheduler for relocking wallet and remove RPCTimer

2025-07-07 17:59:21 -07:00

policy

Explicitly close all AutoFiles that have been written

2025-06-16 15:33:15 +02:00

primitives

refactor: CTransaction equality should consider witness data

2025-06-10 22:10:05 +00:00

qt

Resolve guix non-determinism with emplace_back instead of push_back

2025-07-10 10:29:53 -07:00

rpc

Merge bitcoin/bitcoin#32862: rpc: use CScheduler for relocking wallet and remove RPCTimer

2025-07-07 17:59:21 -07:00

script

Merge bitcoin/bitcoin#32564: miniscript, refactor: Make operator""_mst consteval (re-take)

2025-07-02 15:06:33 +01:00

secp256k1

Update secp256k1 subtree to latest master

2025-05-13 11:31:34 +01:00

support

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

test

Merge bitcoin/bitcoin#30605: Cluster linearization: separate tests from tests-of-tests

2025-07-10 13:52:31 -04:00

univalue

doc: add & amend copyright headers

2025-05-20 09:43:21 +01:00

util

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

wallet

Merge bitcoin/bitcoin#32758: wallet: remove dead code in legacy wallet migration

2025-07-10 14:41:44 -07:00

zmq

chore: use std::vector<std::byte> for BlockManager::ReadRawBlock()

2025-06-13 19:19:44 +03:00

.clang-format

…

.clang-tidy

clang-tidy: Apply modernize-deprecated-headers

2025-06-03 15:13:54 +02:00

addrdb.cpp

Explicitly close all AutoFiles that have been written

2025-06-16 15:33:15 +02:00

addrdb.h

…

addresstype.cpp

…

addresstype.h

refactor: deduplicate anchor witness program bytes (0x4e,0x73)

2025-03-23 21:58:39 +01:00

addrman_impl.h

…

addrman.cpp

addrman: cap the max_pct to not exceed the maximum number of addresses

2024-11-11 12:47:53 -03:00

addrman.h

addrman: cap the max_pct to not exceed the maximum number of addresses

2024-11-11 12:47:53 -03:00

arith_uint256.cpp

Add a fuzz test for Num3072 multiplication and inversion

2025-01-09 10:11:46 -05:00

arith_uint256.h

arith_uint256: modernize comparison operators

2025-04-07 10:45:13 -04:00

attributes.h

…

banman.cpp

refactor: Delay translation of _() literals

2025-01-14 19:21:37 +01:00

banman.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

base58.cpp

clang-tidy: Apply modernize-deprecated-headers

2025-06-03 15:13:54 +02:00

base58.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

bech32.cpp

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

bech32.h

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

bip324.cpp

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

bip324.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

bitcoin-chainstate.cpp

refactor: Pass verification_progress into block tip notifications

2025-05-24 13:49:32 +02:00

bitcoin-cli-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoin-cli.cpp

cli: Reject + sign in -netinfo level parsing

2025-05-15 19:48:38 +02:00

bitcoin-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoin-tx-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoin-tx.cpp

bitcoin-tx: Reject + sign in MutateTxDel*

2025-05-17 09:36:25 +02:00

bitcoin-util-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoin-util.cpp

refactor: Use TranslateFn type consistently

2025-01-15 12:15:40 +01:00

bitcoin-wallet-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoin-wallet.cpp

Remove create options from wallet tool

2025-05-09 15:07:04 +02:00

bitcoin.cpp

multiprocess: Add bitcoin wrapper executable

2025-05-12 14:49:17 -04:00

bitcoind-res.rc

doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

2025-06-10 15:14:24 +02:00

bitcoind.cpp

refactor: introduce a more general LockDirectories for init

2025-01-16 21:06:21 +00:00

blockencodings.cpp

p2p: Add witness mutation check inside FillBlock

2025-06-10 10:07:56 -04:00

blockencodings.h

p2p: remove vestigial READ_STATUS_CHECKBLOCK_FAILED

2025-06-10 10:07:56 -04:00

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

validation: Don't use IsValid() to filter for invalid blocks

2025-06-12 14:40:59 -04:00

chainparams.cpp

test: Reject + sign when parsing regtest deployment params

2025-05-15 22:12:24 +02:00

chainparams.h

…

chainparamsbase.cpp

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

chainparamsbase.h

net, init: derive default onion port if a user specified a -port

2024-11-14 13:41:02 -05:00

chainparamsseeds.h

seeds: update fixed dns seeds

2025-03-06 15:39:58 -06:00

checkqueue.h

validation: use a lock for CCheckQueueControl

2025-05-19 22:06:48 +00:00

clientversion.cpp

doc: update MIT license URL

2025-05-20 09:30:41 +01:00

clientversion.h

windows: Use predefined RC_INVOKED macro instead of custom one

2025-05-29 11:18:36 +01:00

cluster_linearize.h

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

CMakeLists.txt

windows: Add application manifest to bitcoin.exe

2025-05-28 20:22:00 +01:00

coins.cpp

Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests

2024-12-04 14:09:05 -05:00

coins.h

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

compressor.cpp

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

compressor.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

core_io.h

rpc: add getdescriptoractivity

2024-11-26 20:47:08 -05:00

core_memusage.h

…

core_read.cpp

refactor: starts/ends_with changes for clang-tidy 20

2025-04-22 13:16:54 +01:00

core_write.cpp

…

cuckoocache.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

dbwrapper.cpp

refactor: Remove manual CDBBatch size estimation

2025-04-07 15:59:41 +02:00

dbwrapper.h

refactor: Remove manual CDBBatch size estimation

2025-04-07 15:59:41 +02:00

deploymentinfo.cpp

scripted-diff: rename gbt_force and gbt_force_name

2025-04-30 14:51:21 +02:00

deploymentinfo.h

scripted-diff: rename gbt_force and gbt_force_name

2025-04-30 14:51:21 +02:00

deploymentstatus.cpp

scripted-diff: modernize outdated trait patterns - types

2025-02-21 10:41:27 +01:00

deploymentstatus.h

versionbits: Simplify VersionBitsCache API

2025-01-21 00:38:03 +10:00

dummywallet.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

external_signer.cpp

…

external_signer.h

…

flatfile.cpp

flatfile: check whether the file has been closed successfully

2025-06-16 15:33:19 +02:00

flatfile.h

…

hash.cpp

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

hash.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

headerssync.cpp

[headerssync] update headerssync config for v29

2025-03-04 14:23:18 -05:00

headerssync.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

httprpc.cpp

remove RPCTimerInterface and RPCRunLater

2025-07-03 06:26:23 -04:00

httprpc.h

…

httpserver.cpp

Merge bitcoin/bitcoin#32539: init: Configure reachable networks before we start the RPC server

2025-06-06 15:31:36 -07:00

httpserver.h

rpc: increase the defaults for -rpcthreads and -rpcworkqueue

2024-11-04 17:08:21 +01:00

i2p.cpp

refactor: starts/ends_with changes for clang-tidy 20

2025-04-22 13:16:54 +01:00

i2p.h

…

indirectmap.h

…

init.cpp

log: Add rate limiting to LogPrintf, LogInfo, LogWarning, LogError, LogPrintLevel

2025-07-09 09:13:00 -04:00

init.h

refactor: introduce a more general LockDirectories for init

2025-01-16 21:06:21 +00:00

key_io.cpp

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

key_io.h

…

key.cpp

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

key.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

logging.cpp

log: Add rate limiting to LogPrintf, LogInfo, LogWarning, LogError, LogPrintLevel

2025-07-09 09:13:00 -04:00

logging.h

log: Add rate limiting to LogPrintf, LogInfo, LogWarning, LogError, LogPrintLevel

2025-07-09 09:13:00 -04:00

mapport.cpp

mapport: make ProcessPCP void

2024-11-04 14:19:40 -05:00

mapport.h

mapport: rename 'use_pcp' to 'enable'

2024-10-29 11:58:51 -04:00

memusage.h

memusage: Add DynamicUsage for std::string

2024-11-04 18:46:40 +01:00

merkleblock.cpp

…

merkleblock.h

…

net_permissions.cpp

…

net_permissions.h

scripted-diff: modernize outdated trait patterns - types

2025-02-21 10:41:27 +01:00

net_processing.cpp

Merge bitcoin/bitcoin#32646: p2p: Add witness mutation check inside FillBlock

2025-06-30 13:15:37 -04:00

net_processing.h

refactor: Fix net_processing iwyu includes

2024-11-13 14:09:58 +01:00

net_types.cpp

…

net_types.h

…

net.cpp

Explicitly close all AutoFiles that have been written

2025-06-16 15:33:15 +02:00

net.h

threading: semaphore: move CountingSemaphoreGrant to its own header

2025-05-10 03:31:30 +00:00

netaddress.cpp

doc: update URLs

2025-06-03 08:09:21 +01:00

netaddress.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

netbase.cpp

Merge bitcoin/bitcoin#32826: p2p: add more bad ports

2025-06-30 13:28:17 -04:00

netbase.h

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

netgroup.cpp

…

netgroup.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

wallet, rpc: Use OUTPUT_TYPES to describe the output types instead of hardcoding them

2025-06-18 18:11:28 -03:00

outputtype.h

wallet, rpc: Use OUTPUT_TYPES to describe the output types instead of hardcoding them

2025-06-18 18:11:28 -03:00

pow.cpp

fuzz: enable running fuzz test cases in Debug mode

2025-04-22 17:11:24 +10:00

pow.h

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

prevector.h

refactor: Remove UB in prevector reverse iterators

2025-05-14 09:35:32 +02:00

protocol.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

protocol.h

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

psbt.cpp

psbt: use sighash type field to determine whether to remove non-witness utxos

2025-05-14 14:00:43 -07:00

psbt.h

psbt: use sighash type field to determine whether to remove non-witness utxos

2025-05-14 14:00:43 -07:00

pubkey.cpp

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

pubkey.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

random.cpp

random: Use modern Windows randomness functions

2025-05-14 22:55:10 -07:00

random.h

Merge bitcoin/bitcoin#31519: refactor: Use std::span over Span

2025-03-20 13:41:54 +08:00

randomenv.cpp

build: simplify *ifaddr handling

2025-05-08 16:49:58 +01:00

randomenv.h

…

rest.cpp

rest: replace rf_names[0].rf by RESTResponseFormat::UNDEF for code clarity

2025-07-06 11:20:18 +08:00

rest.h

…

scheduler.cpp

thread-safety: fix annotations with REVERSE_LOCK

2025-06-16 18:09:14 +00:00

scheduler.h

…

semaphore_grant.h

threading: semaphore: move CountingSemaphoreGrant to its own header

2025-05-10 03:31:30 +00:00

serialize.h

refactor: re-enable UBSan implicit-sign-change in serialize.h

2025-05-14 15:41:20 +02:00

signet.cpp

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

signet.h

…

span.h

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

streams.cpp

util: check that a file has been closed before ~AutoFile() is called

2025-06-16 15:33:19 +02:00

streams.h

Merge bitcoin/bitcoin#29307: util: explicitly close all AutoFiles that have been written

2025-07-03 15:37:44 -07:00

sync.cpp

scripted-diff: modernize outdated trait patterns - values

2025-02-21 10:43:01 +01:00

sync.h

Merge bitcoin/bitcoin#32829: threading: use correct mutex name in reverse_lock fatal error messages

2025-07-07 15:51:37 +01:00

threadsafety.h

thread-safety: modernize thread safety macros

2025-05-08 20:13:46 +00:00

tinyformat.h

refactor: Introduce struct to hold a runtime format string

2025-01-15 12:16:08 +01:00

torcontrol.cpp

config: allow setting -proxy per network

2025-05-13 12:09:40 +02:00

torcontrol.h

config: allow setting -proxy per network

2025-05-13 12:09:40 +02:00

txdb.cpp

refactor: Remove manual CDBBatch size estimation

2025-04-07 15:59:41 +02:00

txdb.h

kernel: Move default cache constants to caches

2025-01-15 15:44:55 +01:00

txgraph.cpp

txgraph: Track multiple potential would-be clusters in Trim (improvement)

2025-07-02 16:01:57 -04:00

txgraph.h

txgraph: Add ability to trim oversized clusters (feature)

2025-07-02 14:52:54 -04:00

txmempool.cpp

mempool: codify existing assumption about duplicate txids during removal

2025-06-10 22:10:05 +00:00

txmempool.h

mempool: use FeeFrac for calculating regular score

2025-06-24 02:49:31 +02:00

txorphanage.cpp

[fuzz] TxOrphanage::SanityCheck accounting

2025-02-07 13:55:57 -05:00

txorphanage.h

[fuzz] TxOrphanage::SanityCheck accounting

2025-02-07 13:55:57 -05:00

txrequest.cpp

scripted-diff: Bump copyright headers after include changes

2025-06-03 15:13:57 +02:00

txrequest.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

uint256.cpp

refactor: Remove SetHexDeprecated

2025-04-09 15:59:59 +01:00

uint256.h

refactor: Remove SetHexDeprecated

2025-04-09 15:59:59 +01:00

undo.h

…

validation.cpp

Merge bitcoin/bitcoin#30479: validation: Add eligible ancestors of reconsidered block to setBlockIndexCandidates

2025-07-09 16:55:43 -07:00

validation.h

Merge bitcoin/bitcoin#30479: validation: Add eligible ancestors of reconsidered block to setBlockIndexCandidates

2025-07-09 16:55:43 -07:00

validationinterface.cpp

thread-safety: fix annotations with REVERSE_LOCK

2025-06-16 18:09:14 +00:00

validationinterface.h

doc: fix BlockConnected incorrect comment

2025-07-07 18:14:52 +01:00

versionbits_impl.h

tests: refactor versionbits fuzz test

2025-01-21 00:38:03 +10:00

versionbits.cpp

scripted-diff: rename gbt_force and gbt_force_name

2025-04-30 14:51:21 +02:00

versionbits.h

scripted-diff: rename gbt_force and gbt_force_name

2025-04-30 14:51:21 +02:00

walletinitinterface.h

…