Andrew Chow 64f7a1940d

Merge bitcoin/bitcoin#25734: wallet, refactor: #24584 follow-ups ...

8cd21bb2799d37ed00dc9d0490bb5f5f1375932b refactor: improve readability for AttemptSelection (josibake)
f47ff717611182da27461e29b3c23933eb22fbce test: only run test for descriptor wallets (josibake)
0760ce0b9e646b6c86f4cc890c6ab78103a242ab test: add missing BOOST_ASSERT (josibake)
db09aec9378c5e8cc49c866fa50bfcb6c567d66c wallet: switch to new shuffle, erase, push_back (josibake)
b6b50b0f2b055d81c5d4ff9e21dd88cdc9a88ccb scripted-diff: Uppercase function names (josibake)
3f27a2adce12c6b0e7b43ba7c024331657bcf335 refactor: add new helper methods (josibake)
f5649db9d5e984ba7f376ccfd5b0a627f5c42402 refactor: add UNKNOWN OutputType (josibake)

Pull request description:

  This PR is to address follow-ups for #24584, specifically:

  * Remove redundant, hard-to-read code by adding a new `OutputType` and adding shuffle, erase, and push_back methods for `CoinsResult`
  * Add missing `BOOST_ASSERT` to unit test
  * Ensure functional test only runs if using descriptor wallets
  * Improve readability of `AttemptSelection` by removing triple-nested if statement

  Note for reviewers: commit `refactor: add new helper methods` should throw an "unused function warning"; the function is used in the next commit. Also, commit `wallet: switch to new shuffle, erase, push_back` will fail to compile, but this is fixed in the next commit with a scripted-diff. the commits are separate like this (code change then scripted-diff) to improve legibility.

ACKs for top commit:
  achow101:
    ACK 8cd21bb2799d37ed00dc9d0490bb5f5f1375932b
  aureleoules:
    ACK 8cd21bb2799d37ed00dc9d0490bb5f5f1375932b.
  LarryRuane:
    Concept, code review ACK 8cd21bb2799d37ed00dc9d0490bb5f5f1375932b
  furszy:
    utACK 8cd21bb2. Left a small, non-blocking, comment.

Tree-SHA512: a1bbc5962833e3df4f01a4895d8bd748cc4c608c3f296fd94e8afd8797b8d2e94e7bd44d598bd76fa5c9f5536864f396fcd097348fa0bb190a49a86b0917d60e

2022-08-16 20:00:19 -04:00

..

data

Add deserialize + CheckBlock benchmarks, and a full block hex

2016-11-09 11:27:59 -08:00

.gitignore

Ignore bench_bitcoin binary.

2015-10-06 17:46:12 +02:00

addrman.cpp

addrman: Use system time instead of adjusted network time

2022-07-30 11:04:09 +02:00

base58.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

bech32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bench_bitcoin.cpp

bench: Make all arguments -kebab-case

2022-05-17 11:32:25 +02:00

bench.cpp

Fixup option name in bench message

2022-05-25 00:26:38 -05:00

bench.h

bench: Add --sanity-check flag, use it in make check

2022-05-17 11:32:25 +02:00

block_assemble.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

ccoins_caching.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

chacha20.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

chacha_poly_aead.cpp

Do not run functions with necessary side-effects in assert()

2020-12-06 00:48:09 +00:00

checkblock.cpp

Add missing includes

2022-07-19 14:12:33 +02:00

checkqueue.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

coin_selection.cpp

wallet: switch to new shuffle, erase, push_back

2022-08-10 15:19:31 +02:00

crypto_hash.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.h

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

descriptors.cpp

bench: Add a benchmark for descriptor expansion

2022-08-05 12:04:43 +02:00

duplicate_inputs.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

examples.cpp

bench: Avoid deprecated use of volatile +=

2022-02-17 17:25:57 +01:00

gcs_filter.cpp

Update GCSFilter benchmarks

2022-05-22 14:17:15 +09:00

hashpadding.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

lockedpool.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

logging.cpp

bench: Add logging benchmark

2021-12-15 14:33:59 +01:00

mempool_eviction.cpp

bench: Use existing CTxMemPool in TestingSetup

2022-06-15 17:28:55 -04:00

mempool_stress.cpp

use testing setup mempool in ComplexMemPool bench

2022-05-30 16:00:41 -07:00

merkle_root.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.h

bench: update nanobench from 4.3.4 to 4.3.6

2021-09-21 11:46:01 +02:00

peer_eviction.cpp

scripted-diff: Rename touched member variables

2021-12-13 13:32:08 +01:00

poly1305.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

prevector.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

rollingbloom.cpp

refactor: Remove deduplication of data in rollingbloom bench

2022-04-06 13:57:31 +01:00

rpc_blockchain.cpp

move-mostly: Make fHavePruned a BlockMan member

2022-04-19 14:34:56 -04:00

rpc_mempool.cpp

bench/rpc_mempool: Create ChainTestingSetup, use its CTxMemPool

2022-06-15 17:28:55 -04:00

strencodings.cpp

bench: Adds a benchmark for HexStr

2022-04-17 14:29:52 +02:00

util_time.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

verify_script.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

wallet_balance.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

wallet_loading.cpp

refactor: Replace BResult with util::Result

2022-08-03 07:33:01 -04:00