cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 03:01:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
merge-script 2bcb3f6464
Merge bitcoin/bitcoin#34112: rpc: [mempool] Remove erroneous Univalue integral casts 
fab1f4b800d007bd4756b2519c64e1506ffe0d6c rpc: [mempool] Remove erroneous Univalue integral casts (MarcoFalke)

Pull request description:

  Casting without reason can only be confusing (because it is not needed), or wrong (because it does the wrong thing).

  For example, the added test that adds a positive chunk prioritization will fail:

  ```
  AssertionError: not(-1.94936096 == 41.000312)
  ```

  Fix all issues by removing the erroneous casts, and by adding a test to check against regressions.

ACKs for top commit:
  rkrux:
    tACK fab1f4b800d007bd4756b2519c64e1506ffe0d6c
  pablomartin4btc:
    ACK fab1f4b800d007bd4756b2519c64e1506ffe0d6c
  glozow:
    ACK fab1f4b800d007bd4756b2519c64e1506ffe0d6c

Tree-SHA512: b03c888ec07a8bdff25f7ded67f253b2a8edd83adf08980416e2ac8ac1b36ad952cc5828be833d19f64a55abab62d7a1c6f181bc5f1388ed08cc178b4aaec6ee
2025-12-29 07:16:39 -08:00
..
bench
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
common
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
compat
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
consensus
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crc32c
…
crypto
Merge bitcoin/bitcoin#33810: ci: Add IWYU job
2025-12-22 17:38:50 +00:00
index
Merge bitcoin/bitcoin#32997: index: Deduplicate HashKey / HeightKey handling
2025-12-27 16:18:34 +00:00
init
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
interfaces
kernel: Move BlockInfo to a kernel file
2025-12-21 10:24:36 +01:00
ipc
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
kernel
Merge bitcoin/bitcoin#33891: kernel: Expose reusable PrecomputedTransactionData in script validation
2025-12-27 16:20:43 +00:00
leveldb
…
logging
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
minisketch
…
node
Merge bitcoin/bitcoin#33353: log: show reindex progress in ImportBlocks
2025-12-22 08:12:03 -08:00
policy
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
primitives
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
qt
scripted-diff: refactor: wallet: Delete IsCrypted
2025-12-24 11:09:15 -08:00
rpc
Merge bitcoin/bitcoin#34112: rpc: [mempool] Remove erroneous Univalue integral casts
2025-12-29 07:16:39 -08:00
script
Merge bitcoin/bitcoin#33636: wallet: Expand MuSig test coverage and follow-ups
2025-12-22 17:14:35 -08:00
secp256k1
…
support
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
test
Merge bitcoin/bitcoin#34119: contrib: remove copyright_header.py
2025-12-29 07:03:02 -08:00
univalue
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
util
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
wallet
Merge bitcoin/bitcoin#34113: refactor: [rpc] Remove confusing and brittle integral casts
2025-12-27 16:35:21 +00:00
zmq
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
.clang-format
iwyu, clang-format: Sort includes
2025-12-17 20:29:36 +00:00
.clang-tidy
refactor: enable readability-container-contains clang-tidy rule
2025-12-18 22:38:02 +01:00
addrdb.cpp
…
addrdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
addrman.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
arith_uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
arith_uint256.h
…
attributes.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: revert accidentally removed copyright header
2025-12-18 16:07:31 +01:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#33192: refactor: unify container presence checks
2025-12-17 16:17:29 -05:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoin.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockencodings.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockencodings.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.h
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
chainparams.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparams.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparamsbase.cpp
…
chainparamsbase.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparamsseeds.h
…
checkqueue.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
clientversion.cpp
refactor: Avoid -W*-whitespace in git archive
2025-11-13 09:33:36 +01:00
clientversion.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cluster_linearize.h
clusterlin: drop support for improvable chunking (simplification)
2025-12-18 16:01:31 -05:00
CMakeLists.txt
cmake: Make codegen target dependent on generate_build_info
2025-12-17 20:29:03 +00:00
coins.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
coins.h
validation: don't reallocate cache for short-lived CCoinsViewCache
2025-11-02 21:40:16 +01:00
compressor.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
compressor.h
…
core_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
core_memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
core_read.cpp
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
core_write.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.h
…
dbwrapper.cpp
refactor: Add Chainstate::StoragePath() method
2025-12-12 06:49:59 -04:00
dbwrapper.h
refactor: Add Chainstate::StoragePath() method
2025-12-12 06:49:59 -04:00
deploymentinfo.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentinfo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
dummywallet.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
external_signer.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
external_signer.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
flatfile.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
flatfile.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
httprpc.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
httpserver.cpp
libevent: separate log statements per level
2025-12-13 12:48:27 +01:00
httpserver.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
i2p.cpp
log: Remove brittle and confusing LogPrintLevel
2025-12-13 13:43:24 +01:00
i2p.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
indirectmap.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.cpp
Merge bitcoin/bitcoin#33192: refactor: unify container presence checks
2025-12-17 16:17:29 -05:00
init.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key_io.cpp
…
key_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
…
key.h
…
logging.cpp
log: Use __func__ for -logsourcelocations
2025-12-17 18:35:49 +01:00
logging.h
log: Use __func__ for -logsourcelocations
2025-12-17 18:35:49 +01:00
mapport.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mapport.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
merkleblock.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
musig.cpp
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
musig.h
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_processing.cpp
Merge bitcoin/bitcoin#33192: refactor: unify container presence checks
2025-12-17 16:17:29 -05:00
net_processing.h
Add util::Expected (std::expected)
2025-12-06 13:06:21 +01:00
net_types.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
Merge bitcoin/bitcoin#33192: refactor: unify container presence checks
2025-12-17 16:17:29 -05:00
net.h
net: Cache -capturemessages setting
2025-12-10 06:51:47 +10:00
netaddress.cpp
…
netaddress.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
netbase.cpp
Merge bitcoin/bitcoin#34033: scripted-diff: Unify error and warning log formatting
2025-12-11 09:00:18 -08:00
netbase.h
refactor: unify container presence checks - trivial counts
2025-12-03 13:36:58 +01:00
netgroup.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
netgroup.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
netmessagemaker.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
outputtype.cpp
…
outputtype.h
…
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
pow.h
…
prevector.h
refactor: Prefer <=> over multiple relational operators
2025-11-03 14:39:50 +01:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
protocol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
psbt.cpp
refactor: unify container presence checks - trivial counts
2025-12-03 13:36:58 +01:00
psbt.h
refactor: unify container presence checks - trivial counts
2025-12-03 13:36:58 +01:00
pubkey.cpp
…
pubkey.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
random.cpp
…
random.h
…
randomenv.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
randomenv.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rest.cpp
rest: reformat uri_prefixes initializer list
2025-12-14 10:04:37 +01:00
rest.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
semaphore_grant.h
…
serialize.h
refactor: Return uint64_t from GetSerializeSize
2025-10-30 17:51:53 +01:00
signet.cpp
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
signet.h
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
span.h
…
streams.cpp
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
streams.h
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
sync.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
sync.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
threadsafety.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
tinyformat.h
…
torcontrol.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
torcontrol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txdb.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txgraph.cpp
clusterlin: drop support for improvable chunking (simplification)
2025-12-18 16:01:31 -05:00
txgraph.h
txgraph: drop move assignment operator
2025-11-25 07:36:50 -05:00
txmempool.cpp
Fix compilation for old Boost versions
2025-12-18 22:38:02 +01:00
txmempool.h
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
txrequest.cpp
Fix compilation for old Boost versions
2025-12-18 22:38:02 +01:00
txrequest.h
…
uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
uint256.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
undo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validation.cpp
Merge bitcoin/bitcoin#33892: policy: allow <minrelay txns in package context if paid for by cpfp
2025-12-27 16:13:19 +00:00
validation.h
test: Wrap validation functions with TestChainstateManager
2025-12-16 11:25:46 -05:00
validationinterface.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validationinterface.h
refactor: Convert ChainstateRole enum to struct
2025-12-12 06:49:59 -04:00
versionbits_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
versionbits.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
versionbits.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
walletinitinterface.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00