fanquake da67b75c5c

Merge bitcoin/bitcoin#22903: Enable clang-tidy bugprone-argument-comment and fix violations ...

fa57fa1a2e764792b873998ddf38db2ac061dcb6 Enable clang-tidy bugprone-argument-comment and fix violations (MarcoFalke)

Pull request description:

  Named arguments can be dangerous when they are wrong, because they are not enforced by the compiler. Currently there are only minor typos, no actual bugs.

  Fix the typos and add the `.clang-tidy` file to make it easier to find them in the future.

ACKs for top commit:
  practicalswift:
    cr ACK fa57fa1a2e764792b873998ddf38db2ac061dcb6
  fanquake:
    ACK fa57fa1a2e764792b873998ddf38db2ac061dcb6

Tree-SHA512: b66f01e0a1e77e56ed8454002176df660cc2cc0947a90785aa33cc5b8003a1f99fd8b2f8f89f2a0bf180ff2c42c031d69e669d127bb557b879c17975275a220b

2021-09-09 11:33:58 +08:00

..

test

Enable clang-tidy bugprone-argument-comment and fix violations

2021-09-07 09:11:10 +02:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

…

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

Add waste metric calculation function

2021-08-27 12:46:06 -04:00

coinselection.h

Add waste metric calculation function

2021-08-27 12:46:06 -04:00

context.cpp

…

context.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

…

db.cpp

Merge bitcoin/bitcoin#21944: wallet: Fix issues when walletdir is root directory

2021-06-09 22:53:36 +12:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Allow the long term feerate to be configured, default of 10 sat/vb

2021-08-27 12:46:04 -04:00

interfaces.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

ismine.h

…

load.cpp

Enable clang-tidy bugprone-argument-comment and fix violations

2021-09-07 09:11:10 +02:00

load.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

receive.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

receive.h

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

rpcdump.cpp

wallet: use PACKAGE_NAME instead of "Bitcoin" in rpcdump

2021-08-16 16:04:53 +08:00

rpcwallet.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors

2021-08-09 14:45:12 +12:00

scriptpubkeyman.h

refactor: Remove unused KeyIDHasher

2021-08-22 17:31:58 +02:00

spend.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

spend.h

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite PRAGMA assignments

2021-05-17 17:22:36 +02:00

sqlite.h

…

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

wallet.cpp

wallet: AddWalletDescriptor requires cs_wallet lock

2021-09-03 18:30:01 +01:00

wallet.h

wallet: AddWalletDescriptor requires cs_wallet lock

2021-09-03 18:30:01 +01:00

walletdb.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

walletdb.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

wallettool.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

wallettool.h

…

walletutil.cpp

scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls

2021-05-24 10:29:58 +02:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00