cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-09 23:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/test/util
History
MarcoFalke f13e03cda2
Merge #20584: Declare de facto const reference variables/member functions as const 
31b136e5802e1b1e5f9a9589736afe0652f34da2 Don't declare de facto const reference variables as non-const (practicalswift)
1c65c075ee4c7f98d9c1fac5ed7576b96374d4e9 Don't declare de facto const member functions as non-const (practicalswift)

Pull request description:

  _Meta: This is the second and final part of the `const` refactoring series (part one: #20581). **I promise: no more refactoring PRs from me in a while! :)** I'll now go back to focusing on fuzzing/hardening!_

  Changes in this PR:
  * Don't declare de facto const member functions as non-const
  * Don't declare de facto const reference variables as non-const

  Awards for finding candidates for the above changes go to:
  * `clang-tidy`'s [`readability-make-member-function-const`](https://clang.llvm.org/extra/clang-tidy/checks/readability-make-member-function-const.html)  check ([list of `clang-tidy` checks](https://clang.llvm.org/extra/clang-tidy/checks/list.html))
  * `cppcheck`'s `constVariable` check ([list of `cppcheck` checks](https://sourceforge.net/p/cppcheck/wiki/ListOfChecks/))

  See #18920 for instructions on how to analyse Bitcoin Core using Clang Static Analysis, `clang-tidy` and `cppcheck`.

ACKs for top commit:
  ajtowns:
    ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2
  jonatack:
    ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2
  theStack:
    ACK 31b136e5802e1b1e5f9a9589736afe0652f34da2 ❄️

Tree-SHA512: f58f8f00744219426874379e9f3e9331132b9b48e954d24f3a85cbb858fdcc98009ed42ef7e7b4619ae8af9fc240a6d8bfc1c438db2e97b0ecd722a80dcfeffe
2021-01-07 09:05:09 +01:00
..
blockfilter.cpp
…
blockfilter.h
…
logging.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
logging.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
mining.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
mining.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net.cpp
net: Treat raw message bytes as uint8_t
2020-11-20 15:11:21 +01:00
net.h
net: Treat raw message bytes as uint8_t
2020-11-20 15:11:21 +01:00
README.md
…
setup_common.cpp
Merge #20584: Declare de facto const reference variables/member functions as const
2021-01-07 09:05:09 +01:00
setup_common.h
Merge #20584: Declare de facto const reference variables/member functions as const
2021-01-07 09:05:09 +01:00
str.cpp
…
str.h
[test] move string helper functions into test library
2019-11-25 01:33:17 +01:00
transaction_utils.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
transaction_utils.h
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
validation.cpp
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
validation.h
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
wallet.cpp
Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
2020-01-23 16:34:28 -05:00
wallet.h
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).