Ava Chow 9f1aa88d4d

Merge bitcoin/bitcoin#30884: streams: cache file position within AutoFile ...

a240e150e837b5a95ed19765a2e8b7c5b6013f35 streams: remove AutoFile::Get() entirely (Pieter Wuille)
e624a9bef16b6335fd119c10698352b59bf2930a streams: cache file position within AutoFile (Pieter Wuille)

Pull request description:

  Fixes #30833.

  Instead of relying on frequent `ftell` calls (which appear to cause a significant slowdown on some systems) in XOR-enabled `AutoFile`s, cache the file position within `AutoFile` itself.

ACKs for top commit:
  achow101:
    ACK a240e150e837b5a95ed19765a2e8b7c5b6013f35
  davidgumberg:
    untested reACK a240e150e8
  theStack:
    Code-review ACK a240e150e837b5a95ed19765a2e8b7c5b6013f35

Tree-SHA512: fd3681edc018afaf955dc7a41a0c953ca80d46c1129e3c5b306c87c95aae93b2fe7b900794eb8b6f10491f9211645e7939918a28838295e6873eb226fca7006f

2024-09-16 23:09:16 -04:00

..

any.h

refactor: Split util::AnyPtr into its own file

2023-05-20 12:03:33 +02:00

asmap.cpp

streams: cache file position within AutoFile

2024-09-13 07:35:41 -04:00

asmap.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

batchpriority.cpp

refactor: Move ScheduleBatchPriority to its own file

2023-05-20 12:03:30 +02:00

batchpriority.h

refactor: Move ScheduleBatchPriority to its own file

2023-05-20 12:03:30 +02:00

bip32.cpp

Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h

2023-05-08 13:31:28 -04:00

bip32.h

Switch hardened derivation marker to h in descriptors

2023-04-04 18:33:08 +02:00

bitdeque.h

refactor: Fix "error C2248: cannot access private member" on MSVC

2024-04-28 07:11:24 +01:00

bitset.h

util: add BitSet

2024-06-10 07:54:48 -04:00

bytevectorhash.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

bytevectorhash.h

…

chaintype.cpp

testnet: Introduce Testnet4

2024-08-06 01:38:10 +02:00

chaintype.h

testnet: Introduce Testnet4

2024-08-06 01:38:10 +02:00

check.cpp

scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes

2024-05-01 08:33:04 +02:00

check.h

Export assert from util/check.h

2023-11-24 13:11:36 +01:00

CMakeLists.txt

cmake: Build bitcoin_util static library

2024-08-16 19:27:38 +01:00

epochguard.h

…

exception.cpp

refactor: Extract util/exception from util/system

2023-03-13 17:09:47 +01:00

exception.h

refactor: Extract util/exception from util/system

2023-03-13 17:09:47 +01:00

fastrange.h

…

feefrac.cpp

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

feefrac.h

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

fs_helpers.cpp

util: add perm string helper functions

2024-06-27 14:55:10 +01:00

fs_helpers.h

util: add perm string helper functions

2024-06-27 14:55:10 +01:00

fs.cpp

Add tests for C++20 std::u8string

2023-12-11 17:42:05 +01:00

fs.h

refactor: Rename fs::path::u8string() to fs::path::utf8string()

2023-12-14 16:22:40 +01:00

golombrice.h

…

hash_type.h

…

hasher.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

hasher.h

Bump g++ minimum supported version to 10

2023-10-30 15:12:26 +01:00

insert.h

refactor: Split util::insert into its own file

2023-05-20 12:03:31 +02:00

macros.h

…

moneystr.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

moneystr.h

…

overflow.h

…

overloaded.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

rbf.cpp

…

rbf.h

…

readwritefile.cpp

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

readwritefile.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

result.h

refactor: Avoid copying util::Result values

2024-04-25 16:08:24 -04:00

serfloat.cpp

…

serfloat.h

…

signalinterrupt.cpp

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

signalinterrupt.h

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

sock.cpp

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

sock.h

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

strencodings.cpp

util: remove unused IsHexNumber

2024-08-23 13:53:40 +01:00

strencodings.h

util: Add consteval ""_hex[_v][_u8] literals

2024-08-28 19:09:51 +02:00

string.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

string.h

util: Use compile-time check for FatalErrorf

2024-09-12 15:01:20 +02:00

subprocess.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

syserror.cpp

scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes

2024-05-01 08:33:04 +02:00

syserror.h

Show descriptive error messages when FileCommit fails

2023-06-30 09:48:21 -04:00

task_runner.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

thread.cpp

refactor: Extract util/exception from util/system

2023-03-13 17:09:47 +01:00

thread.h

…

threadinterrupt.cpp

…

threadinterrupt.h

util: Add SignalInterrupt class and use in shutdown.cpp

2023-06-28 09:49:28 +02:00

threadnames.cpp

build: remove --enable-threadlocal

2024-05-21 10:29:51 +01:00

threadnames.h

util: avoid using thread_local variable that has a destructor

2024-05-16 18:16:46 +02:00

time.cpp

refactor: Use chrono type for g_mock_time

2024-04-15 13:34:31 +02:00

time.h

Revert "time: add runtime sanity check"

2024-03-18 16:01:08 +01:00

tokenpipe.cpp

scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes

2024-05-01 08:33:04 +02:00

tokenpipe.h

…

trace.h

scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes

2024-05-01 08:33:04 +02:00

transaction_identifier.h

refactor: remove TxidFromString

2024-07-31 16:47:39 +01:00

translation.h

util: Catch translation string errors at compile time

2024-07-10 09:40:47 +02:00

types.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

ui_change_type.h

…

vecdeque.h

utils: add missing include

2024-06-11 16:28:11 +00:00

vector.h

chainparams: add blockhash to AssumeutxoData

2023-09-30 06:38:47 -04:00