cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 11:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 280a7777d3
Merge bitcoin/bitcoin#24235: validation: use stronger EXCLUSIVE_LOCKS_REQUIRED() 
99de8068cd08ecc2ad5dfe603bf3c2cc5b8b33aa validation: use stronger EXCLUSIVE_LOCKS_REQUIRED() (Vasil Dimov)

Pull request description:

  https://github.com/bitcoin/bitcoin/pull/24103 added annotations to
  denote that the callers of `CChainState::ActivateBestChain()` and
  `CChainState::InvalidateBlock()` must not own `m_chainstate_mutex` at
  the time of the call.

  Replace the added `LOCKS_EXCLUDED()` with a stronger
  `EXCLUSIVE_LOCKS_REQUIRED()`, see
  https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#negative for the
  difference between both.

ACKs for top commit:
  hebasto:
    ACK 99de8068cd08ecc2ad5dfe603bf3c2cc5b8b33aa.
  jonatack:
    ACK 99de8068cd08ecc2ad5dfe603bf3c2cc5b8b33aa. Tested with Debian clang version 13.0.1.  Reproduced hebasto's results. Verified that  `LoadExternalBlockFile()` needs the annotation added here.

Tree-SHA512: 59640d9ad472cdb5066ecde89cc0aff8632a351fc030f39bb43800d2c856fb1aed3576e4134212d32be161b18780f06dc5066ac71df7f7cd69e3f21f886e1542
2022-02-08 15:53:49 +01:00
..
bench
bench: Represents paths with fs::path instead of std::string
2022-02-04 09:33:41 -05:00
common
refactor: Fixup uint64_t-cast style in touched line
2022-02-01 11:19:18 +01:00
compat
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
config
…
consensus
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
crc32c
…
crypto
doc: Fix typos pointed out by lint-spelling
2022-01-30 08:59:10 -03:00
index
Require CBlockIndex::GetBlockPos() to hold mutex cs_main
2022-01-25 20:43:12 +01:00
init
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
interfaces
Remove unused checkFinalTx
2022-01-25 10:16:06 +01:00
ipc
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
leveldb
…
logging
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
minisketch
Update minisketch subtree to latest upstream
2022-02-04 22:47:49 +08:00
node
refactor: Make MessageBoxFlags enum underlying type unsigned
2022-01-31 09:27:12 +01:00
policy
[validation] better handle errors in SubmitPackage
2022-01-17 12:24:43 +00:00
primitives
Extract CTxIn::MAX_SEQUENCE_NONFINAL constant
2022-01-26 15:10:44 +01:00
qt
Merge bitcoin-core/gui#524: Replace int with std::chrono in for the timer->setInterval() argument
2022-02-04 12:39:07 +02:00
rpc
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
script
Fix unsigned integer overflow in tapscript validation weight calculation
2022-01-31 16:39:40 +01:00
secp256k1
Update secp256k1 subtree to latest upstream master
2021-12-15 09:19:50 -05:00
support
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
test
Merge bitcoin/bitcoin#24237: test: Avoid testing negative block heights
2022-02-07 14:03:56 +01:00
univalue
Update univalue subtree to latest upstream
2021-10-11 20:45:56 +08:00
util
Merge bitcoin/bitcoin#24266: util: Avoid buggy std::filesystem:::create_directories() call
2022-02-08 15:46:34 +01:00
wallet
Re-enable walletinit_verify_walletdir_no_trailing2 test disabled in #20744
2022-02-04 09:10:19 -05:00
zmq
zmq: Fix implicit-integer-sign-change
2022-01-31 16:53:12 +01:00
.clang-format
Use c++17 in clang-format
2021-11-12 11:46:34 +01:00
.clang-tidy
…
addrdb.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
addrdb.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
addrman_impl.h
test: Remove unused AddrManTest class
2021-12-28 21:54:51 +01:00
addrman.cpp
Merge bitcoin/bitcoin#23826: test: Make AddrMan unit tests use public interface, extend coverage
2022-01-04 23:08:11 +08:00
addrman.h
Merge bitcoin/bitcoin#23826: test: Make AddrMan unit tests use public interface, extend coverage
2022-01-04 23:08:11 +08:00
arith_uint256.cpp
Fix implicit-integer-sign-change in arith_uint256
2022-01-13 15:56:59 +01:00
arith_uint256.h
…
attributes.h
…
banman.cpp
Fix race condition for SetBannedSetDirty() calls
2022-01-28 19:27:25 +00:00
banman.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
base58.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
base58.h
…
bech32.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bech32.h
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#24139: Avoid unsigned integer overflow in bitcoin-tx
2022-01-28 15:26:24 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Add src/wallet/* code to wallet:: namespace
2022-01-06 22:14:16 -05:00
bitcoind-res.rc
…
bitcoind.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
scripted-diff: rename MapIntoRange to FastRange64
2022-01-06 11:29:55 -05:00
blockfilter.h
…
chain.cpp
Avoid integer sanitizer warnings in chain.o
2022-01-25 10:49:46 +01:00
chain.h
Merge bitcoin/bitcoin#24146: Avoid integer sanitizer warnings in chain.o
2022-01-31 09:23:54 +01:00
chainparams.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparams.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.h
…
chainparamsseeds.h
p2p, contrib: update i2p hardcoded seeds
2022-01-26 12:58:23 +01:00
checkqueue.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
clientversion.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
clientversion.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
coins.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
coins.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compat.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compressor.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compressor.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_io.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_memusage.h
…
core_read.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_write.cpp
transaction decoding infer output descriptors
2022-01-26 09:56:51 +08:00
cuckoocache.h
Add FastRange32 function and use it throughout the codebase
2022-01-07 13:37:47 -05:00
dbwrapper.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
dbwrapper.h
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
deploymentinfo.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentinfo.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
dummywallet.cpp
Add src/wallet/* code to wallet:: namespace
2022-01-06 22:14:16 -05:00
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
flatfile.h
…
fs.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
fs.h
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
hash.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
hash.h
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
httprpc.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httprpc.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httpserver.cpp
Merge bitcoin/bitcoin#23607: rpc: Pass const char* to evhttp_connection_get_peer for new libevent
2022-01-13 18:35:25 +01:00
httpserver.h
…
i2p.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
i2p.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#24250: Update translations for 0.23 string freeze
2022-02-04 09:25:36 +01:00
init.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
key_io.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key_io.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
logging.cpp
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
logging.h
refactor: replace boost::filesystem with std::filesystem
2022-02-03 18:35:52 +08:00
Makefile.am
[moveonly] Move MapIntoRange() to separate util/fastrange.h
2022-01-06 11:27:06 -05:00
Makefile.bench.include
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
2021-12-20 10:53:01 -05:00
Makefile.crc32c.include
…
Makefile.leveldb.include
build: remove build stubs for external leveldb
2021-10-15 01:02:45 +00:00
Makefile.minisketch.include
build: add minisketch build file and include it
2021-10-21 09:37:30 +08:00
Makefile.qt_locale.include
…
Makefile.qt.include
Merge bitcoin/bitcoin#22151: build: Follow Transifex docs to prepare XLIFF source
2022-02-04 13:43:36 +01:00
Makefile.qttest.include
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
2021-12-20 10:53:01 -05:00
Makefile.test_fuzz.include
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
2021-12-20 10:53:01 -05:00
Makefile.test_util.include
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
2021-12-20 10:53:01 -05:00
Makefile.test.include
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a
2021-12-20 10:53:01 -05:00
Makefile.univalue.include
Integrate univalue into our buildsystem
2021-10-11 20:46:25 +08:00
mapport.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_processing.cpp
Remove/inline ReadRawBlockFromDisk(block_data, pindex, message_start)
2022-01-25 20:43:37 +01:00
net_processing.h
Merge bitcoin/bitcoin#23706: rpc: getblockfrompeer followups
2022-01-25 18:48:41 +01:00
net_types.cpp
net: Drop only invalid entries when reading banlist.json
2021-12-14 18:58:45 +01:00
net_types.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net.cpp
Merge bitcoin/bitcoin#23604: Use Sock in CNode
2022-02-04 09:24:17 +01:00
net.h
Merge bitcoin/bitcoin#23604: Use Sock in CNode
2022-02-04 09:24:17 +01:00
netaddress.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netaddress.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netbase.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netbase.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
outputtype.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
protocol.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
psbt.cpp
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
psbt.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pubkey.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pubkey.h
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
random.cpp
scripted-diff: replace PoissonNextSend with GetExponentialRand
2022-01-13 15:55:01 +01:00
random.h
doc: Fix typos pointed out by lint-spelling
2022-01-30 08:59:10 -03:00
randomenv.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
randomenv.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rest.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
reverse_iterator.h
…
scheduler.cpp
scripted-diff: rename m_cs_callbacks_pending -> m_callbacks_mutex
2022-01-14 13:25:23 +01:00
scheduler.h
refactor: replace RecursiveMutex m_callbacks_mutex with Mutex
2022-01-14 13:27:41 +01:00
serialize.h
Remove unused char serialize
2022-01-02 11:52:11 +01:00
shutdown.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
shutdown.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
span.h
span: Add BytePtr helper
2022-01-02 11:13:40 +01:00
streams.h
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
sync.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
sync.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
threadsafety.h
…
timedata.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
torcontrol.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txdb.cpp
Replace lock with thread safety annotation in CBlockTreeDB::LoadBlockIndexGuts()
2022-01-28 20:52:53 +01:00
txdb.h
Replace lock with thread safety annotation in CBlockTreeDB::LoadBlockIndexGuts()
2022-01-28 20:52:53 +01:00
txmempool.cpp
Merge bitcoin/bitcoin#21464: Mempool Update Cut-Through Optimization
2022-01-25 11:20:18 +08:00
txmempool.h
Merge bitcoin/bitcoin#21464: Mempool Update Cut-Through Optimization
2022-01-25 11:20:18 +08:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
undo.h
…
validation.cpp
Fix unsigned integer overflow in LoadMempool
2022-02-01 19:40:58 +01:00
validation.h
validation: use stronger EXCLUSIVE_LOCKS_REQUIRED()
2022-02-02 14:00:30 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC
2022-01-28 08:46:03 +01:00
versionbits.h
Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC
2022-01-28 08:46:03 +01:00
walletinitinterface.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
warnings.cpp
…
warnings.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00