Andrew Chow 25d045a9ec

Merge bitcoin/bitcoin#24225: wallet: Add sanity checks to DiscourageFeeSniping ...

fa8e76bb9002a126b3645bd9533c282f5dfff111 wallet: Add sanity checks to AntiFeeSnipe (MarcoFalke)

Pull request description:

  I added those sanity checks as part of implementing BIP 326, but I think they make sense on their own. The checks require the transaction to be passed in to `DiscourageFeeSniping`. Also, replace `(int)locktime` cast with the equivalent `int(locktime)` cast.

ACKs for top commit:
  chris-belcher:
    ACK fa8e76bb90
  S3RK:
    Code review ACK fa8e76bb9002a126b3645bd9533c282f5dfff111
  achow101:
    ACK fa8e76bb9002a126b3645bd9533c282f5dfff111
  w0xlt:
    Code Review ACK fa8e76bb90

Tree-SHA512: 6fe37c85f074851ef09cae8addcb836257089290fecec515c129c3180e9ccb64740aaac76043af10ce7c213e5001568ca6b4b62ae9631f0994ed676b07118074

2022-03-14 10:31:25 +00:00

..

rpc

Merge bitcoin/bitcoin#24505: wallet: Add a deprecation warning for newly created legacy wallets

2022-03-14 08:37:46 +01:00

test

blockstorage: Make m_block_index own CBlockIndex's

2022-02-22 11:52:19 -05:00

bdb.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

bdb.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

wallet: add input weights to CCoinControl

2022-01-24 11:23:31 -05:00

coinselection.cpp

[wallet] assert BnB internally calculated waste is the same as GetSelectionWaste()

2022-03-11 12:22:34 +00:00

coinselection.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

context.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

db.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

db.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

dump.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

dump.h

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

external_signer_scriptpubkeyman.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

interfaces.cpp

interfaces: Remove unused is_final

2022-01-14 11:28:45 +01:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

load.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

receive.cpp

wallet: Avoid dropping confirmed coins

2022-01-25 10:15:12 +01:00

receive.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

salvage.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

salvage.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

Merge bitcoin/bitcoin#24225: wallet: Add sanity checks to DiscourageFeeSniping

2022-03-14 10:31:25 +00:00

spend.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite blob binding

2022-03-06 20:43:16 +01:00

sqlite.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

wallet: add GetWitnessHash()

2022-02-01 08:44:51 -03:00

wallet.cpp

wallet: Add a deprecation warning for newly created legacy wallets

2022-03-10 07:32:02 -05:00

wallet.h

wallet: Allow user specified input size to override

2022-01-24 11:23:31 -05:00

walletdb.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

walletdb.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

wallettool.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00