Andrew Chow 19d1ba1b41

Merge bitcoin/bitcoin#28787: init: completely remove -zapwallettxes (remaining hidden option) ...

5039c346ca87d6112ea1eb124bdc622ba9e9a513 init: completely remove `-zapwallettxes` (remaining hidden option) (Sebastian Falbesoner)

Pull request description:

  The `-zapwallettxes` functionality has been removed in v0.21.0 (see commit 3340dbadd38f5624642cf0e14dddbe6f83a3863b / PR #19671), with the parameter being kept as hidden option, to inform users via an exit error that `abandontransaction` should be used instead.

  As any guides that still suggest to use `-zapwallettxes` would refer to a Bitcoin Core version that is EOL since many years (i.e. <= v0.20.x), it is highly unlikely that the error caused by the option is still relevant for any user, hence it seems fine to remove it now.

ACKs for top commit:
  achow101:
    ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513
  BrandonOdiwuor:
    ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513
  fanquake:
    ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513

Tree-SHA512: e3ccc6918e0f8fa68dbd1a7ec4999cc2a44e28038711919fcddaf0727648c73a9ba0fb77674317147592a113fad20755d4e727f48176bc17b048fbdebad2d6c9

2023-11-08 10:53:42 -05:00

..

rpc

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

test

refactor: Add LIFETIMEBOUND to all (w)txid getters

2023-10-27 13:01:42 +02:00

bdb.cpp

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

…

coincontrol.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: Remove unused C-style casts

2023-07-24 15:32:00 +02:00

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

wallet: Add GetPrefixCursor to DatabaseBatch

2023-06-01 13:09:08 -04:00

dump.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

init: completely remove -zapwallettxes (remaining hidden option)

2023-11-03 20:00:44 +01:00

interfaces.cpp

build: Bump minimum supported Clang to clang-13

2023-10-24 18:52:00 +02:00

load.cpp

scripted-diff: move settings to common namespace

2023-05-30 17:26:51 +02:00

load.h

…

receive.cpp

…

receive.h

…

salvage.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

salvage.h

…

scriptpubkeyman.cpp

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#28508: refactor: Remove SER_GETHASH, hard-code client version in CKeyPool serialize

2023-10-02 12:33:54 +02:00

spend.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

spend.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

sqlite.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

sqlite.h

wallet: sqlite: force sqlite3.h to be included by the cpp files

2023-07-06 19:53:44 +00:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Merge bitcoin/bitcoin#28546: wallet: prevent bugs from invalid transaction heights with asserts, comments, and refactoring

2023-11-07 11:29:29 -05:00

types.h

…

wallet.cpp

wallet: Add asserts to detect unset transaction height values

2023-10-23 17:35:36 -04:00

wallet.h

wallet: Add asserts to detect unset transaction height values

2023-10-23 17:35:36 -04:00

walletdb.cpp

Move CScriptID to script.{h/cpp}

2023-08-14 17:38:27 -04:00

walletdb.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00