Ava Chow f999c3775c

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets ...

86e1111239cdb39dd32cfb5178653c608fa30515 test: verify node skips loading legacy wallets during startup (furszy)
9f94de5bb54ff683bd4d3a7723617b34a4706bb6 wallet: init, don't error out when loading legacy wallets (furszy)

Pull request description:

  Instead of failing during initialization and shutting down the app when encountering a legacy wallet, skip loading the wallet and notify the user accordingly.

  This allows users to access migration functionalities without needing to manually remove the wallet from settings.json or resort to using the bitcoin-wallet utility.

  This means that GUI users will be able to use the migration button, and bitcoin-cli users will be able to call the migratewallet RPC directly after init.

ACKs for top commit:
  achow101:
    ACK 86e1111239cdb39dd32cfb5178653c608fa30515
  w0xlt:
    ACK 86e1111239

Tree-SHA512: 85d594a503ee7a833a23754b71b6ba4869ca34ed802c9ac0cd7b2fa56978f5fcad84ee4bd3acdcc61cf8e7f08f0789336febc5d76beae1eebf7bd51462512b78

2025-06-02 13:31:35 -07:00

..

rpc

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

test

Merge bitcoin/bitcoin#32475: wallet: Use util::Error throughout AddWalletDescriptor instead of returning nullptr for some errors

2025-05-21 14:24:39 +01:00

CMakeLists.txt

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

coincontrol.cpp

…

coincontrol.h

[wallet, rpc]: add max_tx_weight to tx funding options

2024-06-27 15:31:21 +01:00

coinselection.cpp

Remove unused variable assignment

2024-12-13 21:00:07 -06:00

coinselection.h

Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2)

2024-07-17 18:27:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

crypter.h

wallet: refactor: introduce CMasterKey::DEFAULT_DERIVE_ITERATIONS constant

2025-01-27 18:11:05 +01:00

db.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

db.h

wallet: init, don't error out when loading legacy wallets

2025-05-15 15:14:29 -04:00

dump.cpp

refactor: Use ToIntegral in CreateFromDump

2025-05-15 19:34:08 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: change FillPSBT to take sighash as optional

2025-05-14 14:00:43 -07:00

external_signer_scriptpubkeyman.h

wallet: change FillPSBT to take sighash as optional

2025-05-14 14:00:43 -07:00

feebumper.cpp

Merge bitcoin/bitcoin#31622: psbt: add non-default sighash types to PSBTs and unify sighash type match checking

2025-05-21 10:02:49 +01:00

feebumper.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

fees.cpp

…

fees.h

…

init.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

interfaces.cpp

Merge bitcoin/bitcoin#32459: qt: drop unused watch-only functionality

2025-05-21 10:13:00 +01:00

load.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

load.h

wallet: Remove unnecessary database Close step on shutdown

2025-05-14 11:03:57 -07:00

migrate.cpp

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

migrate.h

wallet: Remove unused db functions

2025-05-06 16:53:16 -07:00

receive.cpp

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

receive.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

scriptpubkeyman.cpp

wallet, rpc: remove obsolete "keypoololdest" result field/code

2025-05-23 00:26:01 +02:00

scriptpubkeyman.h

wallet, rpc: remove obsolete "keypoololdest" result field/code

2025-05-23 00:26:01 +02:00

spend.cpp

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

spend.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

sqlite.cpp

threading: rename CSemaphore methods to match std::semaphore

2025-05-08 18:42:09 +00:00

sqlite.h

threading: semaphore: move CountingSemaphoreGrant to its own header

2025-05-10 03:31:30 +00:00

transaction.cpp

…

transaction.h

wallet: Drop unused fFromMe from CWalletTx

2025-05-14 11:23:22 -07:00

types.h

scripted-diff: modernize outdated trait patterns - types

2025-02-21 10:41:27 +01:00

wallet.cpp

wallet, rpc: remove obsolete "keypoololdest" result field/code

2025-05-23 00:26:01 +02:00

wallet.h

wallet, rpc: remove obsolete "keypoololdest" result field/code

2025-05-23 00:26:01 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

walletdb.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

wallettool.cpp

Remove create options from wallet tool

2025-05-09 15:07:04 +02:00

wallettool.h

…

walletutil.cpp

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

walletutil.h

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00