mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-22 13:29:45 +00:00
ab233255d4
6da6f503a6dd8de85780ca402f5202095aa8b6ea refactor: Let CCoinsViewCache::BatchWrite return void (TheCharlatan)
Pull request description:
CCoinsViewCache::BatchWrite always returns true if called from a backed cache, so just return void instead. Also return void from ::Sync and ::Flush.
This allows for dropping a FatalError condition and simplifying some dead error handling code a bit.
Since we now no longer exercise the "error path" when returning from `CCoinsView::BatchWrite`, make the method clear the cache instead. This should only be exercised by tests and not change production behaviour. This might slightly improve the coins_view fuzz test's ability to generate better coverage.
ACKs for top commit:
l0rinc:
ACK 6da6f503a6dd8de85780ca402f5202095aa8b6ea
andrewtoth:
re-ACK 6da6f503a6dd8de85780ca402f5202095aa8b6ea
achow101:
ACK 6da6f503a6dd8de85780ca402f5202095aa8b6ea
w0xlt:
ACK 6da6f503a6
Tree-SHA512: dfaa325b0cf8108910aebf1b27434aaddb639d10d860e96797c77ea42eca9035a54a7dc1d6a5d4eae2b75fcc9356206d3d5672243d2c906e80d19024c8b95408
59 lines
1.8 KiB
C++
59 lines
1.8 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_TXDB_H
|
|
#define BITCOIN_TXDB_H
|
|
|
|
#include <coins.h>
|
|
#include <dbwrapper.h>
|
|
#include <kernel/caches.h>
|
|
#include <kernel/cs_main.h>
|
|
#include <sync.h>
|
|
#include <util/fs.h>
|
|
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
class COutPoint;
|
|
class uint256;
|
|
|
|
//! User-controlled performance and debug options.
|
|
struct CoinsViewOptions {
|
|
//! Maximum database write batch size in bytes.
|
|
size_t batch_write_bytes{DEFAULT_DB_CACHE_BATCH};
|
|
//! If non-zero, randomly exit when the database is flushed with (1/ratio) probability.
|
|
int simulate_crash_ratio{0};
|
|
};
|
|
|
|
/** CCoinsView backed by the coin database (chainstate/) */
|
|
class CCoinsViewDB final : public CCoinsView
|
|
{
|
|
protected:
|
|
DBParams m_db_params;
|
|
CoinsViewOptions m_options;
|
|
std::unique_ptr<CDBWrapper> m_db;
|
|
public:
|
|
explicit CCoinsViewDB(DBParams db_params, CoinsViewOptions options);
|
|
|
|
std::optional<Coin> GetCoin(const COutPoint& outpoint) const override;
|
|
bool HaveCoin(const COutPoint &outpoint) const override;
|
|
uint256 GetBestBlock() const override;
|
|
std::vector<uint256> GetHeadBlocks() const override;
|
|
void BatchWrite(CoinsViewCacheCursor& cursor, const uint256& hashBlock) override;
|
|
std::unique_ptr<CCoinsViewCursor> Cursor() const override;
|
|
|
|
//! Whether an unsupported database format is used.
|
|
bool NeedsUpgrade();
|
|
size_t EstimateSize() const override;
|
|
|
|
//! Dynamically alter the underlying leveldb cache size.
|
|
void ResizeCache(size_t new_cache_size) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
|
|
};
|
|
|
|
#endif // BITCOIN_TXDB_H
|