Andrew Chow cb552c5f21

Merge bitcoin/bitcoin#26192: rpc: Improve error when wallet is already loaded ...

04609284ad5e0b72651f2d4b43263461ada40816 rpc: Improve error when wallet is already loaded (Aurèle Oulès)

Pull request description:

  Currently, trying to load a descriptor (sqlite) wallet that is already loaded throws the following error:
  > error code: -4
  > error message:
  > Wallet file verification failed. SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of Bitcoin Core?

  I don't think it is very clear what it means for a user.

  While a legacy wallet would throw:
  > error code: -35
  > error message:
  > Wallet file verification failed. Refusing to load database. Data file '/home/user/.bitcoin/signet/wallets/test_wallet/wallet.dat' is already loaded.

  This PR changes the error message for both types of wallet to:
  > error code: -35
  > error message:
  > Wallet file verification failed. Wallet "test_wallet" is already loaded.

ACKs for top commit:
  achow101:
    ACK 04609284ad5e0b72651f2d4b43263461ada40816
  hernanmarino:
    ACK  0460928
  theStack:
    Tested ACK 04609284ad5e0b72651f2d4b43263461ada40816

Tree-SHA512: a8f3d5133bfaef7417a6c05d160910ea08f32ac62bfdf7f5ec305ff5b62e9113b55f385abab4d5a4ad711aabcb1eb7ef746eb41f841b196e8fb5393ab3ccc01e

2023-01-03 13:02:20 -05:00

..

bench

Merge bitcoin/bitcoin#26481: bench: Suppress output when running with -sanity-check option

2022-12-29 11:42:03 +01:00

common

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

compat

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

config

…

consensus

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

crc32c

…

crypto

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

index

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

init

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

interfaces

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

ipc

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

kernel

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h

2022-11-30 10:37:57 +00:00

leveldb

…

logging

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

minisketch

Update minisketch subtree to latest upstream

2022-10-23 15:03:04 +01:00

node

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

policy

scripted-diff: Insert missed copyright header

2022-12-24 23:59:12 +00:00

primitives

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

qt

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rpc

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

script

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

secp256k1

…

support

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

test

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

univalue

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

util

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

wallet

Merge bitcoin/bitcoin#26192: rpc: Improve error when wallet is already loaded

2023-01-03 13:02:20 -05:00

zmq

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

.bear-tidy-config

…

.clang-format

…

.clang-tidy

…

addrdb.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

addrdb.h

…

addrman_impl.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

addrman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

addrman.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

arith_uint256.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

arith_uint256.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

attributes.h

…

banman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

banman.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

base58.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

base58.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bech32.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bech32.h

…

bitcoin-chainstate.cpp

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bitcoind-res.rc

…

bitcoind.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

blockencodings.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

blockencodings.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

blockfilter.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

blockfilter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

chain.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

chain.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

chainparams.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

clientversion.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

clientversion.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coins.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coins.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

compressor.cpp

…

compressor.h

…

core_io.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

core_memusage.h

…

core_read.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

core_write.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

cuckoocache.h

…

dbwrapper.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

dbwrapper.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

deploymentstatus.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

dummywallet.cpp

…

external_signer.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer.h

…

flatfile.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

flatfile.h

…

fs.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fs.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

hash.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

hash.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

headerssync.cpp

…

headerssync.h

…

httprpc.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

httprpc.h

…

httpserver.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

httpserver.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

i2p.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

i2p.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

indirectmap.h

…

init.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

init.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

key_io.cpp

…

key_io.h

…

key.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

key.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

logging.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

logging.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

Makefile.am

Merge bitcoin/bitcoin#26298: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a

2022-12-07 14:54:23 +00:00

Makefile.bench.include

Merge bitcoin/bitcoin#16981: Improve runtime performance of --reindex

2022-11-15 19:23:39 -05:00

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.minisketch.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

Makefile.test_util.include

refactor: unify test/util/wallet.h with wallet/test/util.h

2022-11-21 17:30:00 -03:00

Makefile.test.include

Merge bitcoin/bitcoin#25789: test: clean and extend availablecoins_tests coverage

2023-01-03 12:52:40 -05:00

Makefile.univalue.include

…

mapport.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

mapport.h

…

memusage.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

merkleblock.cpp

…

merkleblock.h

…

net_permissions.cpp

…

net_permissions.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net_processing.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net_processing.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net_types.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net_types.h

…

net.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netaddress.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netaddress.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netbase.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netbase.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netgroup.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netgroup.h

…

netmessagemaker.h

…

noui.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

noui.h

…

outputtype.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

outputtype.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

pow.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

pow.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

prevector.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

protocol.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

protocol.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

psbt.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

psbt.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

pubkey.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

pubkey.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

random.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

random.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

randomenv.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

randomenv.h

…

rest.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rest.h

…

reverse_iterator.h

…

scheduler.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

scheduler.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

serialize.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

shutdown.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

shutdown.h

…

signet.cpp

…

signet.h

…

span.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

streams.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

sync.cpp

…

sync.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

threadsafety.h

…

timedata.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

timedata.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

tinyformat.h

clang-tidy: Fix modernize-use-nullptr in headers

2022-12-15 20:58:19 +00:00

torcontrol.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

torcontrol.h

…

txdb.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txdb.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txmempool.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txmempool.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txorphanage.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txorphanage.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

txrequest.cpp

…

txrequest.h

…

uint256.cpp

…

uint256.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

undo.h

…

validation.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

validation.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

validationinterface.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

validationinterface.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

version.h

…

versionbits.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

versionbits.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

walletinitinterface.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

warnings.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

warnings.h

…