Andrew Chow 887796a5ff

Merge bitcoin/bitcoin#23341: RPC: Better safety with newkeypool command and wallet backups ...

a2a92317ad4ab88cfca234f68337a7cd37897f10 rpc: Add warning to user about newkeypool command (Samuel Dobson)

Pull request description:

  This PR prevents `newkeypool` from being run on non-HD wallets, because this would require a new backup every time, so it isn't very safe.

  David Harding also suggested [here](https://github.com/bitcoin/bitcoin/pull/23093#issuecomment-945350003) that the RPC help text should include a warning to the users about the interaction between newkeypool.

ACKs for top commit:
  achow101:
    ACK a2a92317ad4ab88cfca234f68337a7cd37897f10

Tree-SHA512: 0aa497900f1d179764bce13ffce0bb081ba2ca354492bf2e04b21d0212e960b3ed13a386fbf65602b6b50461f4056a0285752ef707d312da28e82449cd8ea048

2021-12-20 14:51:39 -05:00

..

rpc

Merge bitcoin/bitcoin#23341: RPC: Better safety with newkeypool command and wallet backups

2021-12-20 14:51:39 -05:00

test

Merge bitcoin/bitcoin#22019: wallet: Introduce SelectionResult for encapsulating a coin selection solution

2021-12-09 17:21:46 +01:00

bdb.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

bdb.h

wallet: Fixed Grammatical error in bdb.h

2021-11-09 12:41:37 +01:00

coincontrol.cpp

…

coincontrol.h

External input fund support cleanups

2021-10-06 06:55:34 +08:00

coinselection.cpp

wallet: Replace Assume with Assert where needed in coinselection

2021-12-13 14:45:41 +01:00

coinselection.h

Use SelectionResult for waste calculation

2021-12-05 13:43:28 -05:00

context.cpp

…

context.h

wallet: Call load handlers without cs_wallet locked

2021-11-22 09:42:36 +00:00

crypter.cpp

…

crypter.h

…

db.cpp

refactor: get wallet path relative to wallet_dir

2021-10-29 09:36:32 -05:00

db.h

refactor: Move restorewallet() RPC logic to the wallet section

2021-12-15 18:41:40 -03:00

dump.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

psbt: sign without finalizing

2021-09-28 19:13:42 -04:00

external_signer_scriptpubkeyman.h

psbt: sign without finalizing

2021-09-28 19:13:42 -04:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

…

fees.cpp

…

fees.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

init.cpp

Mention bech32m in -addresstype and -changetype help

2021-11-16 12:20:13 -05:00

interfaces.cpp

refactor: Implement restorewallet() logic in the wallet section

2021-12-14 19:18:56 -03:00

ismine.h

refactor: Use underlying type of isminetype for isminefilter

2021-11-25 14:56:30 +01:00

load.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

load.h

…

receive.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

receive.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

salvage.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

salvage.h

…

scriptpubkeyman.cpp

psbt: Make sighash_type std::optional<int>

2021-12-08 09:43:26 -05:00

scriptpubkeyman.h

psbt: Actually use SIGHASH_DEFAULT

2021-12-08 09:43:30 -05:00

spend.cpp

Use SelectionResult in SelectCoins

2021-12-05 13:44:10 -05:00

spend.h

Use SelectionResult in SelectCoins

2021-12-05 13:44:10 -05:00

sqlite.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

sqlite.h

…

transaction.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

transaction.h

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

wallet.cpp

wallet: Strictly match tx change type to improve privacy

2021-12-17 07:59:39 +01:00

wallet.h

Merge bitcoin/bitcoin#23721: wallet, refactor: Move restorewallet() logic to the wallet section

2021-12-16 08:42:44 +01:00

walletdb.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

walletdb.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

wallettool.cpp

Merge bitcoin/bitcoin#23346: util, refactor: Improve headers for bitcoin-wallet tool

2021-12-09 13:44:24 +01:00

wallettool.h

util, refactor: Improve headers for bitcoin-wallet tool

2021-10-30 21:43:49 +03:00

walletutil.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

walletutil.h

…