cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-04 20:51:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 17e14ac92f
Merge #17781: rpc: Remove mempool global from miner 
faa92a2297b4a6aebdd58d1818c428f1c0346078 rpc: Remove mempool global from miner (MarcoFalke)
6666ef13f167cfe880c2e94c09d003594d010cf3 test: Properly document blockinfo size in miner_tests (MarcoFalke)

Pull request description:

  The miner needs read-only access to the mempool. Instead of using the mutable global `::mempool`, keep a immutable reference to a mempool that is passed to the miner. Apart from the obvious benefits of removing a global and making things immutable, this might also simplify testing with multiple mempools.

ACKs for top commit:
  promag:
    ACK faa92a2297b4a6aebdd58d1818c428f1c0346078.
  fjahr:
    ACK faa92a2297b4a6aebdd58d1818c428f1c0346078
  jnewbery:
    Code review ACK faa92a2297b4a6aebdd58d1818c428f1c0346078

Tree-SHA512: c44027b5d2217a724791166f3f3112c45110ac1dbb37bdae27148a0657e0d1a1d043b0d24e49fd45465ec014224d1b7eb15c92a33069ad883fa8ffeadc24735b
2020-01-02 17:50:56 -05:00
..
bench
Merge #17781: rpc: Remove mempool global from miner
2020-01-02 17:50:56 -05:00
compat
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
config
…
consensus
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
crypto
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
index
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
interfaces
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
leveldb
…
logging
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
node
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
policy
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
primitives
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
qt
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
rpc
Merge #17781: rpc: Remove mempool global from miner
2020-01-02 17:50:56 -05:00
script
Merge #16658: validation: Rename CheckInputs to CheckInputScripts
2020-01-02 11:09:00 -05:00
secp256k1
…
support
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
test
Merge #17781: rpc: Remove mempool global from miner
2020-01-02 17:50:56 -05:00
univalue
Update univalue subtree
2019-10-30 16:24:02 -04:00
util
Merge #17762: net: Log to net category for exceptions in ProcessMessages
2020-01-02 21:39:00 +01:00
wallet
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
zmq
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
.clang-format
…
addrdb.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrdb.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrman.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrman.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
banman.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
base58.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
base58.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bitcoind-res.rc
…
bitcoind.cpp
Merge #16839: Replace Connman and BanMan globals with NodeContext local
2019-10-30 12:35:41 +01:00
blockencodings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockencodings.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockfilter.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockfilter.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparams.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparams.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsbase.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsbase.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
coins.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compat.h
…
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
…
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_write.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
cuckoocache.h
Use correct C++11 header for std::swap()
2019-11-29 21:23:25 +02:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dummywallet.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
Fix occurences of c_str() used with size() to data()
2019-10-28 13:41:45 +01:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
…
hash.h
…
httprpc.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httprpc.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httpserver.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httpserver.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
indirectmap.h
…
init.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
init.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
logging.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
Makefile.am
scripts: add MACHO PIE check to security-check.py
2020-01-02 14:42:21 +08:00
Makefile.bench.include
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00
Makefile.leveldb.include
…
Makefile.qt_locale.include
qt: Periodic translations update
2019-09-30 09:41:11 +02:00
Makefile.qt.include
Merge #17513: refactor, qt: Nuke some circular dependencies
2019-11-21 19:38:39 +01:00
Makefile.qttest.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
Makefile.test_util.include
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00
Makefile.test.include
tests: Add fuzzing harness for various hex related functions
2019-12-16 22:50:49 +00:00
memusage.h
…
merkleblock.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
merkleblock.h
…
miner.cpp
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
miner.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net_permissions.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
net_permissions.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
net_processing.cpp
Merge #17762: net: Log to net category for exceptions in ProcessMessages
2020-01-02 21:39:00 +01:00
net_processing.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
Seed RNG with precision timestamps on receipt of net messages.
2019-11-23 16:06:34 -05:00
net.h
Merge #17243: p2p: add PoissonNextSend method that returns mockable time
2019-11-05 12:38:28 -05:00
netaddress.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
netaddress.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
netbase.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
netbase.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
noui.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pow.cpp
…
pow.h
…
prevector.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
protocol.cpp
…
protocol.h
Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr
2019-12-11 17:00:27 -05:00
psbt.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
psbt.h
Merge #17524: psbt: handle unspendable psbts
2019-12-10 12:12:10 -05:00
pubkey.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pubkey.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
random.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
random.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
randomenv.cpp
Put bounds on the number of CPUID leaves explored
2019-11-20 10:54:08 -08:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
scheduler.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
serialize.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
shutdown.cpp
Break circular dependency: init -> * -> init by extracting shutdown.h
2018-06-25 00:08:49 -04:00
shutdown.h
…
span.h
…
streams.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
sync.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
sync.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
timedata.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
torcontrol.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txmempool.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txmempool.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
ui_interface.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
ui_interface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
undo.h
…
validation.cpp
Merge #16658: validation: Rename CheckInputs to CheckInputScripts
2020-01-02 11:09:00 -05:00
validation.h
Use correct C++11 header for std::swap()
2019-11-29 21:23:25 +02:00
validationinterface.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
validationinterface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
version.h
…
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00