fanquake a33901cb6d

Merge #18814: rpc: Relock wallet only if most recent callback ...

9f59dde9740d065118bdddde75ef9f4e4603a7b1 rpc: Relock wallet only if most recent callback (João Barbosa)
a2e6db5c4f1bb52a8814102b628e51652493d06a rpc: Add mutex to guard deadlineTimers (João Barbosa)

Pull request description:

  This PR fixes an early relocking race condition from #18811 where old relock callback runs after new wallet unlock code and nRelockTime update but before rpcRunLater call, causing early relock and incorrect nRelockTime time

  Issue introduced in #18487.
  Fixes #18811.

ACKs for top commit:
  MarcoFalke:
    ACK 9f59dde9740d065118bdddde75ef9f4e4603a7b1
  ryanofsky:
    Code review ACK 9f59dde9740d065118bdddde75ef9f4e4603a7b1. No changes since last review except squashing commits.
  jonatack:
    ACK 9f59dde9740d065118bdddde75ef

Tree-SHA512: 2f7fc03e5ab6037337f2d82dfad432495cc337c77d07c968ee2355105db6292f24543c03456f5402e0e759577a4327758f9372f7ea29de6d56dc3695fda9b379

2020-05-13 17:36:06 +08:00

..

test

test: Fix outstanding -Wsign-compare errors

2020-05-08 11:18:43 -07:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

refactor: Add BerkeleyDatabaseVersion() function

2020-05-11 20:42:55 +03:00

db.h

build: Enable -Wsuggest-override

2020-05-12 18:03:39 +03:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Make InitError bilingual

2020-05-05 04:46:04 +03:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

Make InitError bilingual

2020-05-05 04:46:04 +03:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

rpcdump.cpp

Remove CWalletTx merging logic from AddToWallet

2020-05-01 05:59:09 -05:00

rpcwallet.cpp

Merge #18814: rpc: Relock wallet only if most recent callback

2020-05-13 17:36:06 +08:00

rpcwallet.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

scriptpubkeyman.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

scriptpubkeyman.h

Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction

2020-05-05 15:56:04 +12:00

wallet.cpp

Merge #18853: wallet: Fix typo in assert that is compile-time true

2020-05-06 14:19:41 +02:00

wallet.h

Merge #18814: rpc: Relock wallet only if most recent callback

2020-05-13 17:36:06 +08:00

walletdb.cpp

Merge #9381: Remove CWalletTx merging logic from AddToWallet

2020-05-06 11:36:32 +12:00

walletdb.h

Merge #9381: Remove CWalletTx merging logic from AddToWallet

2020-05-06 11:36:32 +12:00

wallettool.cpp

wallet: Report full error message in wallettool

2020-05-01 07:39:35 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

wallet: Make sure no WalletDescriptor members are uninitialized after construction

2020-04-27 14:20:26 +00:00