fanquake 6737331c4c

Merge bitcoin/bitcoin#29363: test: Fix CPartialMerkleTree.nTransactions signedness ...

facafa90f7a1eee452f9baf8a1b65a2edac0982b test: Fix CPartialMerkleTree.nTransactions signedness (MarcoFalke)

Pull request description:

  It is unsigned in Bitcoin Core, so the tests should match it:

  aa9231fafe/src/merkleblock.h (L59)

  Large positive values, or "negative" values, are rejected anyway, but it still seems fine to fix this.

  The bug was introduced when the code was written in d280617bf569f84457eaea546541dc74c67cd1e4.

  (Lowercase `i` means signed, see https://docs.python.org/3/library/struct.html#format-characters)

ACKs for top commit:
  theStack:
    LGTM ACK facafa90f7a1eee452f9baf8a1b65a2edac0982b
  Empact:
    ACK facafa90f7a1eee452f9baf8a1b65a2edac0982b

Tree-SHA512: 35ac11bb5382dffe132bfae6097efc343ef6c06b1b4b1545130ca27b228ca6894679004862fee921b095172abaddbef5972c24d9bc195ce970f35643bd4a0f09

2024-02-07 15:08:02 +00:00

..

crypto

[test/crypto] Add FSChaCha20Poly1305 AEAD python implementation

2023-09-29 17:50:38 +05:30

__init__.py

…

address.py

refactor: move address_to_scriptpubkey to address.py

2023-03-28 16:54:28 +01:00

authproxy.py

test: Rename EncodeDecimal to serialization_fallback

2023-06-29 19:51:43 +02:00

bdb.py

…

bip340_test_vectors.csv

…

blockfilter.py

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

blocktools.py

refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey

2023-03-28 16:58:16 +01:00

coverage.py

test: fix PEP484 no implicit optional argument types errors

2023-06-29 16:14:07 -06:00

descriptors.py

…

key.py

Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests

2023-11-07 16:48:57 -05:00

messages.py

test: Fix CPartialMerkleTree.nTransactions signedness

2024-02-01 13:18:40 +01:00

netutil.py

test: add coverage to feature_addrman.py

2023-10-01 22:43:49 -05:00

p2p.py

Merge bitcoin/bitcoin#29356: test: make v2transport arg in addconnection mandatory and few cleanups

2024-02-06 11:02:36 +00:00

psbt.py

test: PSBT: eliminate magic numbers for global unsigned tx key (0)

2023-03-04 12:43:38 +01:00

script_util.py

…

script.py

Merge bitcoin/bitcoin#28725: test: refactor: use built-in collection types for type hints (Python 3.9 / PEP 585)

2023-11-17 11:19:17 +00:00

segwit_addr.py

…

socks5.py

test: add keep_alive option to socks5 proxy in test_framework

2023-07-10 10:07:45 -04:00

test_framework.py

test: Use blocks_path where possible

2024-01-17 16:48:47 +01:00

test_node.py

net: enable v2transport by default

2024-01-29 22:48:01 -05:00

test_shell.py

…

util.py

test: detect OS consistently using platform.system()

2023-12-08 18:16:24 +01:00

v2_p2p.py

[test] make v2transport arg in addconnection mandatory and few cleanups

2024-01-31 22:37:54 +05:30

wallet_util.py

test: Add Wallet Unlock Context Manager

2023-10-10 18:12:31 +03:00

wallet.py

test: use built-in collection types for type hints (Python 3.9 / PEP 585)

2023-10-25 01:10:21 +02:00