Andrew Chow ba47a4ba97

Merge bitcoin/bitcoin#26668: wallet: if only have one output type, don't perform "mixed" coin selection ...

89c1491d35389eac0c1fecc59333cdfae3b1bd2c wallet: if only have one output type, don't perform "mixed" coin selection (furszy)

Pull request description:

  For wallets that only have one output type, we are currently performing the same
  selection process over the same coins twice.

  The "mixed coin selection" doesn't add any value to the result
  (there is nothing to mix if the available coins struct has only one type).

ACKs for top commit:
  achow101:
    ACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c
  john-moffett:
    ACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c
  kristapsk:
    cr utACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c

Tree-SHA512: 672eaeed3ba911d13fa61a46f719c8fe1ebe4d2dc7d723040e71937c693659411bc99cdbd9f0014e836b70eebeff1b8ca861f4d81d39e6f79f437364a526edbe

2022-12-14 16:16:03 -05:00

..

rpc

Merge bitcoin/bitcoin#26213: rpc: Strict type checking for RPC boolean parameters

2022-12-10 09:58:33 +00:00

test

Merge bitcoin/bitcoin#25729: wallet: Check max transaction weight in CoinSelection

2022-12-06 12:08:58 -05:00

bdb.cpp

Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging

2022-09-16 11:10:15 +01:00

bdb.h

…

coincontrol.cpp

…

coincontrol.h

wallet: skip available coins fetch if "other inputs" are disallowed

2022-10-26 15:47:51 -03:00

coinselection.cpp

wallet: Check max tx weight in coin selector

2022-12-05 19:32:11 +01:00

coinselection.h

wallet: Check max tx weight in coin selector

2022-12-05 19:32:11 +01:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Fixup clang-tidy named argument comments

2022-12-05 15:51:46 +00:00

dump.h

…

external_signer_scriptpubkeyman.cpp

GetExternalSigner(): fail if multiple signers are found

2022-06-09 20:34:46 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

feebumper.h

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

fees.cpp

Fixup clang-tidy named argument comments

2022-12-05 15:51:46 +00:00

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#26298: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a

2022-12-07 14:54:23 +00:00

ismine.h

…

load.cpp

wallet: trigger MaybeResendWalletTxs() every minute

2022-08-25 14:29:25 +01:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

receive.h

Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors

2022-08-16 13:08:05 -04:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

psbt: Include output pubkey in additional pubkeys to sign

2022-10-28 20:03:22 -04:00

scriptpubkeyman.h

wallet: add method for retrieving the end range for a ScriptPubKeyMan

2022-10-25 15:57:38 +02:00

spend.cpp

Merge bitcoin/bitcoin#26668: wallet: if only have one output type, don't perform "mixed" coin selection

2022-12-14 16:16:03 -05:00

spend.h

wallet: if only have one output type, don't perform "mixed" coin selection

2022-12-08 15:56:36 -03:00

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

wallet: Deduplicate Resend and ReacceptWalletTransactions

2022-08-29 12:38:06 -04:00

wallet.cpp

Merge bitcoin/bitcoin#26298: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a

2022-12-07 14:54:23 +00:00

wallet.h

Merge bitcoin/bitcoin#26302: refactor: Use type-safe time point for CWallet::m_next_resend

2022-10-24 10:11:13 +08:00

walletdb.cpp

Merge bitcoin/bitcoin#26462: wallet: fix crash on loading descriptor wallet containing legacy key type entries

2022-12-05 17:37:48 -05:00

walletdb.h

wallet: throw error if legacy entries are present on loading descriptor wallets

2022-11-08 12:29:12 +01:00

wallettool.cpp

Fixup clang-tidy named argument comments

2022-12-05 15:51:46 +00:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

Implement LegacyScriptPubKeyMan::MigrateToDescriptor

2022-08-25 16:25:53 -04:00