cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-07 06:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Wladimir J. van der Laan a22b62481a
Merge #17070: wallet: Avoid showing GUI popups on RPC errors 
facec1c643105d0ae74b5d32cf33d593f9e82a36 wallet: Avoid showing GUI popups on RPC errors (MarcoFalke)

Pull request description:

  RPC errors and warnings are shown as popups in the GUI instead of being returned to the RPC caller. For example,

  ```
  $ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
  error code: -4
  error message:
  Wallet loading failed.
  ```

  gives me a GUI popup and no reason why loading the wallet failed.

  After this pull request:

  ```
  $ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
  error code: -4
  error message:
  Wallet loading failed: Error loading /home/marco/workspace/btc_bitcoin_core/./test/functional/data/wallets/high_minversion/wallet.dat: Wallet requires newer version of Bitcoin Core

ACKs for top commit:
  laanwj:
    Code review ACK facec1c643105d0ae74b5d32cf33d593f9e82a36

Tree-SHA512: c8274bbb02cfcf71676eeec1e773e51fb3538cf93f82e7cb8536f4716d44ed819cdc162dfc039ac7386a4db381a734cdb27fd32567043a1180c02519fbcba194
2019-10-21 13:48:27 +02:00
..
bench
Remove unused includes
2019-10-15 22:56:43 +00:00
compat
build: Fix #include sys/poll.h to just poll.h (without sys/)
2019-10-09 13:30:36 +02:00
config
…
consensus
Remove unused includes
2019-10-15 22:56:43 +00:00
crypto
Remove unused includes
2019-10-15 22:56:43 +00:00
index
Remove unused includes
2019-10-15 22:56:43 +00:00
interfaces
Merge #17070: wallet: Avoid showing GUI popups on RPC errors
2019-10-21 13:48:27 +02:00
leveldb
Pull leveldb subtree
2019-01-26 12:45:48 -05:00
node
Remove unused includes
2019-10-15 22:56:43 +00:00
policy
Remove unused includes
2019-10-15 22:56:43 +00:00
primitives
Remove unused includes
2019-10-15 22:56:43 +00:00
qt
Merge #17070: wallet: Avoid showing GUI popups on RPC errors
2019-10-21 13:48:27 +02:00
rpc
Merge #17119: doc: Fix broken bitcoin-cli examples
2019-10-17 15:40:26 +02:00
script
Merge #16889: Add some general std::vector utility functions
2019-10-18 09:57:00 -04:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
Improve documentation of memory_cleanse()
2019-07-01 12:59:44 +02:00
test
Merge #16889: Add some general std::vector utility functions
2019-10-18 09:57:00 -04:00
univalue
…
util
Merge #17184: util: Filter out macOS process serial number
2019-10-18 17:38:38 -04:00
wallet
Merge #17070: wallet: Avoid showing GUI popups on RPC errors
2019-10-21 13:48:27 +02:00
zmq
Remove unused includes
2019-10-15 22:56:43 +00:00
.clang-format
util: Add AllowShortCaseLabelsOnASingleLine option
2019-10-14 13:24:54 +03:00
addrdb.cpp
addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
2019-06-14 08:30:43 +02:00
addrdb.h
banman: Add, use CBanEntry ctor that takes ban reason
2019-01-16 13:54:18 -05:00
addrman.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
addrman.h
[addrman] Ensure collisions eventually get resolved
2019-02-27 16:53:44 -05:00
amount.h
…
arith_uint256.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
arith_uint256.h
Remove unused includes
2019-10-15 22:56:43 +00:00
attributes.h
…
banman.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
banman.h
Allow connections from misbehavior banned peers.
2019-01-22 21:10:48 +00:00
base58.cpp
…
base58.h
…
bech32.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #16659: refactoring: Remove unused includes
2019-10-16 17:33:57 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
bitcoin-wallet-res.rc
[tools] Add wallet inspection and modification tool
2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
bitcoind-res.rc
…
bitcoind.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
Remove unused includes
2019-10-15 22:56:43 +00:00
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
refactor: Improve CRollingBloomFilter::reset by using std::fill
2019-05-22 15:55:50 +01:00
bloom.h
…
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
chain: Set all CBlockIndex members to null, remove SetNull helper
2019-10-16 13:06:50 -04:00
chainparams.cpp
chainparams: Bump assumed chain params
2019-10-01 07:33:24 -04:00
chainparams.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsbase.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
chainparamsbase.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsseeds.h
contrib: Remove invalid nodes from seeds list
2019-10-02 08:51:12 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
coins.h
make SaltedOutpointHasher noexcept
2019-09-25 20:56:38 +02:00
compat.h
windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2019-01-23 16:28:27 +08:00
compressor.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
compressor.h
…
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
…
core_read.cpp
Include core_io.h from core_read.cpp
2019-06-06 08:00:33 +02:00
core_write.cpp
Don't show addresses or P2PK in decoderawtransaction
2019-08-30 11:29:21 +09:00
cuckoocache.h
…
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
Remove unused includes
2019-10-15 22:56:43 +00:00
dummywallet.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
Style cleanup.
2019-02-22 17:38:45 -08:00
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
httprpc.h
Remove unused includes
2019-10-15 22:56:43 +00:00
httpserver.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
httpserver.h
Remove unused includes
2019-10-15 22:56:43 +00:00
indirectmap.h
…
init.cpp
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
init.h
…
key_io.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
key_io.h
…
key.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
key.h
CKey: add method to negate the key
2019-03-27 13:59:50 +01:00
limitedmap.h
…
logging.cpp
util: Filter control characters out of log messages
2019-10-15 10:53:17 +02:00
logging.h
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
Makefile.am
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
Makefile.bench.include
Merge #15649: Add ChaCha20Poly1305@Bitcoin AEAD
2019-07-11 22:00:16 +02:00
Makefile.leveldb.include
build: Remove WINVER pre define in Makefile.leveldb.inlcude
2019-01-26 09:28:48 +08:00
Makefile.qt_locale.include
qt: Periodic translations update
2019-09-30 09:41:11 +02:00
Makefile.qt.include
Always generate bitcoinstrings.cpp on make translate
2019-10-07 15:38:07 +11:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
tests: Add fuzzing harness for descriptor Span-parsing helpers
2019-10-15 22:47:08 +00:00
memusage.h
…
merkleblock.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
merkleblock.h
…
miner.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
miner.h
[rpc] mining: Omit uninitialized currentblockweight, currentblocktx
2019-02-12 11:34:57 -05:00
net_permissions.cpp
util: Move ResolveErrMsg to util/error
2019-08-15 10:05:32 -04:00
net_permissions.h
Make whitebind/whitelist permissions more flexible
2019-08-11 11:33:27 +09:00
net_processing.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
net_processing.h
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
net.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
net.h
txmempool: Make entry time type-safe (std::chrono)
2019-09-23 08:00:14 -04:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
Remove unused includes
2019-10-15 22:56:43 +00:00
netbase.cpp
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netbase.h
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netmessagemaker.h
…
noui.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
noui.h
Suppress output in test_bitcoin for expected errors
2019-07-03 14:03:21 +02:00
optional.h
Remove 'boost::optional'-related gcc warnings
2019-01-30 22:44:28 +02:00
outputtype.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
outputtype.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pow.cpp
…
pow.h
…
prevector.h
Remove unused includes
2019-10-15 22:56:43 +00:00
protocol.cpp
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
protocol.h
Remove unused includes
2019-10-15 22:56:43 +00:00
psbt.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
psbt.h
Fix bug where duplicate PSBT keys are accepted
2019-10-08 01:45:36 +03:00
pubkey.cpp
…
pubkey.h
…
random.cpp
random: remove call to RAND_screen() (Windows only)
2019-10-18 14:24:21 -04:00
random.h
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
rest.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
Switch all RNG code to the built-in PRNG.
2019-01-16 16:34:56 -08:00
scheduler.h
trivial: correct parameter name in comments
2019-02-10 17:17:32 -05:00
serialize.h
Remove unused includes
2019-10-15 22:56:43 +00:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
Remove unused includes
2019-10-15 22:56:43 +00:00
sync.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
sync.h
refactor: consolidate PASTE macros
2019-09-25 10:56:00 -04:00
threadinterrupt.cpp
…
threadinterrupt.h
Remove unused includes
2019-10-15 22:56:43 +00:00
threadsafety.h
Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
2019-05-17 13:29:04 +02:00
timedata.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
timedata.h
…
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
fix: tor: Call event_base_loopbreak from the event's callback
2019-07-17 15:32:38 +01:00
torcontrol.h
Remove unused includes
2019-10-15 22:56:43 +00:00
txdb.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
txdb.h
Remove unused includes
2019-10-15 22:56:43 +00:00
txmempool.cpp
feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic
2019-10-03 14:03:27 -04:00
txmempool.h
Remove unused includes
2019-10-15 22:56:43 +00:00
ui_interface.cpp
Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit
2019-06-18 15:59:53 -04:00
ui_interface.h
Remove unused includes
2019-10-15 22:56:43 +00:00
uint256.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
uint256.h
Remove unused includes
2019-10-15 22:56:43 +00:00
undo.h
…
validation.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
validation.h
Remove unused includes
2019-10-15 22:56:43 +00:00
validationinterface.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
validationinterface.h
Remove extra CBlockIndex declaration
2019-06-25 15:02:34 -04:00
version.h
…
versionbits.cpp
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbits.h
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbitsinfo.cpp
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: Cleanup walletinitinterface.h
2019-09-08 17:29:30 +03:00
warnings.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
warnings.h
Remove unused includes
2019-10-15 22:56:43 +00:00