mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-02 09:46:14 +00:00
Modify fuzzer logic to avoid setting `FRESH` for an outpoint that already exists unspent in the parent view, and ensure `FRESH` implies `DIRTY`. This keeps cursor invariants realistic and lets `BatchWrite` failures expose real bugs without resetting state.
378 lines
16 KiB
C++
378 lines
16 KiB
C++
// Copyright (c) 2020-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <coins.h>
|
|
#include <consensus/amount.h>
|
|
#include <consensus/tx_check.h>
|
|
#include <consensus/tx_verify.h>
|
|
#include <consensus/validation.h>
|
|
#include <policy/policy.h>
|
|
#include <primitives/transaction.h>
|
|
#include <script/interpreter.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <txdb.h>
|
|
#include <util/hasher.h>
|
|
|
|
#include <cassert>
|
|
#include <algorithm>
|
|
#include <cstdint>
|
|
#include <functional>
|
|
#include <limits>
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <ranges>
|
|
#include <stdexcept>
|
|
#include <string>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
namespace {
|
|
const Coin EMPTY_COIN{};
|
|
|
|
bool operator==(const Coin& a, const Coin& b)
|
|
{
|
|
if (a.IsSpent() && b.IsSpent()) return true;
|
|
return a.fCoinBase == b.fCoinBase && a.nHeight == b.nHeight && a.out == b.out;
|
|
}
|
|
|
|
/**
|
|
* MutationGuardCoinsViewCache asserts that nothing mutates cacheCoins until
|
|
* BatchWrite is called. It keeps a snapshot of the cacheCoins state, which it
|
|
* uses for the assertion in BatchWrite. After the call to the superclass
|
|
* CCoinsViewCache::BatchWrite returns, it recomputes the snapshot at that
|
|
* moment.
|
|
*/
|
|
class MutationGuardCoinsViewCache final : public CCoinsViewCache
|
|
{
|
|
private:
|
|
struct CacheCoinSnapshot {
|
|
COutPoint outpoint;
|
|
bool dirty{false};
|
|
bool fresh{false};
|
|
Coin coin;
|
|
bool operator==(const CacheCoinSnapshot&) const = default;
|
|
};
|
|
|
|
std::vector<CacheCoinSnapshot> ComputeCacheCoinsSnapshot() const
|
|
{
|
|
std::vector<CacheCoinSnapshot> snapshot;
|
|
snapshot.reserve(cacheCoins.size());
|
|
|
|
for (const auto& [outpoint, entry] : cacheCoins) {
|
|
snapshot.emplace_back(outpoint, entry.IsDirty(), entry.IsFresh(), entry.coin);
|
|
}
|
|
|
|
std::ranges::sort(snapshot, std::less<>{}, &CacheCoinSnapshot::outpoint);
|
|
return snapshot;
|
|
}
|
|
|
|
mutable std::vector<CacheCoinSnapshot> m_expected_snapshot{ComputeCacheCoinsSnapshot()};
|
|
|
|
public:
|
|
void BatchWrite(CoinsViewCacheCursor& cursor, const uint256& block_hash) override
|
|
{
|
|
// Nothing must modify cacheCoins other than BatchWrite.
|
|
assert(ComputeCacheCoinsSnapshot() == m_expected_snapshot);
|
|
CCoinsViewCache::BatchWrite(cursor, block_hash);
|
|
m_expected_snapshot = ComputeCacheCoinsSnapshot();
|
|
}
|
|
|
|
using CCoinsViewCache::CCoinsViewCache;
|
|
};
|
|
} // namespace
|
|
|
|
void initialize_coins_view()
|
|
{
|
|
static const auto testing_setup = MakeNoLogFileContext<>();
|
|
}
|
|
|
|
void TestCoinsView(FuzzedDataProvider& fuzzed_data_provider, CCoinsViewCache& coins_view_cache, CCoinsView& backend_coins_view, bool is_db)
|
|
{
|
|
bool good_data{true};
|
|
|
|
if (is_db) coins_view_cache.SetBestBlock(uint256::ONE);
|
|
COutPoint random_out_point;
|
|
Coin random_coin;
|
|
CMutableTransaction random_mutable_transaction;
|
|
LIMITED_WHILE(good_data && fuzzed_data_provider.ConsumeBool(), 10'000)
|
|
{
|
|
CallOneOf(
|
|
fuzzed_data_provider,
|
|
[&] {
|
|
if (random_coin.IsSpent()) {
|
|
return;
|
|
}
|
|
COutPoint outpoint{random_out_point};
|
|
Coin coin{random_coin};
|
|
if (fuzzed_data_provider.ConsumeBool()) {
|
|
// We can only skip the check if no unspent coin exists for this outpoint.
|
|
const bool possible_overwrite{coins_view_cache.PeekCoin(outpoint) || fuzzed_data_provider.ConsumeBool()};
|
|
coins_view_cache.AddCoin(outpoint, std::move(coin), possible_overwrite);
|
|
} else {
|
|
coins_view_cache.EmplaceCoinInternalDANGER(std::move(outpoint), std::move(coin));
|
|
}
|
|
},
|
|
[&] {
|
|
coins_view_cache.Flush(/*reallocate_cache=*/fuzzed_data_provider.ConsumeBool());
|
|
},
|
|
[&] {
|
|
coins_view_cache.Sync();
|
|
},
|
|
[&] {
|
|
uint256 best_block{ConsumeUInt256(fuzzed_data_provider)};
|
|
// Set best block hash to non-null to satisfy the assertion in CCoinsViewDB::BatchWrite().
|
|
if (is_db && best_block.IsNull()) best_block = uint256::ONE;
|
|
coins_view_cache.SetBestBlock(best_block);
|
|
},
|
|
[&] {
|
|
{
|
|
const auto reset_guard{coins_view_cache.CreateResetGuard()};
|
|
}
|
|
// Set best block hash to non-null to satisfy the assertion in CCoinsViewDB::BatchWrite().
|
|
if (is_db) {
|
|
const uint256 best_block{ConsumeUInt256(fuzzed_data_provider)};
|
|
if (best_block.IsNull()) {
|
|
good_data = false;
|
|
return;
|
|
}
|
|
coins_view_cache.SetBestBlock(best_block);
|
|
}
|
|
},
|
|
[&] {
|
|
Coin move_to;
|
|
(void)coins_view_cache.SpendCoin(random_out_point, fuzzed_data_provider.ConsumeBool() ? &move_to : nullptr);
|
|
},
|
|
[&] {
|
|
coins_view_cache.Uncache(random_out_point);
|
|
},
|
|
[&] {
|
|
if (fuzzed_data_provider.ConsumeBool()) {
|
|
backend_coins_view = CCoinsView{};
|
|
}
|
|
coins_view_cache.SetBackend(backend_coins_view);
|
|
},
|
|
[&] {
|
|
const std::optional<COutPoint> opt_out_point = ConsumeDeserializable<COutPoint>(fuzzed_data_provider);
|
|
if (!opt_out_point) {
|
|
good_data = false;
|
|
return;
|
|
}
|
|
random_out_point = *opt_out_point;
|
|
},
|
|
[&] {
|
|
const std::optional<Coin> opt_coin = ConsumeDeserializable<Coin>(fuzzed_data_provider);
|
|
if (!opt_coin) {
|
|
good_data = false;
|
|
return;
|
|
}
|
|
random_coin = *opt_coin;
|
|
},
|
|
[&] {
|
|
const std::optional<CMutableTransaction> opt_mutable_transaction = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider, TX_WITH_WITNESS);
|
|
if (!opt_mutable_transaction) {
|
|
good_data = false;
|
|
return;
|
|
}
|
|
random_mutable_transaction = *opt_mutable_transaction;
|
|
},
|
|
[&] {
|
|
CoinsCachePair sentinel{};
|
|
sentinel.second.SelfRef(sentinel);
|
|
size_t dirty_count{0};
|
|
CCoinsMapMemoryResource resource;
|
|
CCoinsMap coins_map{0, SaltedOutpointHasher{/*deterministic=*/true}, CCoinsMap::key_equal{}, &resource};
|
|
LIMITED_WHILE(good_data && fuzzed_data_provider.ConsumeBool(), 10'000)
|
|
{
|
|
CCoinsCacheEntry coins_cache_entry;
|
|
if (fuzzed_data_provider.ConsumeBool()) {
|
|
coins_cache_entry.coin = random_coin;
|
|
} else {
|
|
const std::optional<Coin> opt_coin = ConsumeDeserializable<Coin>(fuzzed_data_provider);
|
|
if (!opt_coin) {
|
|
good_data = false;
|
|
return;
|
|
}
|
|
coins_cache_entry.coin = *opt_coin;
|
|
}
|
|
// Avoid setting FRESH for an outpoint that already exists unspent in the parent view.
|
|
bool fresh{!coins_view_cache.PeekCoin(random_out_point) && fuzzed_data_provider.ConsumeBool()};
|
|
bool dirty{fresh || fuzzed_data_provider.ConsumeBool()};
|
|
auto it{coins_map.emplace(random_out_point, std::move(coins_cache_entry)).first};
|
|
if (dirty) CCoinsCacheEntry::SetDirty(*it, sentinel);
|
|
if (fresh) CCoinsCacheEntry::SetFresh(*it, sentinel);
|
|
dirty_count += dirty;
|
|
}
|
|
auto cursor{CoinsViewCacheCursor(dirty_count, sentinel, coins_map, /*will_erase=*/true)};
|
|
uint256 best_block{coins_view_cache.GetBestBlock()};
|
|
if (fuzzed_data_provider.ConsumeBool()) best_block = ConsumeUInt256(fuzzed_data_provider);
|
|
// Set best block hash to non-null to satisfy the assertion in CCoinsViewDB::BatchWrite().
|
|
if (is_db && best_block.IsNull()) best_block = uint256::ONE;
|
|
coins_view_cache.BatchWrite(cursor, best_block);
|
|
});
|
|
}
|
|
|
|
{
|
|
bool expected_code_path = false;
|
|
try {
|
|
(void)coins_view_cache.Cursor();
|
|
} catch (const std::logic_error&) {
|
|
expected_code_path = true;
|
|
}
|
|
assert(expected_code_path);
|
|
(void)coins_view_cache.DynamicMemoryUsage();
|
|
(void)coins_view_cache.EstimateSize();
|
|
(void)coins_view_cache.GetBestBlock();
|
|
(void)coins_view_cache.GetCacheSize();
|
|
(void)coins_view_cache.GetHeadBlocks();
|
|
(void)coins_view_cache.HaveInputs(CTransaction{random_mutable_transaction});
|
|
}
|
|
|
|
{
|
|
if (is_db) {
|
|
std::unique_ptr<CCoinsViewCursor> coins_view_cursor = backend_coins_view.Cursor();
|
|
assert(!!coins_view_cursor);
|
|
}
|
|
(void)backend_coins_view.EstimateSize();
|
|
(void)backend_coins_view.GetBestBlock();
|
|
(void)backend_coins_view.GetHeadBlocks();
|
|
}
|
|
|
|
if (fuzzed_data_provider.ConsumeBool()) {
|
|
CallOneOf(
|
|
fuzzed_data_provider,
|
|
[&] {
|
|
const CTransaction transaction{random_mutable_transaction};
|
|
bool is_spent = false;
|
|
for (const CTxOut& tx_out : transaction.vout) {
|
|
if (Coin{tx_out, 0, transaction.IsCoinBase()}.IsSpent()) {
|
|
is_spent = true;
|
|
}
|
|
}
|
|
if (is_spent) {
|
|
// Avoid:
|
|
// coins.cpp:69: void CCoinsViewCache::AddCoin(const COutPoint &, Coin &&, bool): Assertion `!coin.IsSpent()' failed.
|
|
return;
|
|
}
|
|
const int height{int(fuzzed_data_provider.ConsumeIntegral<uint32_t>() >> 1)};
|
|
const bool check_for_overwrite{transaction.IsCoinBase() || [&] {
|
|
for (uint32_t i{0}; i < transaction.vout.size(); ++i) {
|
|
if (coins_view_cache.PeekCoin(COutPoint{transaction.GetHash(), i})) return true;
|
|
}
|
|
return fuzzed_data_provider.ConsumeBool();
|
|
}()}; // We can only skip the check if the current txid has no unspent outputs
|
|
AddCoins(coins_view_cache, transaction, height, check_for_overwrite);
|
|
},
|
|
[&] {
|
|
(void)AreInputsStandard(CTransaction{random_mutable_transaction}, coins_view_cache);
|
|
},
|
|
[&] {
|
|
TxValidationState state;
|
|
CAmount tx_fee_out;
|
|
const CTransaction transaction{random_mutable_transaction};
|
|
if (ContainsSpentInput(transaction, coins_view_cache)) {
|
|
// Avoid:
|
|
// consensus/tx_verify.cpp:171: bool Consensus::CheckTxInputs(const CTransaction &, TxValidationState &, const CCoinsViewCache &, int, CAmount &): Assertion `!coin.IsSpent()' failed.
|
|
return;
|
|
}
|
|
TxValidationState dummy;
|
|
if (!CheckTransaction(transaction, dummy)) {
|
|
// It is not allowed to call CheckTxInputs if CheckTransaction failed
|
|
return;
|
|
}
|
|
if (Consensus::CheckTxInputs(transaction, state, coins_view_cache, fuzzed_data_provider.ConsumeIntegralInRange<int>(0, std::numeric_limits<int>::max()), tx_fee_out)) {
|
|
assert(MoneyRange(tx_fee_out));
|
|
}
|
|
},
|
|
[&] {
|
|
const CTransaction transaction{random_mutable_transaction};
|
|
if (ContainsSpentInput(transaction, coins_view_cache)) {
|
|
// Avoid:
|
|
// consensus/tx_verify.cpp:130: unsigned int GetP2SHSigOpCount(const CTransaction &, const CCoinsViewCache &): Assertion `!coin.IsSpent()' failed.
|
|
return;
|
|
}
|
|
(void)GetP2SHSigOpCount(transaction, coins_view_cache);
|
|
},
|
|
[&] {
|
|
const CTransaction transaction{random_mutable_transaction};
|
|
if (ContainsSpentInput(transaction, coins_view_cache)) {
|
|
// Avoid:
|
|
// consensus/tx_verify.cpp:130: unsigned int GetP2SHSigOpCount(const CTransaction &, const CCoinsViewCache &): Assertion `!coin.IsSpent()' failed.
|
|
return;
|
|
}
|
|
const auto flags = script_verify_flags::from_int(fuzzed_data_provider.ConsumeIntegral<script_verify_flags::value_type>());
|
|
if (!transaction.vin.empty() && (flags & SCRIPT_VERIFY_WITNESS) != 0 && (flags & SCRIPT_VERIFY_P2SH) == 0) {
|
|
// Avoid:
|
|
// script/interpreter.cpp:1705: size_t CountWitnessSigOps(const CScript &, const CScript &, const CScriptWitness &, unsigned int): Assertion `(flags & SCRIPT_VERIFY_P2SH) != 0' failed.
|
|
return;
|
|
}
|
|
(void)GetTransactionSigOpCost(transaction, coins_view_cache, flags);
|
|
},
|
|
[&] {
|
|
(void)IsWitnessStandard(CTransaction{random_mutable_transaction}, coins_view_cache);
|
|
});
|
|
}
|
|
|
|
{
|
|
const Coin& coin_using_access_coin = coins_view_cache.AccessCoin(random_out_point);
|
|
const bool exists_using_access_coin = !(coin_using_access_coin == EMPTY_COIN);
|
|
const bool exists_using_have_coin = coins_view_cache.HaveCoin(random_out_point);
|
|
const bool exists_using_have_coin_in_cache = coins_view_cache.HaveCoinInCache(random_out_point);
|
|
if (auto coin{coins_view_cache.GetCoin(random_out_point)}) {
|
|
assert(*coin == coin_using_access_coin);
|
|
assert(exists_using_access_coin && exists_using_have_coin_in_cache && exists_using_have_coin);
|
|
} else {
|
|
assert(!exists_using_access_coin && !exists_using_have_coin_in_cache && !exists_using_have_coin);
|
|
}
|
|
// If HaveCoin on the backend is true, it must also be on the cache if the coin wasn't spent.
|
|
const bool exists_using_have_coin_in_backend = backend_coins_view.HaveCoin(random_out_point);
|
|
if (!coin_using_access_coin.IsSpent() && exists_using_have_coin_in_backend) {
|
|
assert(exists_using_have_coin);
|
|
}
|
|
if (auto coin{backend_coins_view.GetCoin(random_out_point)}) {
|
|
assert(exists_using_have_coin_in_backend);
|
|
// Note we can't assert that `coin_using_get_coin == *coin` because the coin in
|
|
// the cache may have been modified but not yet flushed.
|
|
} else {
|
|
assert(!exists_using_have_coin_in_backend);
|
|
}
|
|
}
|
|
}
|
|
|
|
FUZZ_TARGET(coins_view, .init = initialize_coins_view)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
|
|
CCoinsView backend_coins_view;
|
|
CCoinsViewCache coins_view_cache{&backend_coins_view, /*deterministic=*/true};
|
|
TestCoinsView(fuzzed_data_provider, coins_view_cache, backend_coins_view, /*is_db=*/false);
|
|
}
|
|
|
|
FUZZ_TARGET(coins_view_db, .init = initialize_coins_view)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
|
|
auto db_params = DBParams{
|
|
.path = "",
|
|
.cache_bytes = 1_MiB,
|
|
.memory_only = true,
|
|
};
|
|
CCoinsViewDB backend_coins_view{std::move(db_params), CoinsViewOptions{}};
|
|
CCoinsViewCache coins_view_cache{&backend_coins_view, /*deterministic=*/true};
|
|
TestCoinsView(fuzzed_data_provider, coins_view_cache, backend_coins_view, /*is_db=*/true);
|
|
}
|
|
|
|
// Creates a CoinsViewOverlay and a MutationGuardCoinsViewCache as the base.
|
|
// This allows us to exercise all methods on a CoinsViewOverlay, while also
|
|
// ensuring that nothing can mutate the underlying cache until Flush or Sync is
|
|
// called.
|
|
FUZZ_TARGET(coins_view_overlay, .init = initialize_coins_view)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
|
|
CCoinsView backend_base_coins_view;
|
|
MutationGuardCoinsViewCache backend_cache{&backend_base_coins_view, /*deterministic=*/true};
|
|
CoinsViewOverlay coins_view_cache{&backend_cache, /*deterministic=*/true};
|
|
TestCoinsView(fuzzed_data_provider, coins_view_cache, backend_cache, /*is_db=*/false);
|
|
}
|