0578a6ddf6
4d219725a76672929fc405c39c869a4ab208efa9 wallet: test: Failed migration cleanup (David Gumberg) 77622e000bc29b01b7d7a4c0dd1d57efd454fc71 test: coverage for migration failure when last sync is beyond prune height (furszy) 86eaf71e609121c7306442b5a5e3636d70532abb wallet: migration, fix watch-only and solvables wallets names (furszy) fb4406e63aac558c4eec2b03ef6b2f8a6f13523b wallet: improve post-migration logging (furszy) 75b59e5aba4fae38c6ef37fdbcb177e7c5c9ed02 test: restorewallet, coverage for existing dirs, unnamed wallet and prune failure (furszy) 1d4662441feed1b143695134f001070000f37dbe test: add coverage for unnamed wallet migration failure (furszy) e47af692223238f7ea36bc644c1a2a6417ef745b wallet: fix unnamed wallet migration failure (furszy) e1e9d71da939a33fdd98019856f5c4411df95214 wallet: RestoreWallet failure, erase only what was created (furszy) b54cdfc61792a47cb685c2fbc8aa9200c3415515 wallettool: do not use fs::remove_all in createfromdump cleanup (Ava Chow) 5f07b93d7f6bf27462f99f711bbd240b3577a060 wallet: introduce method to return all db created files (furszy) 0a944e62cbc8f08a673f7a22c79b7ea254e13cc0 refactor: remove sqlite dir path back-and-forth conversion (furszy) Pull request description: Backports #34222 to 28.x ACKs for top commit: davidgumberg: crACK 4d219725a76672929fc405c39c869a4ab208efa9 polespinasa: crACK 4d219725a76672929fc405c39c869a4ab208efa9 Tree-SHA512: ea872c78e7403f2fe2c7e66dc3215ac01cefadea0b50a6cf2067220eb5138e23c6b4756c49582dc248c102ed8d4b67cde418fb557ea9e608920d0268ac369794
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.