MarcoFalke 30dd562fd2

Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations ...

0e279fe4899beae8630264ef1fe420dd71f29d5d walletdb: Remove unused static functions from walletdb.h (Andrew Chow)
9f536d4fe949666f14a0bf5b814522cecde71f56 wallettool: Have RecoverDatabaseFile return errors and warnings (Andrew Chow)
06e263a4e368671ebb4e4a77c1447ebd5104a488 Call RecoverDatabaseFile directly from wallettool (Andrew Chow)

Pull request description:

  Followup to #19324 addressing some comments.

  Removes the `SalvageWallet` function in wallettool and instead directly calls `RecoverDatabaseFile` as suggested in https://github.com/bitcoin/bitcoin/pull/19324#discussion_r450379596

  Removes the `LogPrintf`s and `tfm::format`s in `RecoverDatabaseFile` as noted in https://github.com/bitcoin/bitcoin/pull/19324#discussion_r448027237

  Removes the declarations of `VerifyEnvironment` and `VerifyDatabaseFile` that were forgotten in `walletdb.h` as noted in https://github.com/bitcoin/bitcoin/pull/19324#issuecomment-654389079

ACKs for top commit:
  meshcollider:
    Code review ACK 0e279fe4899beae8630264ef1fe420dd71f29d5d
  ryanofsky:
    Code review ACK 0e279fe4899beae8630264ef1fe420dd71f29d5d, just dropped last commit

Tree-SHA512: ffd01f30536c2eab4bf40ba363c3ea916ecef3c8f0c5262040b40498776ffb00f95240204a40e38415d6931800851d0a3fa63ee91efc1d329b60ac317da0363d

2020-08-14 15:12:44 +02:00

..

test

Make Hash[160] consume range-like objects

2020-07-30 13:57:54 -07:00

bdb.cpp

refactor: Make HexStr take a span

2020-08-06 19:41:43 +02:00

bdb.h

Remove BDB dummy databases

2020-07-29 12:30:23 -04:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

Introduce DummyDatabase and use it in the tests

2020-07-29 12:28:30 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

ismine.h

…

load.cpp

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

load.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

rpcdump.cpp

refactor: Make HexStr take a span

2020-08-06 19:41:43 +02:00

rpcwallet.cpp

Merge #19644: rpc: document returned error fields as optional if applicable

2020-08-14 09:57:58 +12:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

scriptpubkeyman.h

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

wallet.cpp

Merge #19568: Wallet should not override signing errors

2020-08-14 16:04:31 +08:00

wallet.h

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

walletdb.cpp

Make Hash[160] consume range-like objects

2020-07-30 13:57:54 -07:00

walletdb.h

Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations

2020-08-14 15:12:44 +02:00

wallettool.cpp

Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations

2020-08-14 15:12:44 +02:00

wallettool.h

…

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00