Merge bitcoin-core/gui#920 : Set peer version and subversion to N/A when not available or detecting

b261100e71697dd4859cdeb5a69f5a1d6c557099 [qt] Set peer version and subversion to N/A when not available or detecting (WakeTrainDev) Pull request description: In the debug console peer detail window, display "N/A" for the User Agent and Version when the peer is still detecting or the information is unavailable, instead of retaining the previous values. ACKs for top commit: maflcko: lgtm ACK b261100e71697dd4859cdeb5a69f5a1d6c557099 luke-jr: utACK b261100e71697dd4859cdeb5a69f5a1d6c557099 Tree-SHA512: ffcba716fe6173062fe00e2d428d41bbdcaebfe8c76c804519e46a448ade2785ae32efb1a30322adc19cf29e07ea8ab4d7593ef5a17b6c418c8dd77b381e4f77
Merge bitcoin/bitcoin#34390 : test: allow overriding tar in get_previous_releases.py
2026-01-31 10:41:08 +00:00 · 2026-01-25 14:23:05 +00:00 · 2026-01-25 12:05:18 +00:00 · 2026-01-23 13:05:45 +00:00 · 2025-12-21 13:09:08 +02:00
2 changed files with 5 additions and 7 deletions
--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@ -1175,12 +1175,8 @@ void RPCConsole::updateDetailWidget()
    ui->peerBytesRecv->setText(GUIUtil::formatBytes(stats->nodeStats.nRecvBytes));
    ui->peerPingTime->setText(GUIUtil::formatPingTime(stats->nodeStats.m_last_ping_time));
    ui->peerMinPing->setText(GUIUtil::formatPingTime(stats->nodeStats.m_min_ping_time));
-    if (stats->nodeStats.nVersion) {
-        ui->peerVersion->setText(QString::number(stats->nodeStats.nVersion));
-    }
-    if (!stats->nodeStats.cleanSubVer.empty()) {
-        ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer));
-    }
+    ui->peerVersion->setText(stats->nodeStats.nVersion ? QString::number(stats->nodeStats.nVersion) : ts.na);
+    ui->peerSubversion->setText(!stats->nodeStats.cleanSubVer.empty() ? QString::fromStdString(stats->nodeStats.cleanSubVer) : ts.na);
    ui->peerConnectionType->setText(GUIUtil::ConnectionTypeToQString(stats->nodeStats.m_conn_type, /*prepend_direction=*/true));
    ui->peerTransportType->setText(QString::fromStdString(TransportTypeAsString(stats->nodeStats.m_transport_type)));
    if (stats->nodeStats.m_transport_type == TransportProtocolType::V2) {
--- a/test/get_previous_releases.py
+++ b/test/get_previous_releases.py
@ -23,6 +23,8 @@ import time
 import urllib.request
 import zipfile

+TAR = os.getenv('TAR', 'tar')
+
 SHA256_SUMS = {
    "0e2819135366f150d9906e294b61dff58fd1996ebd26c2f8e979d6c0b7a79580": {"tag": "v0.14.3", "archive": "bitcoin-0.14.3-aarch64-linux-gnu.tar.gz"},
    "d86fc90824a85c38b25c8488115178d5785dbc975f5ff674f9f5716bc8ad6e65": {"tag": "v0.14.3", "archive": "bitcoin-0.14.3-arm-linux-gnueabihf.tar.gz"},
@ -214,7 +216,7 @@ def download_binary(tag, args) -> int:
            print(f"Zip extraction failed: {e}", file=sys.stderr)
            return 1
    else:
-        ret = subprocess.run(['tar', '-zxf', archive, '-C', tag,
+        ret = subprocess.run([TAR, '-zxf', archive, '-C', tag,
                              '--strip-components=1',
                              'bitcoin-{tag}'.format(tag=tag[1:])]).returncode
        if ret != 0:
Author	SHA1	Message	Date
Hennadii Stepanov	5f66fca633	Merge bitcoin-core/gui#920 : Set peer version and subversion to N/A when not available or detecting b261100e71697dd4859cdeb5a69f5a1d6c557099 [qt] Set peer version and subversion to N/A when not available or detecting (WakeTrainDev) Pull request description: In the debug console peer detail window, display "N/A" for the User Agent and Version when the peer is still detecting or the information is unavailable, instead of retaining the previous values. ACKs for top commit: maflcko: lgtm ACK b261100e71697dd4859cdeb5a69f5a1d6c557099 luke-jr: utACK b261100e71697dd4859cdeb5a69f5a1d6c557099 Tree-SHA512: ffcba716fe6173062fe00e2d428d41bbdcaebfe8c76c804519e46a448ade2785ae32efb1a30322adc19cf29e07ea8ab4d7593ef5a17b6c418c8dd77b381e4f77	2026-01-25 14:23:05 +00:00
Hennadii Stepanov	02240a7698	Merge bitcoin/bitcoin#34390 : test: allow overriding `tar` in `get_previous_releases.py` be2b48b9f3e56b672e391e18a09f2d5f4e78d74e test: allow overriding tar in get_previous_releases (fanquake) Pull request description: Facilitate use on distros that might have `tar` as something else, such as `gtar`, i.e Chimera. ACKs for top commit: maflcko: lgtm ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e hebasto: ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e, I have reviewed the code and it looks OK. sedited: ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e Tree-SHA512: e5da14ef17f37dc52e438f191efbe9041477246bab04b9e166cf2104389e97bfc6b41005c9d79a99f193e8d7b24ecd32dbd8344c65878e92fd94c77d3efbbe8c	2026-01-25 12:05:18 +00:00
fanquake	be2b48b9f3	test: allow overriding tar in get_previous_releases Facilitate use on distros that might have 'tar' as something else, such as 'gtar', i.e Chimera.	2026-01-23 13:05:45 +00:00
WakeTrainDev	b261100e71	[qt] Set peer version and subversion to N/A when not available or detecting	2025-12-21 13:09:08 +02:00