cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-31 10:41:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

noui: Remove always empty caption while formatting

Browse Source 
The only behavior change is in noui_ThreadSafeQuestion, which can not
detect a style and will log a strCaption=": ".

Fix this by removing it.
This commit is contained in:
MarcoFalke 2026-01-14 19:37:48 +01:00
parent fa8ebeb332
commit fad7bd9ba3
No known key found for this signature in database
4 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/noui.cpp
View File

@ -39,7 +39,6 @@ bool noui_ThreadSafeMessageBox(const bilingual_str& message, unsigned int style)
if (!fSecure) LogInfo("%s\n", message.original);
break;
default:
strCaption = ": "; // caption is always empty TODO fix this
if (!fSecure) LogInfo("%s%s\n", strCaption, message.original);
}

2
test/functional/feature_presegwit_node_upgrade.py
View File

@ -38,7 +38,7 @@ class SegwitUpgradeTest(BitcoinTestFramework):
# because the blockchain consists of 3 insufficiently validated blocks per segwit consensus rules.
node.assert_start_raises_init_error(
extra_args=["-testactivationheight=segwit@5"],
expected_msg=": Witness data for blocks after height 5 requires "
expected_msg="Witness data for blocks after height 5 requires "
f"validation. Please restart with -reindex..{os.linesep}"
"Please restart with -reindex or -reindex-chainstate to recover.",
)

2
test/functional/feature_reindex_init.py
View File

@ -21,7 +21,7 @@ class ReindexInitTest(BitcoinTestFramework):
self.log.info("Removing the block index leads to init error")
shutil.rmtree(node.blocks_path / "index")
node.assert_start_raises_init_error(
expected_msg=f": Error initializing block database.{os.linesep}"
expected_msg=f"Error initializing block database.{os.linesep}"
"Please restart with -reindex or -reindex-chainstate to recover.",
)

2
test/functional/rpc_blockchain.py
View File

@ -124,7 +124,7 @@ class BlockchainTest(BitcoinTestFramework):
self.log.info("A block tip of more than MAX_FUTURE_BLOCK_TIME in the future raises an error")
self.nodes[0].assert_start_raises_init_error(
extra_args=[f"-mocktime={TIME_RANGE_TIP - MAX_FUTURE_BLOCK_TIME - 1}"],
expected_msg=": The block database contains a block which appears to be from the future."
expected_msg="The block database contains a block which appears to be from the future."
" This may be due to your computer's date and time being set incorrectly."
f" Only rebuild the block database if you are sure that your computer's date and time are correct.{os.linesep}"
"Please restart with -reindex or -reindex-chainstate to recover.",